From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30202: 27.0.50; Code refactoring on assq-delete-all assoc-delete-all Date: Tue, 23 Jan 2018 18:05:16 +0200 Message-ID: <83r2qgzhkz.fsf@gnu.org> References: <87r2qilb3d.fsf@gmail.com> <83lggprj4c.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1516723475 18899 195.159.176.226 (23 Jan 2018 16:04:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 23 Jan 2018 16:04:35 +0000 (UTC) Cc: 30202@debbugs.gnu.org, monnier@iro.umontreal.ca To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 23 17:04:30 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee13Q-0003Wk-Sk for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jan 2018 17:04:08 +0100 Original-Received: from localhost ([::1]:37435 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee15R-0004cS-Cj for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jan 2018 11:06:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee15K-0004cD-K5 for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 11:06:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee15H-0001G0-Ap for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 11:06:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60142) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ee15H-0001Ft-7F for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 11:06:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ee15G-00018m-8F for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 11:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jan 2018 16:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30202 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30202-submit@debbugs.gnu.org id=B30202.15167235524357 (code B ref 30202); Tue, 23 Jan 2018 16:06:02 +0000 Original-Received: (at 30202) by debbugs.gnu.org; 23 Jan 2018 16:05:52 +0000 Original-Received: from localhost ([127.0.0.1]:39806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee155-00018D-Sx for submit@debbugs.gnu.org; Tue, 23 Jan 2018 11:05:52 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee154-00017x-9r for 30202@debbugs.gnu.org; Tue, 23 Jan 2018 11:05:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee14v-00016X-08 for 30202@debbugs.gnu.org; Tue, 23 Jan 2018 11:05:44 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee14i-00012D-EQ; Tue, 23 Jan 2018 11:05:28 -0500 Original-Received: from [176.228.60.248] (port=4575 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ee14g-0007OY-8p; Tue, 23 Jan 2018 11:05:27 -0500 In-reply-to: (message from Tino Calancha on Tue, 23 Jan 2018 09:02:12 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142431 Archived-At: > From: Tino Calancha > Date: Tue, 23 Jan 2018 09:02:12 +0900 (JST) > cc: Tino Calancha , 30202@debbugs.gnu.org, > monnier@iro.umontreal.ca > > Updated the patch with the NEWS entry and manual doc. Thanks, a few nits below. > +@defun assoc-delete-all key alist &optional test > +This function is like @code{assq-delete-all} except that accepts ^^^^^^^^^^^^^^^^^^^ "... except that it accepts" > +an optional argument @var{test} to compare the keys in @var{alist}. To make it even more clear, I would say except that it accepts an optional argument @var{test}, a predicate function to compare the keys in @var{alist}. > +@var{test} defaults to @code{equal}. An even more minor nit: try to avoid starting a sentence with @var. In an Info manual, @var produces UPPER CASE, which looks OK at the beginning of a sentence; but in the printed manual, @var produces a lower-case word in slant typeface, which makes the sentence begin with a lower-case letter. So it is better to either say If omitted or @code{nil}, @var{test} defaults to ... or even make it part of the previous sentence: ... a predicate function to compare the keys in @var{alist}; @var{test} defaults to @code{equal}. Or maybe even toss the reference to TEST: ... a predicate function to compare the keys in @var{alist}; if omitted, it defaults to @code{equal}. (And yes, I know that our manuals are full of sentences starting with @var; something to improve on, I guess.) Thanks!