From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow Date: Fri, 16 Feb 2018 10:00:55 +0200 Message-ID: <83r2ple53c.fsf@gnu.org> References: <87d28rt4jl.fsf@telefonica.net> <874lmxloo1.fsf@mail.linkov.net> <87d11kquw2.fsf@mail.linkov.net> <9c8f9d73-af0d-fdc7-7935-1a8a904c5c15@yandex.ru> <87607bunrz.fsf@mail.linkov.net> <52b6e1bb-5657-722f-eafe-73fc6c3a82a4@yandex.ru> <87r2pxvlah.fsf@mail.linkov.net> <87d11csg1u.fsf@mail.linkov.net> <2f104cc5-6629-b74c-4a9b-4d678d888841@yandex.ru> <87bmgpoqjr.fsf@mail.linkov.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1518768023 9009 195.159.176.226 (16 Feb 2018 08:00:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 16 Feb 2018 08:00:23 +0000 (UTC) Cc: 19045@debbugs.gnu.org, dgutov@yandex.ru To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 16 09:00:19 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emawI-0001ld-Tz for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Feb 2018 09:00:15 +0100 Original-Received: from localhost ([::1]:48765 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emayK-0002DQ-Tw for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Feb 2018 03:02:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emay5-0002CQ-Re for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2018 03:02:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emay2-0000JF-PP for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2018 03:02:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37675) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emay2-0000I6-Ks for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2018 03:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1emay2-0003mN-9y for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2018 03:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Feb 2018 08:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19045 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19045-submit@debbugs.gnu.org id=B19045.151876806711587 (code B ref 19045); Fri, 16 Feb 2018 08:02:02 +0000 Original-Received: (at 19045) by debbugs.gnu.org; 16 Feb 2018 08:01:07 +0000 Original-Received: from localhost ([127.0.0.1]:45572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emax9-00030Z-I1 for submit@debbugs.gnu.org; Fri, 16 Feb 2018 03:01:07 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emax7-0002tD-U2 for 19045@debbugs.gnu.org; Fri, 16 Feb 2018 03:01:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emawz-0007Hi-Ku for 19045@debbugs.gnu.org; Fri, 16 Feb 2018 03:01:00 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emawz-0007Hd-H5; Fri, 16 Feb 2018 03:00:57 -0500 Original-Received: from [176.228.60.248] (port=1655 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1emawz-0006On-3V; Fri, 16 Feb 2018 03:00:57 -0500 In-reply-to: <87bmgpoqjr.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 16 Feb 2018 00:07:20 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143335 Archived-At: > From: Juri Linkov > Date: Fri, 16 Feb 2018 00:07:20 +0200 > Cc: 19045@debbugs.gnu.org > > @@ -290,16 +290,12 @@ vc-do-command > (let* ((files > (mapcar (lambda (f) (file-relative-name (expand-file-name f))) > (if (listp file-or-list) file-or-list (list file-or-list)))) > + (message-truncate-lines t) This should have a comment explaining why it is needed. It should also mention that messages in this function are formatted in a certain way so as to put the important parts at the beginning, due to potential truncation of long messages. > - (message "Running %s in background..." full-command)) > + (message "Running in background: %s" full-command)) ^^ Extra blank. > - (message "Running %s in background... done" full-command)))) > + (let ((message-truncate-lines t)) > + (message "Finished in background: %s" full-command))))) I find the original more in line with what we do elsewhere in Emacs. If the problem is that "done" could be truncated, then please use Done in background: %s > - (error "Running %s...FAILED (%s)" full-command > - (if (integerp status) (format "status %d" status) status))) > + (error "Failed (%s): %s" > + (if (integerp status) (format "status %d" status) status) > + full-command)) > (when vc-command-messages > - (message "Running %s...OK = %d" full-command status)))) > + (message "Success (%d): %s" status full-command)))) "Failed" and "Success" don't go together well, as they use different grammatical form. How about using "Done" here as well? And won't status always be zero when it succeeds? If not, I'd use Done (status=%d): %s Thanks.