From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31288: 27.0.50; [PATCH] Make cairo build somewhat usable Date: Fri, 27 Apr 2018 17:55:57 +0300 Message-ID: <83r2n0u29u.fsf@gnu.org> References: <87lgd8kcrv.fsf@gmail.com> <83wowsu45h.fsf@gnu.org> <87y3h8vhrl.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1524840909 32092 195.159.176.226 (27 Apr 2018 14:55:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 27 Apr 2018 14:55:09 +0000 (UTC) Cc: 31288@debbugs.gnu.org To: Ari Roponen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 27 16:55:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fC4m8-0008CO-0K for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Apr 2018 16:55:04 +0200 Original-Received: from localhost ([::1]:48579 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fC4oD-0005yV-5r for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Apr 2018 10:57:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fC4o5-0005x1-AK for bug-gnu-emacs@gnu.org; Fri, 27 Apr 2018 10:57:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fC4o2-0000Pc-7W for bug-gnu-emacs@gnu.org; Fri, 27 Apr 2018 10:57:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33452) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fC4o2-0000PV-3T for bug-gnu-emacs@gnu.org; Fri, 27 Apr 2018 10:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fC4o1-0004z3-Ob for bug-gnu-emacs@gnu.org; Fri, 27 Apr 2018 10:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Apr 2018 14:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31288 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31288-submit@debbugs.gnu.org id=B31288.152484097919105 (code B ref 31288); Fri, 27 Apr 2018 14:57:01 +0000 Original-Received: (at 31288) by debbugs.gnu.org; 27 Apr 2018 14:56:19 +0000 Original-Received: from localhost ([127.0.0.1]:41349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fC4nL-0004y4-Av for submit@debbugs.gnu.org; Fri, 27 Apr 2018 10:56:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fC4nJ-0004xs-RB for 31288@debbugs.gnu.org; Fri, 27 Apr 2018 10:56:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fC4nB-0008FJ-FV for 31288@debbugs.gnu.org; Fri, 27 Apr 2018 10:56:12 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fC4nB-0008FC-Bl; Fri, 27 Apr 2018 10:56:09 -0400 Original-Received: from [176.228.60.248] (port=3300 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fC4nA-0007Id-Ip; Fri, 27 Apr 2018 10:56:09 -0400 In-reply-to: <87y3h8vhrl.fsf@gmail.com> (message from Ari Roponen on Fri, 27 Apr 2018 17:35:58 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145790 Archived-At: > From: Ari Roponen > Cc: 31288@debbugs.gnu.org > Date: Fri, 27 Apr 2018 17:35:58 +0300 > > >> -#if defined (USE_GTK) && defined (HAVE_GTK3) > >> + /* FIXME */ > >> +#if 0 && defined (USE_GTK) && defined (HAVE_GTK3) > >> if (FRAME_GTK_WIDGET (f)) > >> { > >> GdkWindow *w = gtk_widget_get_window (FRAME_GTK_WIDGET (f)); > > > > This hunk doesn't look right. If the code in question causes some > > trouble to a Cairo build, please ifdef it out only when USE_CAIRO is > > defined, not unconditionally. And if that still needs a FIXME > > comment, please add some description of what needs to be fixed and > > why. > > > > That hunk is inside #ifdef USE_CAIRO, like almost the whole body of > x_update_end. Ah, sorry I missed that. Still, what is the FIXME there? why not simply remove that part?