From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31754: 25.1; etags output lacks info for making xref more useful Date: Tue, 12 Jun 2018 20:05:38 +0300 Message-ID: <83r2lc3pgd.fsf@gnu.org> References: <83y3flp672.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1528823110 1254 195.159.176.226 (12 Jun 2018 17:05:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 12 Jun 2018 17:05:10 +0000 (UTC) Cc: 31754@debbugs.gnu.org To: Gauthier =?UTF-8?Q?=C3=96stervall?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 12 19:05:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSmjC-0000DG-7O for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jun 2018 19:05:06 +0200 Original-Received: from localhost ([::1]:57487 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSmlJ-0007EG-Bx for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jun 2018 13:07:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSmkA-0006U2-IW for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 13:06:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSmk6-0001lB-Ik for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 13:06:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37388) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSmk6-0001l3-EC for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 13:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fSmk6-0005R2-7C for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 13:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jun 2018 17:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31754 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31754-submit@debbugs.gnu.org id=B31754.152882314020863 (code B ref 31754); Tue, 12 Jun 2018 17:06:02 +0000 Original-Received: (at 31754) by debbugs.gnu.org; 12 Jun 2018 17:05:40 +0000 Original-Received: from localhost ([127.0.0.1]:45285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSmjj-0005QQ-T2 for submit@debbugs.gnu.org; Tue, 12 Jun 2018 13:05:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSmjh-0005QE-QY for 31754@debbugs.gnu.org; Tue, 12 Jun 2018 13:05:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSmjZ-0001L2-DR for 31754@debbugs.gnu.org; Tue, 12 Jun 2018 13:05:32 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSmjZ-0001Kx-8U; Tue, 12 Jun 2018 13:05:29 -0400 Original-Received: from [176.228.60.248] (port=4174 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fSmjY-0001Qm-NC; Tue, 12 Jun 2018 13:05:29 -0400 In-reply-to: (message from Gauthier =?UTF-8?Q?=C3=96stervall?= on Tue, 12 Jun 2018 16:49:44 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147332 Archived-At: > From: Gauthier Östervall > Date: Tue, 12 Jun 2018 16:49:44 +0200 > Cc: 31754@debbugs.gnu.org > > > So now I think that perhaps we should leave etags alone, and instead > > add a feature to xref whereby the lines in the XREF buffer will show > > in a tooltip the full signature of the function. > > I am not a fan of tooltips, to be honest. It's standard UI for these cases. But we could, of course, have an option whereby the XREF buffer itself would display enough of the function's beginning to show the same info. > In order to show the full signature, XREF would need to parse the > source files. Well, "parse" is really an exaggeration here. More like "display the first sexp", I'd say. Every programming language mode already knows how to do such limited "parsing". > etags is already parsing files anyway, I can't see why not let it > save whole signatures to TAGS? Because it will bloat TAGS by a large factor. Think about large projects with hundreds of source files. Even in Emacs, which is not such a large package by modern standards, the combined TAGS table weighs in at about 4MB. The larger TAGS, the slower searches and completion based on it. It isn't TAGS' role, anyway. TAGS is there to provide "links" to the places in sources where functions are defined, it only shows the text at that place for 2 purposes: (1) so that links won't break when the source file changes in small ways, and the function moves to a different line/byte offset; and (2) to show the identifier (the function's name) itself, so as to allow Emacs to find in TAGS the identifier the user requests. Anything else is something Xref should do when it finds the place where TAGS points, IMO. Besides, this feature will I think be valuable with Xref back-ends other than etags.