From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#2034: [PATCH] 27.0.50; Support mode line constructs for `mode-name' in c-mode Date: Wed, 04 Jul 2018 05:41:00 +0300 Message-ID: <83r2kjoh8j.fsf@gnu.org> References: <87skn8xhia.fsf@transitory.lefae.org> <47fd3239-fe83-0f2f-b903-e18713cc60f6@orcon.net.nz> <83sh51k65l.fsf@gnu.org> <870f8e5df67e29f9070abd858a98a037@webmail.orcon.net.nz> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1530672010 24999 195.159.176.226 (4 Jul 2018 02:40:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 4 Jul 2018 02:40:10 +0000 (UTC) Cc: 2034@debbugs.gnu.org, bug-gnu-emacs-bounces+psainty=orcon.net.nz@gnu.org To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 04 04:40:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faXi8-0006NL-Qj for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Jul 2018 04:40:04 +0200 Original-Received: from localhost ([::1]:43671 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faXkE-0000CE-AD for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Jul 2018 22:42:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faXk5-0000Bu-5F for bug-gnu-emacs@gnu.org; Tue, 03 Jul 2018 22:42:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1faXk2-0000w7-2M for bug-gnu-emacs@gnu.org; Tue, 03 Jul 2018 22:42:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37864) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1faXk1-0000w0-UC for bug-gnu-emacs@gnu.org; Tue, 03 Jul 2018 22:42:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1faXk1-00010K-OT for bug-gnu-emacs@gnu.org; Tue, 03 Jul 2018 22:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jul 2018 02:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 2034 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug wontfix Original-Received: via spool by 2034-submit@debbugs.gnu.org id=B2034.15306720763806 (code B ref 2034); Wed, 04 Jul 2018 02:42:01 +0000 Original-Received: (at 2034) by debbugs.gnu.org; 4 Jul 2018 02:41:16 +0000 Original-Received: from localhost ([127.0.0.1]:45761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faXjH-0000zI-NT for submit@debbugs.gnu.org; Tue, 03 Jul 2018 22:41:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faXjG-0000z6-1d for 2034@debbugs.gnu.org; Tue, 03 Jul 2018 22:41:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1faXjA-0000Z0-50 for 2034@debbugs.gnu.org; Tue, 03 Jul 2018 22:41:08 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faXj5-0000S0-RM; Tue, 03 Jul 2018 22:41:03 -0400 Original-Received: from [176.228.60.248] (port=4649 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1faXj5-0006HG-9T; Tue, 03 Jul 2018 22:41:03 -0400 In-reply-to: <870f8e5df67e29f9070abd858a98a037@webmail.orcon.net.nz> (message from Phil Sainty on Tue, 03 Jul 2018 10:53:30 +1200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148168 Archived-At: > Date: Tue, 03 Jul 2018 10:53:30 +1200 > From: Phil Sainty > Cc: 2034@debbugs.gnu.org, bug-gnu-emacs > > > On 2018-07-03 03:29, Eli Zaretskii wrote: > > I've just skimmed the patch, so apologies in advance if what I'm > > saying makes no sense. That said, did you try to compare the old and > > the new code when the flag strings have text properties, like faces or > > colors? The mode-line formatting code is tricky when text properties > > are involved. > > I haven't, but I don't *think* that's going to be a concern here. > > The code which formats the string of flags hasn't changed, and the > substrings (individual flags) which are passed to `format' are string > literals with no properties, so AFAICS the formatted string of flags > will not have any text properties when it is generated (which happens > afresh each time `c-update-modeline' is called). > > If I'm missing something here, I think I'll need some guidance on > how to test for potential problems. Give each of the substrings you concatenate a different face, and see what happens after concatenation when the result is shown on the mode line.