From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967) Date: Wed, 05 Sep 2018 05:38:45 +0300 Message-ID: <83r2i8y8ga.fsf@gnu.org> References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> <86wos25gvy.fsf@gmail.com> <83wos1xk4q.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1536115089 2625 195.159.176.226 (5 Sep 2018 02:38:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 5 Sep 2018 02:38:09 +0000 (UTC) Cc: 25967@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 05 04:38:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxNhk-0000XB-B9 for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Sep 2018 04:38:04 +0200 Original-Received: from localhost ([::1]:53534 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxNjq-0005Qq-G2 for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Sep 2018 22:40:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxNjh-0005QX-MI for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 22:40:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxNje-0005m6-ET for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 22:40:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41174) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fxNje-0005lL-4H for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 22:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fxNjd-0007I8-QO for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 22:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Sep 2018 02:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25967 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25967-submit@debbugs.gnu.org id=B25967.153611514127945 (code B ref 25967); Wed, 05 Sep 2018 02:40:01 +0000 Original-Received: (at 25967) by debbugs.gnu.org; 5 Sep 2018 02:39:01 +0000 Original-Received: from localhost ([127.0.0.1]:46192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxNif-0007Gc-Co for submit@debbugs.gnu.org; Tue, 04 Sep 2018 22:39:01 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxNid-0007GK-0g for 25967@debbugs.gnu.org; Tue, 04 Sep 2018 22:38:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxNiU-0004Mc-Nr for 25967@debbugs.gnu.org; Tue, 04 Sep 2018 22:38:53 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxNiU-0004MA-EH; Tue, 04 Sep 2018 22:38:50 -0400 Original-Received: from [176.228.60.248] (port=2105 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fxNiU-0006TH-1P; Tue, 04 Sep 2018 22:38:50 -0400 In-reply-to: (message from Andy Moreton on Tue, 04 Sep 2018 20:03:07 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150031 Archived-At: > From: Andy Moreton > Date: Tue, 04 Sep 2018 20:03:07 +0100 > > >> + '(imagemagick "libMagickWand-7.Q16HDRI-6.dll"))) > > > > Is this DLL name fixed for all the supported versions? It sounds > > like it's only for Imagemagick v7, and so the DLL for version 6 will > > be named differently. > > Indeed. v6 is legacy (and not available on any platform I currently test > on). I see a precompiled binary on the Imagemagick site. > The DLL name is from the current package for MSYS2. How frequently does the name of the DLL change? If it changes with each update, we should find a way of allowing users to still use previous or next compatible DLLs. We don't want to require them to upgrade all the time. > > For these two reasons, I think we should have a Lisp variable that > > provides the version of Imagemagick with which Emacs was built, and we > > need the dispatch in w32-win.el for loading the correct DLLs based on > > that variable, like we do with libgif etc. > > Agreed. Do you use Imagemagick on mingw.org builds ? Is there a packaged > library available there ? No, not that I know of. I think we should provide compatibility to MSYS2 packages and to packages provided by Imagemagick themselves.