From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33771: 27.0.50; Error building Harfbuzz branch on Debian testing Date: Sun, 16 Dec 2018 21:52:34 +0200 Message-ID: <83r2ehdzb1.fsf@gnu.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1544990255 29757 195.159.176.226 (16 Dec 2018 19:57:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 16 Dec 2018 19:57:35 +0000 (UTC) Cc: 33771@debbugs.gnu.org To: Philipp Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 16 20:57:31 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYcXa-0007eV-IT for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Dec 2018 20:57:30 +0100 Original-Received: from localhost ([::1]:43611 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYcZh-0007ds-Av for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Dec 2018 14:59:41 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYcYy-00078f-PH for bug-gnu-emacs@gnu.org; Sun, 16 Dec 2018 14:59:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYcTL-0000wD-2s for bug-gnu-emacs@gnu.org; Sun, 16 Dec 2018 14:53:12 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46326) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gYcTG-0000oo-Cm for bug-gnu-emacs@gnu.org; Sun, 16 Dec 2018 14:53:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gYcTG-0004Kx-9t for bug-gnu-emacs@gnu.org; Sun, 16 Dec 2018 14:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Dec 2018 19:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33771 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33771-submit@debbugs.gnu.org id=B33771.154498996516645 (code B ref 33771); Sun, 16 Dec 2018 19:53:02 +0000 Original-Received: (at 33771) by debbugs.gnu.org; 16 Dec 2018 19:52:45 +0000 Original-Received: from localhost ([127.0.0.1]:50584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYcSz-0004KN-Bq for submit@debbugs.gnu.org; Sun, 16 Dec 2018 14:52:45 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:60954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYcSy-0004KC-0l for 33771@debbugs.gnu.org; Sun, 16 Dec 2018 14:52:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYcSn-0008PV-Rc for 33771@debbugs.gnu.org; Sun, 16 Dec 2018 14:52:38 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYcSn-0008Oc-N8; Sun, 16 Dec 2018 14:52:33 -0500 Original-Received: from [176.228.60.248] (port=1528 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gYcSn-0006Ef-0Q; Sun, 16 Dec 2018 14:52:33 -0500 In-reply-to: (message from Philipp on Sun, 16 Dec 2018 19:57:54 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153498 Archived-At: > From: Philipp > Date: Sun, 16 Dec 2018 19:57:54 +0100 > > > Got the following compiler error when trying to compile the Harfbuzz > branch: > > CC ftfont.o > ftfont.c: In function ‘ftfont_shape’: > ftfont.c:2952:7: error: unknown type name ‘OTF’ > OTF *otf = ftfont_get_otf (ftfont_info); > ^~~ You are building without libotf? > ftfont.c:2952:18: warning: implicit declaration of function ‘ftfont_get_otf’; did you mean ‘ftfont_get_cache’? [-Wimplicit-function-declaration] > OTF *otf = ftfont_get_otf (ftfont_info); > ^~~~~~~~~~~~~~ > ftfont_get_cache > ftfont.c:2952:18: warning: nested extern declaration of ‘ftfont_get_otf’ [-Wnested-externs] > ftfont.c:2952:18: warning: initialization makes pointer from integer without a cast [-Wint-conversion] > ftfont.c:2954:14: warning: implicit declaration of function ‘ftfont_shape_by_flt’; did you mean ‘ftfont_shape_by_hb’? [-Wimplicit-function-declaration] > return ftfont_shape_by_flt (lgstring, font, ftfont_info->ft_size->face, > ^~~~~~~~~~~~~~~~~~~ > ftfont_shape_by_hb > ftfont.c:2954:14: warning: nested extern declaration of ‘ftfont_shape_by_flt’ [-Wnested-externs] > ftfont.c:2954:14: error: incompatible types when returning type ‘int’ but ‘Lisp_Object {aka struct Lisp_Object}’ was expected > return ftfont_shape_by_flt (lgstring, font, ftfont_info->ft_size->face, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > otf, &ftfont_info->matrix); > ~~~~~~~~~~~~~~~~~~~~~~~~~~ > ftfont.c:2957:1: warning: control reaches end of non-void function [-Wreturn-type] > } > ^ > Makefile:386: recipe for target 'ftfont.o' failed > make[1]: *** [ftfont.o] Error 1 Does the below fix the problem? diff --git a/src/ftfont.c b/src/ftfont.c index bc98896..bbdc936 100644 --- a/src/ftfont.c +++ b/src/ftfont.c @@ -2931,7 +2931,7 @@ ftfont_shape_by_hb (Lisp_Object lgstring, FT_Face ft_face, hb_font_t *hb_font, #endif /* HAVE_HARFBUZZ */ -#if defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ +#if defined HAVE_LIBOTF && (defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ) Lisp_Object ftfont_shape (Lisp_Object lgstring) @@ -2956,7 +2956,7 @@ ftfont_shape (Lisp_Object lgstring) } } -#endif /* defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ */ +#endif /* HAVE_LIBOTF && (HAVE_M17N_FLT || defined HAVE_HARFBUZZ) */ static const char *const ftfont_booleans [] = { ":antialias", @@ -3037,7 +3037,7 @@ static struct font_driver const ftfont_driver = #ifdef HAVE_LIBOTF .otf_capability = ftfont_otf_capability, #endif -#if defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ +#if defined HAVE_LIBOTF && (defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ) .shape = ftfont_shape, #endif #ifdef HAVE_OTF_GET_VARIATION_GLYPHS