From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34655: 26.1.92; Segfault in module with --module-assertions Date: Mon, 18 Mar 2019 19:53:03 +0200 Message-ID: <83r2b4ul1c.fsf@gnu.org> References: <874l8r1t3a.fsf@tcd.ie> <8336oamu3y.fsf@gnu.org> <87h8c1cv6l.fsf@tcd.ie> <83lg1dwhse.fsf@gnu.org> <87va0h12js.fsf@tcd.ie> <835zsgw3ui.fsf@gnu.org> <87ef7486h0.fsf@tcd.ie> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="50205"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34655@debbugs.gnu.org, p.stephani2@gmail.com To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 18 18:54:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5wSg-000CvU-1d for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Mar 2019 18:54:10 +0100 Original-Received: from localhost ([127.0.0.1]:45389 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5wSe-0003eY-VQ for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Mar 2019 13:54:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5wSZ-0003eR-F8 for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2019 13:54:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5wSY-0006EQ-Pb for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2019 13:54:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35623) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h5wSY-0006E8-Ev for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2019 13:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h5wSY-0001Ij-9E for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2019 13:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Mar 2019 17:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34655 X-GNU-PR-Package: emacs Original-Received: via spool by 34655-submit@debbugs.gnu.org id=B34655.15529316004954 (code B ref 34655); Mon, 18 Mar 2019 17:54:02 +0000 Original-Received: (at 34655) by debbugs.gnu.org; 18 Mar 2019 17:53:20 +0000 Original-Received: from localhost ([127.0.0.1]:49167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h5wRs-0001Hq-2i for submit@debbugs.gnu.org; Mon, 18 Mar 2019 13:53:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h5wRq-0001Hb-1k for 34655@debbugs.gnu.org; Mon, 18 Mar 2019 13:53:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5wRk-0005NC-Ia; Mon, 18 Mar 2019 13:53:12 -0400 Original-Received: from [176.228.60.248] (port=3332 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h5wRj-0001qA-TS; Mon, 18 Mar 2019 13:53:12 -0400 In-reply-to: <87ef7486h0.fsf@tcd.ie> (contovob@tcd.ie) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156462 Archived-At: > From: "Basil L. Contovounesios" > Cc: <34655@debbugs.gnu.org>, > Date: Mon, 18 Mar 2019 16:58:35 +0000 > > Eli Zaretskii writes: > > > The patch to fix this is below; it simply marks these copied values by > > hand, thus preventing them from being GCed. It ran successfully with > > even 50,000 iterations. > > I can confirm that your patch fixes the issue. Great, thanks for testing. > I am very grateful not only for your looking into this, but also for > taking the time to explain the whole process; it has been enlightening > and would have taken me a lot of time to figure out alone. You are welcome. I will wait for a few days to give Philipp and others a chance to comment, and push then if no one comes up with objections.