From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36803: 27.0.50; Update mode-line of every window when compilation ends Date: Fri, 26 Jul 2019 11:13:12 +0300 Message-ID: <83r26dmcx3.fsf@gnu.org> References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="22298"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 26 10:14:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqvMl-0005gu-E8 for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jul 2019 10:14:15 +0200 Original-Received: from localhost ([::1]:37216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqvMj-0003JD-F7 for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jul 2019 04:14:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42794) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqvMe-0003ID-1S for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 04:14:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqvMZ-0003Kr-SF for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 04:14:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60195) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hqvMZ-0003GT-NW for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 04:14:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hqvMY-0000td-Gd for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 04:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jul 2019 08:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36803 X-GNU-PR-Package: emacs Original-Received: via spool by 36803-submit@debbugs.gnu.org id=B36803.15641288133389 (code B ref 36803); Fri, 26 Jul 2019 08:14:02 +0000 Original-Received: (at 36803) by debbugs.gnu.org; 26 Jul 2019 08:13:33 +0000 Original-Received: from localhost ([127.0.0.1]:40783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqvM4-0000sb-TO for submit@debbugs.gnu.org; Fri, 26 Jul 2019 04:13:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqvM2-0000sN-Tv for 36803@debbugs.gnu.org; Fri, 26 Jul 2019 04:13:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hqvLr-0000k9-Ca; Fri, 26 Jul 2019 04:13:19 -0400 Original-Received: from [176.228.60.248] (port=3883 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hqvLq-0002k1-Ql; Fri, 26 Jul 2019 04:13:19 -0400 In-reply-to: <83ef2enosr.fsf@gnu.org> (message from Eli Zaretskii on Thu, 25 Jul 2019 17:59:00 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163749 Archived-At: > Date: Thu, 25 Jul 2019 17:59:00 +0300 > From: Eli Zaretskii > Cc: 36803@debbugs.gnu.org, larsi@gnus.org > > > If my bisection is correct, then this regression dates back from > > > > 645c8597e7f9fbc90ffe227d2be8ce383b0777ae > > * src/process.c (status_notify): Avoid global redisplay (bug#11822) > > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=645c8597e7f9fbc90ffe227d2be8ce383b0777ae > > Makes sense, I will look into why this change was made. Stefan, I'm looking and looking, and don't understand why that change made sense. The process-status indication in the mode line is shown in all windows, so status_notify is exactly the place where we should trigger update of all mode lines. Otherwise, we will have to sprinkle force-mode-line-update calls all over the place (and it still won't work well in the cases where the default sentinel is used, and this no Lisp is involved). So I think we should restore the old code, i.e. revert this part of the above-mentioned commit: --- a/src/process.c +++ b/src/process.c @@ -6694,10 +6694,12 @@ status_notify (struct Lisp_Process *deleting_process, p->update_tick = p->tick; /* Now output the message suitably. */ exec_sentinel (proc, msg); + if (BUFFERP (p->buffer)) + /* In case it uses %s in mode-line-format. */ + bset_update_mode_line (XBUFFER (p->buffer)); } } /* end for */ - update_mode_lines = 24; /* In case buffers use %s in mode-line-format. */ return got_some_output; } Am I missing something?