From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38181: Actual height of mode-line not taken into account Date: Fri, 15 Nov 2019 21:38:27 +0200 Message-ID: <83r2290w24.fsf@gnu.org> References: <87eeyd3ul0.fsf@bernoul.li> <83d0dt2qt6.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="101098"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38181@debbugs.gnu.org To: jonas@bernoul.li Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 15 20:39:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVhR1-000QD8-NK for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2019 20:39:11 +0100 Original-Received: from localhost ([::1]:44468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVhR0-00018p-3f for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2019 14:39:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60101) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVhQt-00018b-Kl for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 14:39:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVhQs-00014w-Jq for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 14:39:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56819) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVhQs-00014m-Gt for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 14:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iVhQs-0005b2-DO for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 14:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Nov 2019 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38181 X-GNU-PR-Package: emacs Original-Received: via spool by 38181-submit@debbugs.gnu.org id=B38181.157384673521497 (code B ref 38181); Fri, 15 Nov 2019 19:39:02 +0000 Original-Received: (at 38181) by debbugs.gnu.org; 15 Nov 2019 19:38:55 +0000 Original-Received: from localhost ([127.0.0.1]:37407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVhQk-0005ad-Ji for submit@debbugs.gnu.org; Fri, 15 Nov 2019 14:38:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVhQc-0005aG-PQ for 38181@debbugs.gnu.org; Fri, 15 Nov 2019 14:38:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36395) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iVhQX-0000Tj-4m; Fri, 15 Nov 2019 14:38:41 -0500 Original-Received: from [176.228.60.248] (port=2117 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iVhQW-0001Tg-HW; Fri, 15 Nov 2019 14:38:40 -0500 In-reply-to: <83d0dt2qt6.fsf@gnu.org> (message from Eli Zaretskii on Fri, 15 Nov 2019 15:48:53 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171686 Archived-At: > Date: Fri, 15 Nov 2019 15:48:53 +0200 > From: Eli Zaretskii > Cc: 38181@debbugs.gnu.org > > > From: Jonas Bernoulli > > Date: Tue, 12 Nov 2019 17:52:59 +0100 > > > > If the height of the mode-line is increased by inserting an image into > > it, then that height is not taken into account in a buffer/window until > > `redisplay' has been called at least once since the buffer was created. > > AFAIR, the mode line display is done lazily, because otherwise the > mode line would flicker. When you change the face, that triggers a > thorough redisplay, because any change in faces does that (it could > mean many faces now have a different appearance). Adding an image to > the mode line doesn't have that effect, which is why you need to force > redisplay manually. Btw, I was wrong above: enlarging the mode-line faces also causes a similar problem. Try this slightly modified recipe: (defun test-popup () (interactive) (set-face-attribute 'mode-line nil :height 350) (set-face-attribute 'mode-line-inactive nil :height 350) (with-current-buffer (generate-new-buffer "*test*") (save-excursion (insert "one\ntwo\nthree\nfour\nfive")) (let ((win (display-buffer (current-buffer) '(display-buffer-in-side-window (side . bottom))))) (fit-window-to-buffer win)))) and you will see that the buffer *test* isn't shown in its entirety, either. I think fit-window-to-buffer relies on window's metrics (like the number of lines in the text area) to be up to date, and that is only true after a window was redisplayed once since changing the mode-line height. Martin, is this correct?