From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Sat, 07 Dec 2019 19:53:04 +0200 Message-ID: <83r21gdnun.fsf@gnu.org> References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <87imna18nc.fsf@mail.linkov.net> <42c596c2-b5c1-9fc9-4b92-9c13b386d93d@yandex.ru> <83pnhgrlni.fsf@gnu.org> <83ftiasfdm.fsf@gnu.org> <83lfrulmva.fsf@gnu.org> <76a012f5-8cdd-75d5-322e-a453a612c655@yandex.ru> <83immxjs6q.fsf@gnu.org> <993b2f9c-6052-e791-3d3b-26d5fedd7d12@yandex.ru> <835ziuixke.fsf@gnu.org> <9c4768a5-ecce-68ce-c612-a001b2f6784d@yandex.ru> <8336dxh1ge.fsf@gnu.org> <6c68ceed-156c-a6f2-bf0f-21d7e9eb5692@yandex.ru> <831rthgy3u.fsf@gnu.org> <83o8wkfu63.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="2553"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 08 05:56:34 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1idocS-0000W0-SJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Dec 2019 05:56:33 +0100 Original-Received: from localhost ([::1]:55738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idocR-0003h9-Cp for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Dec 2019 23:56:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35501) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idoc0-0003gy-Pf for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 23:56:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idoby-0002YB-PH for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 23:56:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44344) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idobx-0002XG-P8 for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 23:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1idobx-00072x-P1 for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 23:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Dec 2019 04:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157578090627010 (code B ref 37774); Sun, 08 Dec 2019 04:56:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 8 Dec 2019 04:55:06 +0000 Original-Received: from localhost ([127.0.0.1]:50317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idob3-00071Y-R7 for submit@debbugs.gnu.org; Sat, 07 Dec 2019 23:55:06 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idob1-000711-Mm for 37774@debbugs.gnu.org; Sat, 07 Dec 2019 23:55:04 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ideGj-0000Bo-Mh; Sat, 07 Dec 2019 12:53:25 -0500 Original-Received: from [176.228.60.248] (port=2562 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ideGi-0006Hk-KZ; Sat, 07 Dec 2019 12:53:25 -0500 In-reply-to: (message from Dmitry Gutov on Sat, 7 Dec 2019 19:06:08 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173027 Archived-At: > Cc: 37774@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > Date: Sat, 7 Dec 2019 19:06:08 +0200 > > > I meant to avoid such consequences by making sure those other callers > > can never trigger this new processing of :extend. > > Eli, what you're asking for would be actively harmful. > > To make an analogy, when we're changing a core Emacs behavior, we > shouldn't try to make it work only on Tuesdays. Even if the original bug > reporter observed the problem on a Tuesday. Sorry, I don't see the analogy. We are not trying to change the core behavior, we are trying to change how themes define faces, in a way that makes the :extend attribute be implicitly inherited from the default spec of the face to the face after theme's customizations. All I want is to make sure no other caller of face-spec-recalc, one that has nothing to do with themes defining faces, picks up the change, because that would be unintended. If you consider this incorrect or unjustified, please explain why. > Can we please focus on the more pressing question: whether the proposed > patch actually works, and does that reliably, or are there > scenarios/configurations where it would do something unexpected. We were considering only one scenario: that of a theme defining its own face specs. face-spec-recalc is called in other scenarios, but I don't think we should consider them, because we don't want to change the behavior in any of those other scenarios. > > . the theme doesn't specify :extend > > . the default spec for a face specifies ':extend nil' > > > > In this case, after applying the theme, the face should have > > ':extend nil', implicitly "inherited" from the default spec. Do you > > agree? > > Ok, I think I understand the distinction: it's for when a character has > several faces specified for it. Yes, it's important when merging with those other faces that are in effect for displaying a character. > + (when (and theme-face-applied > + (eq 'unspecified (face-attribute face :extend frame t))) > + (let ((tail (plist-member default-attrs :extend))) > + (and tail (face-spec-set-2 face frame > + (list :extend (cadr tail)))))) This is OK, but why say (list :extend (cadr tail)) instead of just tail ? Unless I'm missing something here, the value of 'tail' here should be (:extend VAL), where VAL is either t or nil. Right?