From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41821: 28.0.50; read-directory-name in vc commands should provide defaults from projects Date: Thu, 25 Jun 2020 19:31:46 +0300 Message-ID: <83r1u3rtsd.fsf@gnu.org> References: <87r1ulxk48.fsf@mail.linkov.net> <7164426e-8c37-8839-64da-563cfa829b53@yandex.ru> <87mu50j5cu.fsf@mail.linkov.net> <87y2oh8fdv.fsf@mail.linkov.net> <87366ohw5z.fsf@mail.linkov.net> <878sge7jls.fsf@mail.linkov.net> <7e136435-7123-fa42-e4a8-66b82e6595da@yandex.ru> <87pn9pxris.fsf@mail.linkov.net> <83d05ottnw.fsf@gnu.org> <0b42f540-f779-446b-4411-8dae3a50d09d@yandex.ru> <837dvwtrv1.fsf@gnu.org> <835zbgtqps.fsf@gnu.org> <625de669-0715-1467-0bd1-84328b4bee5f@yandex.ru> <83wo3ws4g8.fsf@gnu.org> <83tuyzs2np.fsf@gnu.org> <14381b78-ab1c-91e0-2297-426620b19684@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="15617"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41821@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 25 18:33:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1joUoN-0003wI-AK for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jun 2020 18:33:15 +0200 Original-Received: from localhost ([::1]:46844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joUoM-0007CE-AW for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jun 2020 12:33:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joUoA-00079w-Km for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2020 12:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57673) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1joUoA-0003qY-9m for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2020 12:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1joUoA-0003TO-6F for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2020 12:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jun 2020 16:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41821 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 41821-submit@debbugs.gnu.org id=B41821.159310273413288 (code B ref 41821); Thu, 25 Jun 2020 16:33:02 +0000 Original-Received: (at 41821) by debbugs.gnu.org; 25 Jun 2020 16:32:14 +0000 Original-Received: from localhost ([127.0.0.1]:40986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joUnO-0003SG-6u for submit@debbugs.gnu.org; Thu, 25 Jun 2020 12:32:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joUnM-0003S1-2e for 41821@debbugs.gnu.org; Thu, 25 Jun 2020 12:32:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41890) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joUnG-0003SQ-4C; Thu, 25 Jun 2020 12:32:06 -0400 Original-Received: from [176.228.60.248] (port=1729 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1joUnF-0005C1-6H; Thu, 25 Jun 2020 12:32:05 -0400 In-Reply-To: <14381b78-ab1c-91e0-2297-426620b19684@yandex.ru> (message from Dmitry Gutov on Thu, 25 Jun 2020 16:50:24 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182370 Archived-At: > Cc: 41821@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > Date: Thu, 25 Jun 2020 16:50:24 +0300 > > > In general, code that doesn't _have_ to be preloaded, shouldn't be. > > If nothing else, it keeps the memory footprint of a bare Emacs > > smaller, and thus prevents us from slipping down the slippery slope of > > memory bloat. > > And having vc-hooks call project.el functions at runtime would somehow > force us to preload it? How? It's enough that someone makes the function a macro, or does something else similarly innocent. > > Anyway, if you-two feel strongly about keeping the current solution, > > i.e. having VC commands use project.el-collected history, I'd > > appreciate if that function could be moved to vc.el from vc-hooks.el, > > thanks in advance. > > We can't just move it: it accesses information private to project.el. > The best we could do is a wrapper function. Sorry, I don't understand: why can't we move it from vc-hooks.el to vc.el, and why doing that would need a wrapper?