From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#5050: 23.1; efiff: Displaying bytes instead of characters in messages Date: Thu, 20 Aug 2020 23:12:52 +0300 Message-ID: <83r1s1axff.fsf@gnu.org> References: <87ljhtnixd.fsf@gmx.de> <87o8n5macz.fsf@gnus.org> <87imddtahz.fsf@gmx.net> <87blj5ksso.fsf@gnus.org> <83tuwxayh3.fsf@gnu.org> <87wo1tjdca.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6071"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sebastian_rose@gmx.de, stephen.berman@gmx.net, 5050@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 20 22:14:25 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8qx7-0001TV-Bm for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Aug 2020 22:14:25 +0200 Original-Received: from localhost ([::1]:49658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8qx1-0007xT-Ir for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Aug 2020 16:14:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8qwk-0007xE-Qx for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 16:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60935) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k8qwk-0006Wx-Ha for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 16:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k8qwk-0004fk-B0 for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 16:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Aug 2020 20:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5050 X-GNU-PR-Package: emacs Original-Received: via spool by 5050-submit@debbugs.gnu.org id=B5050.159795438817892 (code B ref 5050); Thu, 20 Aug 2020 20:14:02 +0000 Original-Received: (at 5050) by debbugs.gnu.org; 20 Aug 2020 20:13:08 +0000 Original-Received: from localhost ([127.0.0.1]:44248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8qvr-0004eW-Om for submit@debbugs.gnu.org; Thu, 20 Aug 2020 16:13:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8qvp-0004e2-0G for 5050@debbugs.gnu.org; Thu, 20 Aug 2020 16:13:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47366) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8qvj-0006Rg-A7; Thu, 20 Aug 2020 16:12:59 -0400 Original-Received: from [176.228.60.248] (port=2862 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k8qvi-0004HI-Q8; Thu, 20 Aug 2020 16:12:59 -0400 In-Reply-To: <87wo1tjdca.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 20 Aug 2020 22:01:57 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185784 Archived-At: > From: Lars Ingebrigtsen > Cc: sebastian_rose@gmx.de, stephen.berman@gmx.net, 5050@debbugs.gnu.org > Date: Thu, 20 Aug 2020 22:01:57 +0200 > > Eli Zaretskii writes: > > > And anyway, Stephen just answered my question, and the diffs are > > displayed correctly with non-ASCII characters, not as raw bytes. So > > there's more here than meets the eye. > > They are, but the output in that buffer is just raw bytes -- no matter > whether the output is from stderr or stdout. There must be a decoding > thing that takes place later, but I'm still looking for where that > happens. (I'm wholly unfamiliar with the ediff code.) > > When I've found that, the fix would be to apply whatever it's doing to > the error buffer, too... Wait, the problematic text appears in the Ediff error buffer, right? So we should perhaps simply decode it? Does evaluating the below in that buffer fixes the problem? M-: (decode-coding-region (point-min) (point-max) 'undecided) RET