From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44303: 28.0.50; json-pretty-print-buffer creates spurious lock file Date: Fri, 30 Oct 2020 15:34:51 +0200 Message-ID: <83r1pfalc4.fsf@gnu.org> References: <87wnz9pd2j.fsf@runbox.com> <87o8kjhmg4.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19934"; mail-complaints-to="usenet@ciao.gmane.io" Cc: simenheg@runbox.com, 44303@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 30 14:37:41 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYUb6-00055y-NB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 14:37:40 +0100 Original-Received: from localhost ([::1]:38386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYUb5-000339-MS for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 09:37:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYUZX-0001mh-Ob for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 09:36:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45142) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYUZW-0001NP-Cs for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 09:36:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYUZW-00083i-An for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 09:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 13:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44303 X-GNU-PR-Package: emacs Original-Received: via spool by 44303-submit@debbugs.gnu.org id=B44303.160406491830894 (code B ref 44303); Fri, 30 Oct 2020 13:36:02 +0000 Original-Received: (at 44303) by debbugs.gnu.org; 30 Oct 2020 13:35:18 +0000 Original-Received: from localhost ([127.0.0.1]:56684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYUYo-00082E-Bq for submit@debbugs.gnu.org; Fri, 30 Oct 2020 09:35:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYUYm-000821-Ck for 44303@debbugs.gnu.org; Fri, 30 Oct 2020 09:35:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44334) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYUYg-0000wQ-NM; Fri, 30 Oct 2020 09:35:10 -0400 Original-Received: from [176.228.60.248] (port=2306 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kYUYe-0003xL-3D; Fri, 30 Oct 2020 09:35:09 -0400 In-Reply-To: <87o8kjhmg4.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 30 Oct 2020 14:28:59 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192102 Archived-At: > From: Lars Ingebrigtsen > Date: Fri, 30 Oct 2020 14:28:59 +0100 > Cc: 44303@debbugs.gnu.org > > > The buffer stays unchanged as expected since the pretty printed content > > is identical to the original. The buffer is not marked as modified (also > > expected), but a spurious lock file '.#test.json' has been created. > > Yup. It's this code in Freplace_buffer_contents: > > if (!inhibit_modification_hooks) > { > prepare_to_modify_buffer (BEGV, ZV, NULL); > specbind (Qinhibit_modification_hooks, Qt); > modification_hooks_inhibited = true; > } > > prepare_to_modify_buffer creates the backup file. But we then have this: if (modification_hooks_inhibited) { signal_after_change (BEGV, size_a, ZV - BEGV); update_compositions (BEGV, ZV, CHECK_INSIDE); } Does this not work, or fail to unlock the file? > But is that even needed here? Don't the later > Finsert_buffer_substring/del_range_both functions do the necessary > bookkeeping? We disable that by binding inhibit_modification_hooks, and we do that for speed, see the comment before that code.