From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46491: [feature/pgtk] Unused macro warning in image.c without ImageMagick Date: Sun, 14 Feb 2021 17:38:06 +0200 Message-ID: <83r1libqxt.fsf@gnu.org> References: <871rdksz8x.fsf@tcd.ie> <20210214.112019.308581254652492325.masm@luna.pink.masm11.me> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40467"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, masm+emacs@masm11.me, 46491@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 14 16:39:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBJUM-000ARe-Gc for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Feb 2021 16:39:10 +0100 Original-Received: from localhost ([::1]:43510 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBJUL-0004kb-IB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Feb 2021 10:39:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBJUE-0004iZ-4R for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2021 10:39:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBJUD-0006iD-TU for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2021 10:39:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lBJUD-0005Ib-Pp for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2021 10:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Feb 2021 15:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46491 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46491-submit@debbugs.gnu.org id=B46491.161331709720311 (code B ref 46491); Sun, 14 Feb 2021 15:39:01 +0000 Original-Received: (at 46491) by debbugs.gnu.org; 14 Feb 2021 15:38:17 +0000 Original-Received: from localhost ([127.0.0.1]:36579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBJTV-0005HX-4d for submit@debbugs.gnu.org; Sun, 14 Feb 2021 10:38:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBJTT-0005HL-2x for 46491@debbugs.gnu.org; Sun, 14 Feb 2021 10:38:15 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40114) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBJTL-0006VV-CE; Sun, 14 Feb 2021 10:38:07 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4200 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lBJTK-0006dM-RI; Sun, 14 Feb 2021 10:38:07 -0500 In-Reply-To: (message from Alan Third on Sun, 14 Feb 2021 10:03:25 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200011 Archived-At: > Date: Sun, 14 Feb 2021 10:03:25 +0000 > From: Alan Third > Cc: contovob@tcd.ie, 46491@debbugs.gnu.org > > > I wanted to make imagemagick images not blurry in image-mode on > > scale x2.0 monitor. > > > > With the exclusion, imagemagick generates scaled image pixel data, > > and the image is rendered twice in size, so it is blurry. > > Without the exclusion, imagemagick generates original image pixel data, > > and the image may not be enlarged (but shrinked), so it may not be blurry. > > > > For other than imagemagick, like png, original image pixel data is generated, > > and it is not blurry on scale x2.0 monitor. > > I am aware of this, I see the same thing on NS, but when native > transforms were introduced we decided that when a user asks > imagemagick to modify an image, imagemagick should actually do the > modifications and Emacs will just display the results. > > I don't know that it's important, though. I think it's quite important to have Emacs behave the same on all platforms. While we no longer recommend to build Emacs with ImageMagick, those who do build with it should be able to use its transforms, and disabling that is not necessarily a good idea. Instead of disabling ImageMagick transforms, why not tell users to build Emacs without ImageMagick?