From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46915: [PATCH] Remove unecessary change_req arg from overlays_at() Date: Thu, 04 Mar 2021 23:24:45 +0200 Message-ID: <83r1kuzk6a.fsf@gnu.org> References: <835z27jagi.fsf@gnu.org> <87r1kuadow.fsf@mdeb> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34216"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46915@debbugs.gnu.org To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 04 22:26:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHvU1-0008mP-NJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 22:26:09 +0100 Original-Received: from localhost ([::1]:41858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHvU0-000249-PN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 16:26:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHvTu-00023C-FE for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 16:26:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48950) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHvTu-00024b-8E for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 16:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHvTu-0008Q6-5E for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 16:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Mar 2021 21:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46915 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46915-submit@debbugs.gnu.org id=B46915.161489311132303 (code B ref 46915); Thu, 04 Mar 2021 21:26:02 +0000 Original-Received: (at 46915) by debbugs.gnu.org; 4 Mar 2021 21:25:11 +0000 Original-Received: from localhost ([127.0.0.1]:60496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHvT4-0008Ow-Oi for submit@debbugs.gnu.org; Thu, 04 Mar 2021 16:25:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHvT2-0008Og-PG for 46915@debbugs.gnu.org; Thu, 04 Mar 2021 16:25:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42624) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHvSw-0001XW-Ei; Thu, 04 Mar 2021 16:25:02 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3093 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lHvSv-0007RX-Fq; Thu, 04 Mar 2021 16:25:01 -0500 In-Reply-To: <87r1kuadow.fsf@mdeb> (message from Matt Armstrong on Thu, 04 Mar 2021 12:03:59 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201476 Archived-At: > From: Matt Armstrong > Cc: 46915@debbugs.gnu.org > Date: Thu, 04 Mar 2021 12:03:59 -0800 > > So, the benefit of this change can be summarized: > > - We don't think the current overlay implementation is necessarily the > right thing, so we can presume that this area will change at some > point. > > - If we simplify the API, future changes will be easier to review. In > particular, nobody will ever have to think about callers that want a > *PREV_PTR value with a false CHANGE_REQ, and no future implementer > will feel like they need to provide that functionality. I'm okay with doing this nad similar changes as part of landing the noverlay branch (or as part of some other similar redesign of how overlays work in Emacs). What I'd like to avoid is installing this change separately, as if it alone has enough merit. if the goal is to replace the current implementation with a more efficient one, that's a good change, and API simplifications could very well come with it. But not without it and not ahead of it. It's a bit like fixing whitespace: we don't like doing it in separate changesets, but together with other significant changes in the same area of the code. So I urge you to continue the work on the noverlay branch, and if that branch will come with this and other changes in the internal APIs, that's fine by me. My problem is only with installing API changes right now, when we are not at all sure yet the overlays redesign will indeed land any time soon. OK?