From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48137: 27.2; `package-install-file' fails when loading a package file with DOS line endings Date: Mon, 03 May 2021 21:52:38 +0300 Message-ID: <83r1in645l.fsf@gnu.org> References: <834kfmabvs.fsf@gnu.org> <83tunj651i.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3849"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48137@debbugs.gnu.org, monnier@iro.umontreal.ca To: Ioannis Kappas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 03 20:54:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lddi7-0000sL-SB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 20:54:27 +0200 Original-Received: from localhost ([::1]:42356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lddi6-0001Wl-Lj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 14:54:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lddhi-0001W1-8a for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 14:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36575) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lddhi-0000i5-1Q for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 14:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lddhi-00041C-1J for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 14:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 May 2021 18:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48137 X-GNU-PR-Package: emacs Original-Received: via spool by 48137-submit@debbugs.gnu.org id=B48137.162006798415429 (code B ref 48137); Mon, 03 May 2021 18:54:01 +0000 Original-Received: (at 48137) by debbugs.gnu.org; 3 May 2021 18:53:04 +0000 Original-Received: from localhost ([127.0.0.1]:48117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lddgl-00040n-RQ for submit@debbugs.gnu.org; Mon, 03 May 2021 14:53:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lddgj-00040Q-Rl for 48137@debbugs.gnu.org; Mon, 03 May 2021 14:53:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60193) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lddge-0008TB-6u; Mon, 03 May 2021 14:52:56 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2382 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lddgc-0000S6-Nj; Mon, 03 May 2021 14:52:55 -0400 In-Reply-To: (message from Ioannis Kappas on Mon, 3 May 2021 19:49:27 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205556 Archived-At: > From: Ioannis Kappas > Date: Mon, 3 May 2021 19:49:27 +0100 > Cc: Stefan Monnier , 48137@debbugs.gnu.org > > > I think it's wrong for package.el to try to decode these files. It > > should deliver the files to the disk exactly as they are received > > through the wire. And the only safe way of doing that is to treat > > these files as raw bytes. Where we must interpret some parts of the > > files, we should take precautions to handle the complications related > > to the encoding, but we should not try to decode anything. > > Thanks, I think there is agreement we shouldn't decode files coming > from a remote archive. Are there still concerns though with decoding > local .el files passed in to `package-install-file' supporting the > windows DOS EOL case Eli? Yes, I think we shouldn't decode _any_ files, not even the *.el files. That includes their EOL convention. Therefore, this: > If not, I would like to suggest a slightly > updated patch that is targeting .el files directly as an exemption: > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index ecb2573cab..19ab0445b9 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -2147,7 +2147,9 @@ package-install-file > (progn > (setq default-directory file) > (dired-mode)) > - (insert-file-contents-literally file) > + (if (string-match "\\.el\\'" file) > + (insert-file-contents file) > + (insert-file-contents-literally file)) > (when (string-match "\\.tar\\'" file) (tar-mode))) > (package-install-from-buffer))) is not something I can endorse, especially as it decodes much more than just the EOL format.