unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 48302@debbugs.gnu.org
Subject: bug#48302: [PATCH] Abbreviate `find' properties in M-x rgrep on MS Windows
Date: Sun, 09 May 2021 09:53:32 +0300	[thread overview]
Message-ID: <83r1ig8kk3.fsf@gnu.org> (raw)
In-Reply-To: <CANh=_JFATwvrvtHSD3uo1H=WoFOwai9HqKwhG2+2v29ofTbexg@mail.gmail.com> (message from Jim Porter on Sat, 8 May 2021 15:17:14 -0700)

> From: Jim Porter <jporterbugs@gmail.com>
> Date: Sat, 8 May 2021 15:17:14 -0700
> 
> MS Windows has different shell-quoting logic from POSIX shells, so the
> regexp to abbreviate the `find' command's properties in rgrep fails to
> match on MS Windows. The attached patch fixes this by looking for
> either `\)' (POSIX) or `")"' (MS Windows) as the end of the properties
> list.

Thanks, but could you also add a test for this issue to the test
suite?





  reply	other threads:[~2021-05-09  6:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-08 22:17 bug#48302: [PATCH] Abbreviate `find' properties in M-x rgrep on MS Windows Jim Porter
2021-05-09  6:53 ` Eli Zaretskii [this message]
2021-05-09 20:07   ` Jim Porter
2021-05-10  7:42     ` Michael Albinus
2021-05-11  4:36       ` bug#48302: [PATCH v2] " Jim Porter
2021-05-11  7:11         ` Michael Albinus
2021-05-11 12:22           ` Eli Zaretskii
2021-05-12  8:48             ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r1ig8kk3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=48302@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).