unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
@ 2021-01-23  5:07 Torsten Bronger
  2021-01-23 17:42 ` Eric Abrahamsen
  0 siblings, 1 reply; 25+ messages in thread
From: Torsten Bronger @ 2021-01-23  5:07 UTC (permalink / raw)
  To: 46047

[-- Attachment #1: Type: text/plain, Size: 7265 bytes --]


Since commit 7fad12c59b3c65665c10050e800d1d7ad5a2e056, I have
problems getting namazu-based mail searching working.  My
configuration says:

In .emacs:

(setq nnir-namazu-index-directory "/var/lib/namazu/")

In .gnus:

(setq gnus-secondary-select-methods '((nnml "" (nnir-search-engine namazu))))
;; I have not set gnus-search-use-parsed-queries.

This results in "Group nnselect:nnselect-87sg78bdzr.fsf contains no
messages" error when I hit "G G" in the group buffer and enter a query
string.  Besides, the namazu executable is not called at all.  The same
behavour I get if I don’t configure namazu at all in Emacs/Gnus.



In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, cairo version 1.16.0)
 of 2021-01-10 built on brad
Repository revision: 8ace7700b93c6c0835ddac6633a7ec07daf56225
Repository branch: HEAD
Windowing system distributor 'The X.Org Foundation', version 11.0.12009000
System Description: Ubuntu 20.04.1 LTS

Configured using:
 'configure --prefix=/usr/local/ --mandir=/usr/local/share/man/
 --infodir=/usr/local/share/info/ --with-x-toolkit=no --without-makeinfo
 --with-xpm --with-jpeg --with-tiff --with-gif --with-png --with-x
 --with-file-notification=inotify'

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF
ZLIB OLDXMENU X11 XDBE XIM MODULES THREADS LIBSYSTEMD PDUMPER LCMS2

Important settings:
  value of $EMACSLOADPATH: /home/bronger/.emacs.d/lisp:
  value of $LC_MONETARY: de_DE.UTF-8
  value of $LC_NUMERIC: de_DE.UTF-8
  value of $LC_TIME: de_DE.UTF-8
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: @im=fcitx
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  magit-auto-revert-mode: t
  global-git-commit-mode: t
  async-bytecomp-package-mode: t
  shell-dirtrack-mode: t
  global-auto-revert-mode: t
  TeX-PDF-mode: t
  savehist-mode: t
  display-time-mode: t
  desktop-save-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t

Load-path shadows:
/home/bronger/.emacs.d/elpa/auctex-12.3.1/tex-site hides /home/bronger/.emacs.d/lisp/tex-site

Features:
(shadow emacsbug sendmail misearch multi-isearch gnus-picon sort smiley
gnus-cite gnus-async gnus-bcklg gnus-ml disp-table gnutls pop3 nndraft
nnmh gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nnml
nnfolder gnus-cache bbdb-gnus bbdb-snarf mail-extr bbdb-com cl
network-stream nsm nntp gnus-topic css-mode sgml-mode eww xdg url-queue
mm-url color python tramp-sh tramp tramp-loaddefs trampver
tramp-integration files-x tramp-compat ls-lisp jade-mode js cc-mode
cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars
cc-defs stylus-mode sws-mode face-remap flyspell ispell reftex-dcr
reftex reftex-loaddefs reftex-vars font-latex latexenc tex-mode vc-git
dired-aux centered-cursor-mode etags-table magit-submodule
magit-obsolete magit-blame magit-stash magit-reflog magit-bisect
magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit
magit-sequence magit-notes magit-worktree magit-tag magit-merge
magit-branch magit-reset magit-files magit-refs magit-status magit
magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff
smerge-mode diff diff-mode magit-core magit-autorevert magit-margin
magit-transient magit-process magit-mode git-commit transient magit-git
magit-section magit-utils log-edit pcvs-util add-log with-editor
async-bytecomp async shell dash graphviz-dot-mode taskjuggler-mode
skeleton darkroom cql-mode sql view rust-mode swift-mode go-errcheck
go-mode find-file ffap etags fileloop xref project yaml-mode
dockerfile-mode rx sh-script smie executable dired-x adaptive-wrap
org-element avl-tree generator ol-eww ol-rmail ol-mhe ol-irc ol-info
ol-gnus nnselect gnus-search eieio-opt cl-extra help-mode speedbar
ezimage dframe gnus-art mm-uu mml2015 mm-view mml-smime smime dig
gnus-sum shr kinsoku svg dom gnus-group gnus-undo gnus-start gnus-dbus
gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time iso8601
gnus-spec gnus-int gnus-range message rmc puny rfc822 mml mml-sec epa
derived epg epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util rmail
rmail-loaddefs rfc2047 rfc2045 ietf-drums mail-utils mm-util mail-prsvr
wid-edit ol-docview doc-view jka-compr image-mode exif dired
dired-loaddefs ol-bibtex bibtex ol-bbdb ol-w3m org-agenda ob-python org
ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote
org-src ob-comint org-pcomplete pcomplete org-list org-faces
org-entities time-date noutline outline org-version ob-emacs-lisp
ob-core ob-eval org-table ol org-keys org-compat org-macs org-loaddefs
format-spec find-func server mmm-mode mmm-univ mmm-class mmm-region
mmm-auto mmm-vars mmm-utils mmm-compat rst browse-kill-ring
bbdb-autoloads bbdb timezone cal-china lunar solar cal-dst cal-bahai
cal-islam cal-hebrew holidays hol-loaddefs appt diary-lib diary-loaddefs
cal-menu calendar cal-loaddefs preview reporter tex-buf latex
latex-flymake flymake-proc flymake compile text-property-search comint
ansi-color ring warnings thingatpt tex-ispell tex-style autorevert
filenotify tex-fold easy-mmode tex dbus xml crm advice texmathp edmacro
kmacro savehist time desktop frameset delsel cus-start cus-load tex-site
info package easymenu browse-url url url-proxy url-privacy url-expand
url-methods url-history url-cookie url-domsuf url-util mailcap
url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win
x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo x
multi-tty make-network-process emacs)

Memory information:
((conses 16 530668 48100)
 (symbols 48 46881 1)
 (strings 32 161690 14204)
 (string-bytes 1 5424875)
 (vectors 16 72748)
 (vector-slots 8 825424 36893)
 (floats 8 971 59)
 (intervals 56 15658 1577)
 (buffers 984 50))

-- 
Torsten Bronger

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4913 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-01-23  5:07 bug#46047: 28.0.50; Namazu-based mail searching not working anymore Torsten Bronger
@ 2021-01-23 17:42 ` Eric Abrahamsen
  2021-01-23 20:17   ` Torsten Bronger
  0 siblings, 1 reply; 25+ messages in thread
From: Eric Abrahamsen @ 2021-01-23 17:42 UTC (permalink / raw)
  To: Torsten Bronger; +Cc: 46047

Torsten Bronger <bronger@physik.rwth-aachen.de> writes:

> Since commit 7fad12c59b3c65665c10050e800d1d7ad5a2e056, I have
> problems getting namazu-based mail searching working.  My
> configuration says:
>
> In .emacs:
>
> (setq nnir-namazu-index-directory "/var/lib/namazu/")
>
> In .gnus:
>
> (setq gnus-secondary-select-methods '((nnml "" (nnir-search-engine namazu))))
> ;; I have not set gnus-search-use-parsed-queries.
>
> This results in "Group nnselect:nnselect-87sg78bdzr.fsf contains no
> messages" error when I hit "G G" in the group buffer and enter a query
> string.  Besides, the namazu executable is not called at all.  The same
> behavour I get if I don’t configure namazu at all in Emacs/Gnus.

Thanks for the report. I haven't provided obsolete aliases for all of
the old nnir-<engine>-* variables, as that would be quite a pile, but if
that's annoying to enough people I can.

If you're not planning to revert to an earlier Emacs, it would be
easiest just to switch to setting `gnus-search-namazu-index-directory'.
If you are planning to revert, you could always set both. Alternately,
you could set the index directory within the server definition itself,
like so:

'((nnml "" (nnir-search-engine namazu
             (nnir-namazu-index-directory "/var/lib/namazu/"))))

I haven't yet added backwards compatibility code to honor that server
parameter, but I could do so fairly easily, then this config would be
past-and-future proof.

It's a little suspicious that the namazu program isn't getting called at
all, though. The code essentially just calls:

(start-process "name" <buffer> "namazu")

If "namazu" is on your path, it should be found.

Would you try setting the newer index-directory variable, just to
eliminate that as a source of error?

nnselect-run currently downgrades errors to messages (then reports no
messages found), so if there's really something blowing up, you might
see it in your *Messages* buffer.

Eric





^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-01-23 17:42 ` Eric Abrahamsen
@ 2021-01-23 20:17   ` Torsten Bronger
  2021-01-23 22:14     ` Eric Abrahamsen
  0 siblings, 1 reply; 25+ messages in thread
From: Torsten Bronger @ 2021-01-23 20:17 UTC (permalink / raw)
  To: 46047

[-- Attachment #1: Type: text/plain, Size: 1775 bytes --]

Hallöchen!

Eric Abrahamsen writes:

> [...]
>
> Thanks for the report. I haven't provided obsolete aliases for all of
> the old nnir-<engine>-* variables, as that would be quite a pile, but if
> that's annoying to enough people I can.

Thank you for your quick reaction.  FWIW, I don’t care about
reverting.  If I find a solution that only works with newest Emacs,
that’s fine.  However, this is only me.

> If you're not planning to revert to an earlier Emacs, it would be
> easiest just to switch to setting
> `gnus-search-namazu-index-directory'.  If you are planning to
> revert, you could always set both. Alternately, you could set the
> index directory within the server definition itself, like so:
>
> '((nnml "" (nnir-search-engine namazu
>              (nnir-namazu-index-directory "/var/lib/namazu/"))))

Franky, I don’t understand all this really.  I'm driving blindfolded
a bit.  Anyway, I put

(setq gnus-secondary-select-methods
      '((nnml "" (nnir-search-engine namazu
                                     (nnir-namazu-index-directory "/var/lib/namazu/")))))
(setq gnus-search-namazu-index-directory "/var/lib/namazu/")

in my .gnus.

> [...]
>
> nnselect-run currently downgrades errors to messages (then reports
> no messages found), so if there's really something blowing up, you
> might see it in your *Messages* buffer.

The *Messages* buffer says:

nnselect-run: gnus-search-run-query on ((search-query-spec (query . testquery) (raw)) (search-group-spec (nnml: nnml:KFA))) gave error (unbound-slot gnus-search-namazu #<gnus-search-namazu gnus-search-namazu-157f858a8568> index-directory oref)
Group nnselect:nnselect-87a6sztnu9.fsf contains no messages

Regards,
Torsten.

-- 
Torsten Bronger

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4913 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-01-23 20:17   ` Torsten Bronger
@ 2021-01-23 22:14     ` Eric Abrahamsen
  2021-01-23 22:26       ` Eric Abrahamsen
  2021-01-23 22:30       ` Eric Abrahamsen
  0 siblings, 2 replies; 25+ messages in thread
From: Eric Abrahamsen @ 2021-01-23 22:14 UTC (permalink / raw)
  To: 46047

Torsten Bronger <bronger@physik.rwth-aachen.de> writes:

> Hallöchen!
>
> Eric Abrahamsen writes:
>
>> [...]
>>
>> Thanks for the report. I haven't provided obsolete aliases for all of
>> the old nnir-<engine>-* variables, as that would be quite a pile, but if
>> that's annoying to enough people I can.
>
> Thank you for your quick reaction.  FWIW, I don’t care about
> reverting.  If I find a solution that only works with newest Emacs,
> that’s fine.  However, this is only me.
>
>> If you're not planning to revert to an earlier Emacs, it would be
>> easiest just to switch to setting
>> `gnus-search-namazu-index-directory'.  If you are planning to
>> revert, you could always set both. Alternately, you could set the
>> index directory within the server definition itself, like so:
>>
>> '((nnml "" (nnir-search-engine namazu
>>              (nnir-namazu-index-directory "/var/lib/namazu/"))))
>
> Franky, I don’t understand all this really.  I'm driving blindfolded
> a bit.  Anyway, I put
>
> (setq gnus-secondary-select-methods
>       '((nnml "" (nnir-search-engine namazu
>                                      (nnir-namazu-index-directory "/var/lib/namazu/")))))
> (setq gnus-search-namazu-index-directory "/var/lib/namazu/")
>
> in my .gnus.

Sorry if I wasn't clear -- I *can* provide backwards-compatible code to
handle the above, but I haven't yet. If you don't care about downgrading
Emacs, I would use the above, but take off the "nnir-namazu-" prefix, ie
just:

(index-directory "/var/lib/namazu/")

>> [...]
>>
>> nnselect-run currently downgrades errors to messages (then reports
>> no messages found), so if there's really something blowing up, you
>> might see it in your *Messages* buffer.
>
> The *Messages* buffer says:
>
> nnselect-run: gnus-search-run-query on ((search-query-spec (query .
> testquery) (raw)) (search-group-spec (nnml: nnml:KFA))) gave error
> (unbound-slot gnus-search-namazu #<gnus-search-namazu
> gnus-search-namazu-157f858a8568> index-directory oref)
> Group nnselect:nnselect-87a6sztnu9.fsf contains no messages

Perfect, this is the real bug, thank you. I'll get this fixed soon.






^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-01-23 22:14     ` Eric Abrahamsen
@ 2021-01-23 22:26       ` Eric Abrahamsen
  2021-01-25 10:10         ` Torsten Bronger
  2021-01-23 22:30       ` Eric Abrahamsen
  1 sibling, 1 reply; 25+ messages in thread
From: Eric Abrahamsen @ 2021-01-23 22:26 UTC (permalink / raw)
  To: 46047

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Torsten Bronger <bronger@physik.rwth-aachen.de> writes:
>
>> Hallöchen!
>>
>> Eric Abrahamsen writes:
>>
>>> [...]
>>>
>>> Thanks for the report. I haven't provided obsolete aliases for all of
>>> the old nnir-<engine>-* variables, as that would be quite a pile, but if
>>> that's annoying to enough people I can.
>>
>> Thank you for your quick reaction.  FWIW, I don’t care about
>> reverting.  If I find a solution that only works with newest Emacs,
>> that’s fine.  However, this is only me.
>>
>>> If you're not planning to revert to an earlier Emacs, it would be
>>> easiest just to switch to setting
>>> `gnus-search-namazu-index-directory'.  If you are planning to
>>> revert, you could always set both. Alternately, you could set the
>>> index directory within the server definition itself, like so:
>>>
>>> '((nnml "" (nnir-search-engine namazu
>>>              (nnir-namazu-index-directory "/var/lib/namazu/"))))
>>
>> Franky, I don’t understand all this really.  I'm driving blindfolded
>> a bit.  Anyway, I put
>>
>> (setq gnus-secondary-select-methods
>>       '((nnml "" (nnir-search-engine namazu
>>                                      (nnir-namazu-index-directory "/var/lib/namazu/")))))
>> (setq gnus-search-namazu-index-directory "/var/lib/namazu/")
>>
>> in my .gnus.
>
> Sorry if I wasn't clear -- I *can* provide backwards-compatible code to
> handle the above, but I haven't yet. If you don't care about downgrading
> Emacs, I would use the above, but take off the "nnir-namazu-" prefix, ie
> just:
>
> (index-directory "/var/lib/namazu/")
>
>>> [...]
>>>
>>> nnselect-run currently downgrades errors to messages (then reports
>>> no messages found), so if there's really something blowing up, you
>>> might see it in your *Messages* buffer.
>>
>> The *Messages* buffer says:
>>
>> nnselect-run: gnus-search-run-query on ((search-query-spec (query .
>> testquery) (raw)) (search-group-spec (nnml: nnml:KFA))) gave error
>> (unbound-slot gnus-search-namazu #<gnus-search-namazu
>> gnus-search-namazu-157f858a8568> index-directory oref)
>> Group nnselect:nnselect-87a6sztnu9.fsf contains no messages
>
> Perfect, this is the real bug, thank you. I'll get this fixed soon.

Okay, that ought to be fixed, but you'll still need to change your
config either to set `gnus-search-namazu-index-directory', or to set the
'index-directory' key in your server definition.

Please let me know if you can confirm the fix!

Thanks,
Eric





^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-01-23 22:14     ` Eric Abrahamsen
  2021-01-23 22:26       ` Eric Abrahamsen
@ 2021-01-23 22:30       ` Eric Abrahamsen
  1 sibling, 0 replies; 25+ messages in thread
From: Eric Abrahamsen @ 2021-01-23 22:30 UTC (permalink / raw)
  To: 46047

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Torsten Bronger <bronger@physik.rwth-aachen.de> writes:
>
>> Hallöchen!
>>
>> Eric Abrahamsen writes:
>>
>>> [...]
>>>
>>> Thanks for the report. I haven't provided obsolete aliases for all of
>>> the old nnir-<engine>-* variables, as that would be quite a pile, but if
>>> that's annoying to enough people I can.
>>
>> Thank you for your quick reaction.  FWIW, I don’t care about
>> reverting.  If I find a solution that only works with newest Emacs,
>> that’s fine.  However, this is only me.

Also, the Namazu search code was pretty hard to write, mostly because
everything is so poorly documented. Please file more bugs if anything
seems even slightly off.

Thanks!
Eric





^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-01-23 22:26       ` Eric Abrahamsen
@ 2021-01-25 10:10         ` Torsten Bronger
  2021-02-07 22:02           ` Eric Abrahamsen
  0 siblings, 1 reply; 25+ messages in thread
From: Torsten Bronger @ 2021-01-25 10:10 UTC (permalink / raw)
  To: 46047


[-- Attachment #1.1: Type: text/plain, Size: 1800 bytes --]

Hallöchen!

Eric Abrahamsen writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Torsten Bronger <bronger@physik.rwth-aachen.de> writes:
>>
>>> Hallöchen!
>>>
>>> [...]
>>>
>>> Franky, I don’t understand all this really.  I'm driving
>>> blindfolded a bit.  Anyway, I put
>>>
>>> (setq gnus-secondary-select-methods
>>>       '((nnml "" (nnir-search-engine namazu
>>>                                      (nnir-namazu-index-directory "/var/lib/namazu/")))))
>>> (setq gnus-search-namazu-index-directory "/var/lib/namazu/")
>>>
>>> in my .gnus.
>>
>> Sorry if I wasn't clear -- I *can* provide backwards-compatible
>> code to handle the above, but I haven't yet. If you don't care
>> about downgrading Emacs, I would use the above, but take off the
>> "nnir-namazu-" prefix, ie just:
>>
>> (index-directory "/var/lib/namazu/")

This has no effect on how Namazu is called on my machine.  Only
gnus-search-namazu-index-directory set the directory parameter of
the Namazu call correctly.

> [...]

I have now

(setq gnus-secondary-select-methods
      '((nnml "" (nnir-search-engine namazu))))
(setq gnus-search-namazu-index-directory "/var/lib/namazu/")

in my .gnus, and with current Git Emacs, Namazu is correctly called!
But it only works if no search results are found.  Otherwise,
*Messages* contains:

nnselect-run: gnus-search-run-query on ((search-query-spec (query . myquerystring) (raw)) (search-group-spec (nnml: nnml:Somegroup))) gave error (wrong-type-argument stringp nil)
Group nnselect:nnselect-877do1l461.fsf contains no messages

I have attached a shell script that you can use as a drop-in
replacement for namazu proper for easy generation of search results
that trigger this error for me.

Regards,
Torsten.



[-- Attachment #1.2: namazu --]
[-- Type: application/x-sh, Size: 495 bytes --]

[-- Attachment #1.3: Type: text/plain, Size: 24 bytes --]


-- 
Torsten Bronger

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4913 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-01-25 10:10         ` Torsten Bronger
@ 2021-02-07 22:02           ` Eric Abrahamsen
  2021-02-12 13:53             ` Torsten Bronger
  0 siblings, 1 reply; 25+ messages in thread
From: Eric Abrahamsen @ 2021-02-07 22:02 UTC (permalink / raw)
  To: 46047

Torsten Bronger <bronger@physik.rwth-aachen.de> writes:

> Hallöchen!
>
> Eric Abrahamsen writes:
>
>> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>>
>>> Torsten Bronger <bronger@physik.rwth-aachen.de> writes:
>>>
>>>> Hallöchen!
>>>>
>>>> [...]
>>>>
>>>> Franky, I don’t understand all this really.  I'm driving
>>>> blindfolded a bit.  Anyway, I put
>>>>
>>>> (setq gnus-secondary-select-methods
>>>>       '((nnml "" (nnir-search-engine namazu
>>>>                                      (nnir-namazu-index-directory "/var/lib/namazu/")))))
>>>> (setq gnus-search-namazu-index-directory "/var/lib/namazu/")
>>>>
>>>> in my .gnus.
>>>
>>> Sorry if I wasn't clear -- I *can* provide backwards-compatible
>>> code to handle the above, but I haven't yet. If you don't care
>>> about downgrading Emacs, I would use the above, but take off the
>>> "nnir-namazu-" prefix, ie just:
>>>
>>> (index-directory "/var/lib/namazu/")
>
> This has no effect on how Namazu is called on my machine.  Only
> gnus-search-namazu-index-directory set the directory parameter of
> the Namazu call correctly.
>
>> [...]
>
> I have now
>
> (setq gnus-secondary-select-methods
>       '((nnml "" (nnir-search-engine namazu))))
> (setq gnus-search-namazu-index-directory "/var/lib/namazu/")

Yes, the bare 'index-directory and 'remove-prefix configuration keys will only be
honored if you're using the 'gnus-search-engine config, not the
'nnir-search-engine config. I thought about picking up mixed config, but
it's just going to turn into too much of a mess. So your completely
correct, should-work-every-time config would look like:

(setq gnus-secondary-select-methods
      '((nnml "" (gnus-search-engine
		  gnus-search-namazu
		  remove-prefix "/home/bronger/Mail"
		  index-directory "/var/lib/namazu/"))))

> in my.gnus, and with current Git Emacs, Namazu is correctly called!
> But it only works if no search results are found.  Otherwise,
> *Messages* contains:
>
> nnselect-run: gnus-search-run-query on ((search-query-spec (query .
> myquerystring) (raw)) (search-group-spec (nnml: nnml:Somegroup))) gave
> error (wrong-type-argument stringp nil)
> Group nnselect:nnselect-877do1l461.fsf contains no messages
>
> I have attached a shell script that you can use as a drop-in
> replacement for namazu proper for easy generation of search results
> that trigger this error for me.

Thanks for providing this. There was a bug in the parsing of namazu
output that should now be fixed. Please let me know if you can confirm!

Thanks,
Eric





^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-02-07 22:02           ` Eric Abrahamsen
@ 2021-02-12 13:53             ` Torsten Bronger
  2021-02-12 15:25               ` Torsten Bronger
  0 siblings, 1 reply; 25+ messages in thread
From: Torsten Bronger @ 2021-02-12 13:53 UTC (permalink / raw)
  To: 46047

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]

Hallöchen!

Eric Abrahamsen writes:

> Torsten Bronger <bronger@physik.rwth-aachen.de> writes:
>
>> [...]
>>
>> I have now
>>
>> (setq gnus-secondary-select-methods
>>       '((nnml "" (nnir-search-engine namazu))))
>> (setq gnus-search-namazu-index-directory "/var/lib/namazu/")
>
> Yes, the bare 'index-directory and 'remove-prefix configuration
> keys will only be honored if you're using the 'gnus-search-engine
> config, not the 'nnir-search-engine config. I thought about
> picking up mixed config, but it's just going to turn into too much
> of a mess. So your completely correct, should-work-every-time
> config would look like:
>
> (setq gnus-secondary-select-methods
>       '((nnml "" (gnus-search-engine
> 		  gnus-search-namazu
> 		  remove-prefix "/home/bronger/Mail"
> 		  index-directory "/var/lib/namazu/"))))

But this does not call namazu for me.  The above 'nnir-search-engine
based config does, however.

Regards,
Torsten.

-- 
Torsten Bronger

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4913 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-02-12 13:53             ` Torsten Bronger
@ 2021-02-12 15:25               ` Torsten Bronger
  2021-04-21  3:19                 ` Stefan Kangas
  0 siblings, 1 reply; 25+ messages in thread
From: Torsten Bronger @ 2021-02-12 15:25 UTC (permalink / raw)
  To: 46047

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Hallöchen!

Torsten Bronger writes:

> [...]
>>
>> (setq gnus-secondary-select-methods
>>       '((nnml "" (gnus-search-engine
>> 		  gnus-search-namazu
>> 		  remove-prefix "/home/bronger/Mail"
>> 		  index-directory "/var/lib/namazu/"))))
>
> But this does not call namazu for me.  The above 'nnir-search-engine
> based config does, however.

I withdraw this statement for the time being.  I seem to have other
issues with my configuration that I first have to sort out.

Regards,
Torsten.

-- 
Torsten Bronger

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4913 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-02-12 15:25               ` Torsten Bronger
@ 2021-04-21  3:19                 ` Stefan Kangas
  2021-05-09 14:21                   ` Torsten Bronger
  0 siblings, 1 reply; 25+ messages in thread
From: Stefan Kangas @ 2021-04-21  3:19 UTC (permalink / raw)
  To: Torsten Bronger; +Cc: Eric Abrahamsen, 46047

Torsten Bronger <bronger@physik.rwth-aachen.de> writes:

> Hallöchen!
>
> Torsten Bronger writes:
>
>> [...]
>>>
>>> (setq gnus-secondary-select-methods
>>>       '((nnml "" (gnus-search-engine
>>> 		  gnus-search-namazu
>>> 		  remove-prefix "/home/bronger/Mail"
>>> 		  index-directory "/var/lib/namazu/"))))
>>
>> But this does not call namazu for me.  The above 'nnir-search-engine
>> based config does, however.
>
> I withdraw this statement for the time being.  I seem to have other
> issues with my configuration that I first have to sort out.

It seems like Eric Abrahamsen fixed a bug here.  Is there anything more
to do here, or should this be closed?





^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-04-21  3:19                 ` Stefan Kangas
@ 2021-05-09 14:21                   ` Torsten Bronger
  2021-05-12 18:18                     ` Eric Abrahamsen
  2021-05-16 17:24                     ` Eric Abrahamsen
  0 siblings, 2 replies; 25+ messages in thread
From: Torsten Bronger @ 2021-05-09 14:21 UTC (permalink / raw)
  To: 46047

[-- Attachment #1: Type: text/plain, Size: 1344 bytes --]

Hallöchen!

Stefan Kangas writes:

> [...]
>
> It seems like Eric Abrahamsen fixed a bug here.  Is there anything
> more to do here, or should this be closed?

I still get the "Group nnselect:nnselect-87zgx43sbz.fsf contains no
messages" error if I hit "G G" in the group buffer – while the
cursor is on one of my nnml groups – and enter some random query.

The binary "namazu" is replaced with the shell script I mentioned
earlier.  For your convenience, here is its content again:

    #!/bin/sh

    cat <<EOF
    1. =?utf-8?q?LABORLEITER_F=C3=9CR_DIE_QUALIT=C3=84TSSICHERUNG_=28M/W=29_-_Michael_Page?= (score: 37)
    /home/bronger/Mail/Jobs/11147 (76,989 bytes)




    2. =?utf-8?q?LABORLEITER_F=C3=9CR_DIE_QUALIT=C3=84TSSICHERUNG_=28M/W=29_-_Michael_Page?= (score: 37)
    /home/bronger/Mail/Jobs/11140 (76,991 bytes)




    3. =?utf-8?q?Trainee_-_Projektleitung_Brandenburg_=28m/w=29_/_00664_-_ThyssenKrupp_Steel_Europe_A=E2=80=A6?= (score: 36)
    /home/bronger/Mail/Jobs/12450 (74,161 bytes)




    EOF

I am sure that this script is actually called by Gnus, however, Gnus
does not seem to digest the output properly.  Emacs’ debug output is
too little to say more.  If you have advice for me about how to
proceed, I am happy to do so.

Regards,
Torsten.

-- 
Torsten Bronger

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4913 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-05-09 14:21                   ` Torsten Bronger
@ 2021-05-12 18:18                     ` Eric Abrahamsen
  2021-05-16 17:24                     ` Eric Abrahamsen
  1 sibling, 0 replies; 25+ messages in thread
From: Eric Abrahamsen @ 2021-05-12 18:18 UTC (permalink / raw)
  To: 46047

Torsten Bronger <bronger@physik.rwth-aachen.de> writes:

> Hallöchen!
>
> Stefan Kangas writes:
>
>> [...]
>>
>> It seems like Eric Abrahamsen fixed a bug here.  Is there anything
>> more to do here, or should this be closed?
>
> I still get the "Group nnselect:nnselect-87zgx43sbz.fsf contains no
> messages" error if I hit "G G" in the group buffer – while the
> cursor is on one of my nnml groups – and enter some random query.

Sorry this is still happening -- I'll have time this weekend to check it out.





^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-05-09 14:21                   ` Torsten Bronger
  2021-05-12 18:18                     ` Eric Abrahamsen
@ 2021-05-16 17:24                     ` Eric Abrahamsen
  2021-05-16 19:43                       ` Torsten Bronger
  1 sibling, 1 reply; 25+ messages in thread
From: Eric Abrahamsen @ 2021-05-16 17:24 UTC (permalink / raw)
  To: 46047

Torsten Bronger <bronger@physik.rwth-aachen.de> writes:

> Hallöchen!
>
> Stefan Kangas writes:
>
>> [...]
>>
>> It seems like Eric Abrahamsen fixed a bug here.  Is there anything
>> more to do here, or should this be closed?
>
> I still get the "Group nnselect:nnselect-87zgx43sbz.fsf contains no
> messages" error if I hit "G G" in the group buffer – while the
> cursor is on one of my nnml groups – and enter some random query.
>
> The binary "namazu" is replaced with the shell script I mentioned
> earlier.  For your convenience, here is its content again:

This is still working fine for me, using the sample config I provided
earlier. Can you show me your exact configuration for this server? And
the "nnselect-run" error message from *Messages*, which should be formed
as "nnselect-run: %s on %s gave error %s"? I'm also about to push a
change which will let you toggle debug on error and get a backtrace, as
usual.

Thanks,
Eric





^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-05-16 17:24                     ` Eric Abrahamsen
@ 2021-05-16 19:43                       ` Torsten Bronger
  2021-05-16 22:11                         ` Eric Abrahamsen
  0 siblings, 1 reply; 25+ messages in thread
From: Torsten Bronger @ 2021-05-16 19:43 UTC (permalink / raw)
  To: 46047

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

Hallöchen!

Eric Abrahamsen writes:

> [...]  Can you show me your exact configuration for this server?

The relevant part is, I think:

(setq gnus-secondary-select-methods
      '((nnml "" (gnus-search-engine
		  gnus-search-namazu
		  remove-prefix "/home/bronger/Mail"
		  index-directory "/var/lib/namazu/"))))

I’m happy to post the rest of my .gnus and .emacs somewhere if
helpful.

> And the "nnselect-run" error message from *Messages*, which should
> be formed as "nnselect-run: %s on %s gave error %s"?

In *Messages*, it says:

nnselect-run: gnus-search-run-query on ((search-query-spec (query . +from:aixasset@web.de) (raw)) (search-group-spec (nnml: nnml:KFA-FBL))) gave error (wrong-type-argument stringp nil)

Regards,
Torsten.

-- 
Torsten Bronger

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4913 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-05-16 19:43                       ` Torsten Bronger
@ 2021-05-16 22:11                         ` Eric Abrahamsen
  2021-05-17  6:02                           ` Torsten Bronger
  0 siblings, 1 reply; 25+ messages in thread
From: Eric Abrahamsen @ 2021-05-16 22:11 UTC (permalink / raw)
  To: 46047

Torsten Bronger <bronger@physik.rwth-aachen.de> writes:

> Hallöchen!
>
> Eric Abrahamsen writes:
>
>> [...]  Can you show me your exact configuration for this server?
>
> The relevant part is, I think:
>
> (setq gnus-secondary-select-methods
>       '((nnml "" (gnus-search-engine
> 		  gnus-search-namazu
> 		  remove-prefix "/home/bronger/Mail"
> 		  index-directory "/var/lib/namazu/"))))
>
> I’m happy to post the rest of my .gnus and .emacs somewhere if
> helpful.

I'm assuming you've also got `gnus-search-namazu-raw-queries-p' set to
t, otherwise you would have hit an error earlier than this.

>> And the "nnselect-run" error message from *Messages*, which should
>> be formed as "nnselect-run: %s on %s gave error %s"?
>
> In *Messages*, it says:
>
> nnselect-run: gnus-search-run-query on ((search-query-spec (query .
> +from:aixasset@web.de) (raw)) (search-group-spec (nnml:
> nnml:KFA-FBL))) gave error (wrong-type-argument stringp nil)

Bah, this is difficult to debug -- it's hard to guess what string is
nil.

Earlier in the day I pushed a change to Emacs master to use
`condition-case-unless-debug' in `nnselect-run'. If you're in the habit
of running a recent Emacs, would you pull from source and rebuild, then
`toggle-debug-on-error' and run this search again, posting the
backtrace?

If you're not, you could just eval the following, then do the same
(toggle-debug-on-error, etc)

(defun nnselect-run (specs)
  "Apply nnselect-function to nnselect-args from SPECS.
Return an article list."
  (let ((func (alist-get 'nnselect-function specs))
	(args (alist-get 'nnselect-args specs)))
    (condition-case-unless-debug err
	(funcall func args)
      (error (gnus-error 3 "nnselect-run: %s on %s gave error %s" func args err)
	     []))))

Thanks for your help, and patience.

Eric





^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-05-16 22:11                         ` Eric Abrahamsen
@ 2021-05-17  6:02                           ` Torsten Bronger
  2021-05-17 18:53                             ` Eric Abrahamsen
  0 siblings, 1 reply; 25+ messages in thread
From: Torsten Bronger @ 2021-05-17  6:02 UTC (permalink / raw)
  To: 46047

[-- Attachment #1: Type: text/plain, Size: 5340 bytes --]

Hallöchen!

Eric Abrahamsen writes:

> [...]
>
> I'm assuming you've also got `gnus-search-namazu-raw-queries-p'
> set to t, otherwise you would have hit an error earlier than this.

No, but I did now.

> [...]
>
> Earlier in the day I pushed a change to Emacs master to use
> `condition-case-unless-debug' in `nnselect-run'. If you're in the
> habit of running a recent Emacs, would you pull from source and
> rebuild, then `toggle-debug-on-error' and run this search again,
> posting the backtrace?

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  file-readable-p(nil)
  #f(compiled-function (engine server query &optional groups) #<bytecode -0x1512e15628ab6a16>)(#<gnus-search-namazu gnus-search-namazu-156189856662> "nnml:" ((query . "+from:adshhg@web.de") (raw)) ("nnml:KFA-FBL"))
  apply(#f(compiled-function (engine server query &optional groups) #<bytecode -0x1512e15628ab6a16>) #<gnus-search-namazu gnus-search-namazu-156189856662> ("nnml:" ((query . "+from:adshhg@web.de") (raw)) ("nnml:KFA-FBL")))
  gnus-search-indexed-parse-output(#<gnus-search-namazu gnus-search-namazu-156189856662> "nnml:" ((query . "+from:adshhg@web.de") (raw)) ("nnml:KFA-FBL"))
  #f(compiled-function (engine server query groups) "Run QUERY against SERVER using ENGINE.\nThis method is common to all indexed search engines.\n\nReturns a list of [group article score] vectors." #<bytecode -0x14990fb58c523306>)(#<gnus-search-namazu gnus-search-namazu-156189856662> "nnml:" ((query . "+from:adshhg@web.de") (raw)) ("nnml:KFA-FBL"))
  apply(#f(compiled-function (engine server query groups) "Run QUERY against SERVER using ENGINE.\nThis method is common to all indexed search engines.\n\nReturns a list of [group article score] vectors." #<bytecode -0x14990fb58c523306>) (#<gnus-search-namazu gnus-search-namazu-156189856662> "nnml:" ((query . "+from:adshhg@web.de") (raw)) ("nnml:KFA-FBL")))
  #f(compiled-function (&rest cnm-args) #<bytecode 0xf8e552620c26b56>)()
  #f(compiled-function (cl--cnm e server query groups) #<bytecode -0xee958af24c64d80>)(#f(compiled-function (&rest cnm-args) #<bytecode 0xf8e552620c26b56>) #<gnus-search-namazu gnus-search-namazu-156189856662> "nnml:" ((query . "+from:adshhg@web.de") (raw)) ("nnml:KFA-FBL"))
  apply(#f(compiled-function (cl--cnm e server query groups) #<bytecode -0xee958af24c64d80>) #f(compiled-function (&rest cnm-args) #<bytecode 0xf8e552620c26b56>) (#<gnus-search-namazu gnus-search-namazu-156189856662> "nnml:" ((query . "+from:adshhg@web.de") (raw)) ("nnml:KFA-FBL")))
  #f(compiled-function (&rest args) #<bytecode 0xda2e1934f892579>)(#<gnus-search-namazu gnus-search-namazu-156189856662> "nnml:" ((query . "+from:adshhg@web.de") (raw)) ("nnml:KFA-FBL"))
  apply(#f(compiled-function (&rest args) #<bytecode 0xda2e1934f892579>) #<gnus-search-namazu gnus-search-namazu-156189856662> ("nnml:" ((query . "+from:adshhg@web.de") (raw)) ("nnml:KFA-FBL")))
  gnus-search-run-search(#<gnus-search-namazu gnus-search-namazu-156189856662> "nnml:" ((query . "+from:adshhg@web.de") (raw)) ("nnml:KFA-FBL"))
  #f(compiled-function (arg0) #<bytecode -0x9685499bb4f6a22>)(("nnml:" "nnml:KFA-FBL"))
  mapc(#f(compiled-function (arg0) #<bytecode -0x9685499bb4f6a22>) (("nnml:" "nnml:KFA-FBL")))
  gnus-search-run-query(((search-query-spec (query . "+from:adshhg@web.de") (raw)) (search-group-spec ("nnml:" "nnml:KFA-FBL"))))
  nnselect-run(((nnselect-function . gnus-search-run-query) (nnselect-args (search-query-spec (query . "+from:adshhg@web.de") (raw)) (search-group-spec ("nnml:" "nnml:KFA-FBL")))))
  nnselect-request-group("nnselect-87tun1dhn9.fsf" "nnselect-ephemeral" t ("nnselect:nnselect-87tun1dhn9.fsf" 3 nil nil (nnselect "nnselect-ephemeral" (nnselect-address "nnselect")) ((quit-config #<buffer *Group*> . group) (nnselect-specs (nnselect-function . gnus-search-run-query) (nnselect-args (search-query-spec (query . "+from:adshhg@web.de") (raw)) (search-group-spec ("nnml:" "nnml:KFA-FBL")))) (nnselect-artlist))))
  gnus-request-group("nnselect:nnselect-87tun1dhn9.fsf" t nil ("nnselect:nnselect-87tun1dhn9.fsf" 3 nil nil (nnselect "nnselect-ephemeral" (nnselect-address "nnselect")) ((quit-config #<buffer *Group*> . group) (nnselect-specs (nnselect-function . gnus-search-run-query) (nnselect-args (search-query-spec (query . "+from:adshhg@web.de") (raw)) (search-group-spec ("nnml:" "nnml:KFA-FBL")))) (nnselect-artlist))))
  gnus-select-newsgroup("nnselect:nnselect-87tun1dhn9.fsf" t nil)
  gnus-summary-read-group-1("nnselect:nnselect-87tun1dhn9.fsf" t t nil nil nil)
  gnus-summary-read-group("nnselect:nnselect-87tun1dhn9.fsf" t t nil nil nil nil)
  gnus-group-read-group(t t "nnselect:nnselect-87tun1dhn9.fsf" nil)
  gnus-group-read-ephemeral-group("nnselect-87tun1dhn9.fsf" (nnselect "nnselect") nil (#<buffer *Group*> . group) nil nil ((nnselect-specs (nnselect-function . gnus-search-run-query) (nnselect-args (search-query-spec (query . "+from:adshhg@web.de") (raw)) (search-group-spec ("nnml:" "nnml:KFA-FBL")))) (nnselect-artlist)))
  gnus-group-read-ephemeral-search-group(nil)
  funcall-interactively(gnus-group-read-ephemeral-search-group nil)
  call-interactively(gnus-group-read-ephemeral-search-group nil nil)
  command-execute(gnus-group-read-ephemeral-search-group)

Regards,
Torsten.

-- 
Torsten Bronger

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4913 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-05-17  6:02                           ` Torsten Bronger
@ 2021-05-17 18:53                             ` Eric Abrahamsen
  2021-05-18  8:46                               ` Torsten Bronger
  0 siblings, 1 reply; 25+ messages in thread
From: Eric Abrahamsen @ 2021-05-17 18:53 UTC (permalink / raw)
  To: 46047

Torsten Bronger <bronger@physik.rwth-aachen.de> writes:

> Hallöchen!
>
> Eric Abrahamsen writes:
>
>> [...]
>>
>> I'm assuming you've also got `gnus-search-namazu-raw-queries-p'
>> set to t, otherwise you would have hit an error earlier than this.
>
> No, but I did now.

Oh, maybe you just had `gnus-search-use-parsed-queries' set to nil. One
way or another, the query must not be getting parsed. But that's fine!

>> [...]
>>
>> Earlier in the day I pushed a change to Emacs master to use
>> `condition-case-unless-debug' in `nnselect-run'. If you're in the
>> habit of running a recent Emacs, would you pull from source and
>> rebuild, then `toggle-debug-on-error' and run this search again,
>> posting the backtrace?
>
> Debugger entered--Lisp error: (wrong-type-argument stringp nil)
>   file-readable-p(nil)

This just means that when namazu returns its search results, this
function fails to find a filename. In other words, the (match-string 4)
returns nil.

(cl-defmethod gnus-search-indexed-extract ((_engine gnus-search-namazu))
  "Extract a single message result for Namazu.
Namazu provides a little more information, for instance a score."

  (when (re-search-forward
	 "^\\([0-9,]+\\.\\).*\\((score: \\([0-9]+\\)\\))\n\\([^ ]+\\)"
	 nil t)
    (forward-line 1)
    (list (match-string 4)
	  (match-string 3))))

Using the example results that you send me (the bash script) the file
names are found correctly. Is there a way you can find and show me the
filename that isn't being found by this regexp? I assume it's a filename
that doesn't start with a digit. I'm not sure where this regexp came
from, originally.





^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-05-17 18:53                             ` Eric Abrahamsen
@ 2021-05-18  8:46                               ` Torsten Bronger
  2021-05-18  9:08                                 ` Eli Zaretskii
  0 siblings, 1 reply; 25+ messages in thread
From: Torsten Bronger @ 2021-05-18  8:46 UTC (permalink / raw)
  To: 46047

[-- Attachment #1: Type: text/plain, Size: 971 bytes --]

Hallöchen!

Eric Abrahamsen writes:

> [...]
>
>>> [...]
>>>
>>> Earlier in the day I pushed a change to Emacs master to use
>>> `condition-case-unless-debug' in `nnselect-run'. If you're in the
>>> habit of running a recent Emacs, would you pull from source and
>>> rebuild, then `toggle-debug-on-error' and run this search again,
>>> posting the backtrace?
>>
>> Debugger entered--Lisp error: (wrong-type-argument stringp nil)
>>   file-readable-p(nil)
>
> This just means that when namazu returns its search results, this
> function fails to find a filename. In other words, the (match-string 4)
> returns nil.

I made some progress with this.  The buffer containing namazu’s
output contains trailing garbage on my system.  The tailing string
is: "Process search-nnml: finished".  This cannot be matched, of
course, which makes everything fail.

I don’t know where this comes from, though.

Regards,
Torsten.

-- 
Torsten Bronger

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4913 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-05-18  8:46                               ` Torsten Bronger
@ 2021-05-18  9:08                                 ` Eli Zaretskii
  2021-05-18 16:50                                   ` Eric Abrahamsen
  0 siblings, 1 reply; 25+ messages in thread
From: Eli Zaretskii @ 2021-05-18  9:08 UTC (permalink / raw)
  To: 46047, bronger

On May 18, 2021 11:46:52 AM GMT+03:00, Torsten Bronger <bronger@physik.rwth-aachen.de> wrote:
> Hallöchen!
> 
> Eric Abrahamsen writes:
> 
> > [...]
> >
> >>> [...]
> >>>
> >>> Earlier in the day I pushed a change to Emacs master to use
> >>> `condition-case-unless-debug' in `nnselect-run'. If you're in the
> >>> habit of running a recent Emacs, would you pull from source and
> >>> rebuild, then `toggle-debug-on-error' and run this search again,
> >>> posting the backtrace?
> >>
> >> Debugger entered--Lisp error: (wrong-type-argument stringp nil)
> >>   file-readable-p(nil)
> >
> > This just means that when namazu returns its search results, this
> > function fails to find a filename. In other words, the (match-string
> 4)
> > returns nil.
> 
> I made some progress with this.  The buffer containing namazu’s
> output contains trailing garbage on my system.  The tailing string
> is: "Process search-nnml: finished".  This cannot be matched, of
> course, which makes everything fail.
> 
> I don’t know where this comes from, though.
> 
> Regards,
> Torsten.

I think it's process exit status notification and comes from the process sentinel function.





^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-05-18  9:08                                 ` Eli Zaretskii
@ 2021-05-18 16:50                                   ` Eric Abrahamsen
  2021-05-18 16:55                                     ` Eli Zaretskii
  0 siblings, 1 reply; 25+ messages in thread
From: Eric Abrahamsen @ 2021-05-18 16:50 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 46047, bronger

Eli Zaretskii <eliz@gnu.org> writes:

> On May 18, 2021 11:46:52 AM GMT+03:00, Torsten Bronger
> <bronger@physik.rwth-aachen.de> wrote:
>> Hallöchen!
>> 
>> Eric Abrahamsen writes:
>> 
>> > [...]
>> >
>> >>> [...]
>> >>>
>> >>> Earlier in the day I pushed a change to Emacs master to use
>> >>> `condition-case-unless-debug' in `nnselect-run'. If you're in the
>> >>> habit of running a recent Emacs, would you pull from source and
>> >>> rebuild, then `toggle-debug-on-error' and run this search again,
>> >>> posting the backtrace?
>> >>
>> >> Debugger entered--Lisp error: (wrong-type-argument stringp nil)
>> >>   file-readable-p(nil)
>> >
>> > This just means that when namazu returns its search results, this
>> > function fails to find a filename. In other words, the (match-string
>> 4)
>> > returns nil.
>> 
>> I made some progress with this.  The buffer containing namazu’s
>> output contains trailing garbage on my system.  The tailing string
>> is: "Process search-nnml: finished".  This cannot be matched, of
>> course, which makes everything fail.
>> 
>> I don’t know where this comes from, though.
>> 
>> Regards,
>> Torsten.
>
> I think it's process exit status notification and comes from the
> process sentinel function.

Huh, I'm surprised this hasn't been an issue before, then. It looks like
that message is standard for any start-process/accept-process-output
situation. Is there any way to shut it off?

Regardless, the output parsing shouldn't be so fragile that it chokes on
this. I'll look into making it more robust.

Thanks,
Eric





^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-05-18 16:50                                   ` Eric Abrahamsen
@ 2021-05-18 16:55                                     ` Eli Zaretskii
  2021-05-21 17:47                                       ` Eric Abrahamsen
  0 siblings, 1 reply; 25+ messages in thread
From: Eli Zaretskii @ 2021-05-18 16:55 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: 46047, bronger

> From: Eric Abrahamsen <eric@ericabrahamsen.net>
> Cc: 46047@debbugs.gnu.org,  bronger@physik.rwth-aachen.de
> Date: Tue, 18 May 2021 09:50:00 -0700
> 
> > I think it's process exit status notification and comes from the
> > process sentinel function.
> 
> Huh, I'm surprised this hasn't been an issue before, then. It looks like
> that message is standard for any start-process/accept-process-output
> situation. Is there any way to shut it off?

The only way I know of is to provide your own sentinel function.

> Regardless, the output parsing shouldn't be so fragile that it chokes on
> this. I'll look into making it more robust.

Agreed, and thanks in advance.





^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-05-18 16:55                                     ` Eli Zaretskii
@ 2021-05-21 17:47                                       ` Eric Abrahamsen
  2021-05-21 19:10                                         ` Torsten Bronger
  0 siblings, 1 reply; 25+ messages in thread
From: Eric Abrahamsen @ 2021-05-21 17:47 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 46047, bronger

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Eric Abrahamsen <eric@ericabrahamsen.net>
>> Cc: 46047@debbugs.gnu.org,  bronger@physik.rwth-aachen.de
>> Date: Tue, 18 May 2021 09:50:00 -0700
>> 
>> > I think it's process exit status notification and comes from the
>> > process sentinel function.
>> 
>> Huh, I'm surprised this hasn't been an issue before, then. It looks like
>> that message is standard for any start-process/accept-process-output
>> situation. Is there any way to shut it off?
>
> The only way I know of is to provide your own sentinel function.
>
>> Regardless, the output parsing shouldn't be so fragile that it chokes on
>> this. I'll look into making it more robust.
>
> Agreed, and thanks in advance.

Torsten, if you have a moment, would you try the attached diff and
confirm that it fixes the problem you're seeing?

Thanks,
Eric



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: searchparsing.diff --]
[-- Type: text/x-patch, Size: 740 bytes --]

diff --git a/lisp/gnus/gnus-search.el b/lisp/gnus/gnus-search.el
index a59d0e57a7..fc9f8684f6 100644
--- a/lisp/gnus/gnus-search.el
+++ b/lisp/gnus/gnus-search.el
@@ -1358,9 +1358,12 @@ gnus-search-indexed-parse-output
 			 "\\|")))
 	artlist vectors article group)
     (goto-char (point-min))
-    (while (not (eobp))
+    (while (not (or (eobp)
+                    (looking-at-p
+                     "\\(?:[[:space:]\n]+\\)?Process .+ finished")))
       (pcase-let ((`(,f-name ,score) (gnus-search-indexed-extract engine)))
-	(when (and (file-readable-p f-name)
+	(when (and f-name
+                   (file-readable-p f-name)
 		   (null (file-directory-p f-name))
 		   (or (null groups)
 		       (and (gnus-search-single-p query)

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-05-21 17:47                                       ` Eric Abrahamsen
@ 2021-05-21 19:10                                         ` Torsten Bronger
  2021-05-21 20:38                                           ` Eric Abrahamsen
  0 siblings, 1 reply; 25+ messages in thread
From: Torsten Bronger @ 2021-05-21 19:10 UTC (permalink / raw)
  To: 46047

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

Hallöchen!

Eric Abrahamsen writes:

> [...]
>
> Torsten, if you have a moment, would you try the attached diff and
> confirm that it fixes the problem you're seeing?

Yes, with the patch it works.  Thank you!

Regards,
Torsten.

-- 
Torsten Bronger

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4913 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* bug#46047: 28.0.50; Namazu-based mail searching not working anymore
  2021-05-21 19:10                                         ` Torsten Bronger
@ 2021-05-21 20:38                                           ` Eric Abrahamsen
  0 siblings, 0 replies; 25+ messages in thread
From: Eric Abrahamsen @ 2021-05-21 20:38 UTC (permalink / raw)
  To: 46047-done

Torsten Bronger <bronger@physik.rwth-aachen.de> writes:

> --=-=-=
> Content-Type: text/plain; charset=iso-8859-1
> Content-Transfer-Encoding: quoted-printable
>
> Hall=F6chen!
>
> Eric Abrahamsen writes:
>
>> [...]
>>
>> Torsten, if you have a moment, would you try the attached diff and
>> confirm that it fixes the problem you're seeing?
>
> Yes, with the patch it works.  Thank you!

Great news! Thanks for the very quick test. Closing this now.

Eric





^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2021-05-21 20:38 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-23  5:07 bug#46047: 28.0.50; Namazu-based mail searching not working anymore Torsten Bronger
2021-01-23 17:42 ` Eric Abrahamsen
2021-01-23 20:17   ` Torsten Bronger
2021-01-23 22:14     ` Eric Abrahamsen
2021-01-23 22:26       ` Eric Abrahamsen
2021-01-25 10:10         ` Torsten Bronger
2021-02-07 22:02           ` Eric Abrahamsen
2021-02-12 13:53             ` Torsten Bronger
2021-02-12 15:25               ` Torsten Bronger
2021-04-21  3:19                 ` Stefan Kangas
2021-05-09 14:21                   ` Torsten Bronger
2021-05-12 18:18                     ` Eric Abrahamsen
2021-05-16 17:24                     ` Eric Abrahamsen
2021-05-16 19:43                       ` Torsten Bronger
2021-05-16 22:11                         ` Eric Abrahamsen
2021-05-17  6:02                           ` Torsten Bronger
2021-05-17 18:53                             ` Eric Abrahamsen
2021-05-18  8:46                               ` Torsten Bronger
2021-05-18  9:08                                 ` Eli Zaretskii
2021-05-18 16:50                                   ` Eric Abrahamsen
2021-05-18 16:55                                     ` Eli Zaretskii
2021-05-21 17:47                                       ` Eric Abrahamsen
2021-05-21 19:10                                         ` Torsten Bronger
2021-05-21 20:38                                           ` Eric Abrahamsen
2021-01-23 22:30       ` Eric Abrahamsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).