From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48669: Inconsistent overlay placement between minibuffer-message and set-minibuffer-message Date: Sun, 06 Jun 2021 08:58:27 +0300 Message-ID: <83r1hfilfg.fsf@gnu.org> References: <87k0n8kl1h.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22963"; mail-complaints-to="usenet@ciao.gmane.io" Cc: joca.bt@gmail.com, 48669@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 06 07:59:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lploW-0005jY-Pg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Jun 2021 07:59:12 +0200 Original-Received: from localhost ([::1]:58044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lploV-0007vs-3A for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Jun 2021 01:59:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lploN-0007vg-02 for bug-gnu-emacs@gnu.org; Sun, 06 Jun 2021 01:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lploM-0007j8-A7 for bug-gnu-emacs@gnu.org; Sun, 06 Jun 2021 01:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lploM-0006zT-7m for bug-gnu-emacs@gnu.org; Sun, 06 Jun 2021 01:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Jun 2021 05:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48669 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48669-submit@debbugs.gnu.org id=B48669.162295911926842 (code B ref 48669); Sun, 06 Jun 2021 05:59:02 +0000 Original-Received: (at 48669) by debbugs.gnu.org; 6 Jun 2021 05:58:39 +0000 Original-Received: from localhost ([127.0.0.1]:50486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lplnz-0006ys-9l for submit@debbugs.gnu.org; Sun, 06 Jun 2021 01:58:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lplnx-0006ye-A7 for 48669@debbugs.gnu.org; Sun, 06 Jun 2021 01:58:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43198) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lplnq-0007C2-Sx; Sun, 06 Jun 2021 01:58:30 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4159 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lplnp-0002e0-DZ; Sun, 06 Jun 2021 01:58:30 -0400 In-Reply-To: <87k0n8kl1h.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 06 Jun 2021 00:43:54 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208086 Archived-At: > From: Juri Linkov > Date: Sun, 06 Jun 2021 00:43:54 +0300 > Cc: 48669@debbugs.gnu.org > > > [1:text/plain Hide] > > > Would it make sense to change this behaviour (i.e. overlay > > configuration) so that it is consistent in both functions? > > Thanks for the very useful suggestion. This could be fixed > with the following patch where I tried to sync everything > overlay-related from set-minibuffer-message to minibuffer-message: > > > [2:text/x-diff Hide] > > diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el > index ffb74235e8..cb12226c07 100644 > --- a/lisp/minibuffer.el > +++ b/lisp/minibuffer.el > @@ -741,7 +741,8 @@ minibuffer-message > ;; Don't overwrite the face properties the caller has set > (text-properties-at 0 message)) > (setq message (apply #'propertize message minibuffer-message-properties))) > - (let ((ol (make-overlay (point-max) (point-max) nil t t)) > + (let* ((ovpos (minibuffer--message-overlay-pos)) > + (ol (make-overlay ovpos ovpos nil t t)) Doesn't this rely too much on the internal details of minibuffer--message-overlay-pos? At least, without any comments, this call looks like a riddle that isn't easy to unlock. > - (put-text-property 0 1 'cursor t message)) > + (put-text-property 0 1 'cursor 1 message)) Why this change?