From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: joca.bt@gmail.com, 48669@debbugs.gnu.org
Subject: bug#48669: Inconsistent overlay placement between minibuffer-message and set-minibuffer-message
Date: Sun, 06 Jun 2021 08:58:27 +0300 [thread overview]
Message-ID: <83r1hfilfg.fsf@gnu.org> (raw)
In-Reply-To: <87k0n8kl1h.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 06 Jun 2021 00:43:54 +0300)
> From: Juri Linkov <juri@linkov.net>
> Date: Sun, 06 Jun 2021 00:43:54 +0300
> Cc: 48669@debbugs.gnu.org
>
>
> [1:text/plain Hide]
>
> > Would it make sense to change this behaviour (i.e. overlay
> > configuration) so that it is consistent in both functions?
>
> Thanks for the very useful suggestion. This could be fixed
> with the following patch where I tried to sync everything
> overlay-related from set-minibuffer-message to minibuffer-message:
>
>
> [2:text/x-diff Hide]
>
> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
> index ffb74235e8..cb12226c07 100644
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -741,7 +741,8 @@ minibuffer-message
> ;; Don't overwrite the face properties the caller has set
> (text-properties-at 0 message))
> (setq message (apply #'propertize message minibuffer-message-properties)))
> - (let ((ol (make-overlay (point-max) (point-max) nil t t))
> + (let* ((ovpos (minibuffer--message-overlay-pos))
> + (ol (make-overlay ovpos ovpos nil t t))
Doesn't this rely too much on the internal details of
minibuffer--message-overlay-pos? At least, without any comments, this
call looks like a riddle that isn't easy to unlock.
> - (put-text-property 0 1 'cursor t message))
> + (put-text-property 0 1 'cursor 1 message))
Why this change?
next prev parent reply other threads:[~2021-06-06 5:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 12:50 bug#48669: Inconsistent overlay placement between minibuffer-message and set-minibuffer-message João Guerra
2021-05-31 20:24 ` Juri Linkov
2021-06-05 21:43 ` Juri Linkov
2021-06-06 5:58 ` Eli Zaretskii [this message]
2021-06-06 20:54 ` Juri Linkov
2021-06-07 12:21 ` Eli Zaretskii
2021-06-08 16:52 ` Juri Linkov
2021-06-08 18:12 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r1hfilfg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=48669@debbugs.gnu.org \
--cc=joca.bt@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).