From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions Date: Mon, 22 Nov 2021 18:56:26 +0200 Message-ID: <83r1b8p1s5.fsf@gnu.org> References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> <87wnl1gwc7.fsf@thb.lt> <83ilwlqpiw.fsf@gnu.org> <87sfvpguoh.fsf@thb.lt> <83ee79qo9g.fsf@gnu.org> <87pmqtgtyj.fsf@thb.lt> <83bl2dqnfj.fsf@gnu.org> <87mtlxgt0z.fsf@thb.lt> <837dd1qmko.fsf@gnu.org> <87o86cr1td.fsf@thb.lt> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38528"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52018@debbugs.gnu.org To: Thibault Polge Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 22 17:57:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpCd1-0009nS-1B for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Nov 2021 17:57:15 +0100 Original-Received: from localhost ([::1]:51480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpCcz-0003cR-M4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Nov 2021 11:57:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpCco-0003cI-Mj for bug-gnu-emacs@gnu.org; Mon, 22 Nov 2021 11:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37406) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpCco-0000M0-Er for bug-gnu-emacs@gnu.org; Mon, 22 Nov 2021 11:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mpCco-0003pp-BJ for bug-gnu-emacs@gnu.org; Mon, 22 Nov 2021 11:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Nov 2021 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52018 X-GNU-PR-Package: emacs Original-Received: via spool by 52018-submit@debbugs.gnu.org id=B52018.163760018814692 (code B ref 52018); Mon, 22 Nov 2021 16:57:02 +0000 Original-Received: (at 52018) by debbugs.gnu.org; 22 Nov 2021 16:56:28 +0000 Original-Received: from localhost ([127.0.0.1]:48952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpCcG-0003ou-7M for submit@debbugs.gnu.org; Mon, 22 Nov 2021 11:56:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpCcD-0003oh-PM for 52018@debbugs.gnu.org; Mon, 22 Nov 2021 11:56:26 -0500 Original-Received: from [2001:470:142:3::e] (port=40778 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpCc7-0000Jj-P7; Mon, 22 Nov 2021 11:56:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=V1Q9yxOcRA4jLvcCryTfvbSwb7lz/O3s1y4LO58F/5Y=; b=UmV/L80S2n/9 b05BSDSnwmWjD+ud6zTQpU5WxRDeM4gefUlZakU0cfgBHzAxONGTaENJNZz/99vHYBtYs4PAv+FhJ tlBkRZfIafrumBrkwCXVWMCq3u3ELORKoDjrEl4Mb5FCKE8YF8xjShEAh64GwfUzObXeFE1VGknGF K6YRI0MG01GSvqEUEqLmRAdXBguTf4EFoyrCM9DycvV2sctZ+ciq/aWFF7pbY9eV2ULMMj3+s8JqC ZuipWMOGfro3DKS2lh2U+Yy9OJkflJN7j5UujrhJ1qx2RGfYXqcIRrmSLhhBVE1/TRaak1vSZQdBJ cOSrfqfE6GhpjuHrAIyx2Q==; Original-Received: from [87.69.77.57] (port=4258 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpCc7-0007lZ-5t; Mon, 22 Nov 2021 11:56:19 -0500 In-Reply-To: <87o86cr1td.fsf@thb.lt> (message from Thibault Polge on Mon, 22 Nov 2021 10:12:46 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220625 Archived-At: > From: Thibault Polge > Cc: 52018@debbugs.gnu.org > Date: Mon, 22 Nov 2021 10:12:46 +0100 > > > OK, then the info is also on the mode line and can be taken from > > there. > > I'm not sure I follow you. Are you suggesting functions in > `compilation-finish-functions` should scrape the mode line to get the > compilation process' exit status, instead of just using the string > argument they receive? No need to scrape the mode line: the info is readily available in mode-line-process. If the purpose is to provide the exit status to the function, we need to take care to pass it without any massaging. We don't make a point of doing that now, so I'd prefer not to document this in such certain terms, as people will then complain that it isn't 100% accurate.