unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robin Putters <robin.putters@keronic.com>
Cc: 54766@debbugs.gnu.org
Subject: bug#54766: [PATCH] 28.1.0; Native comp: Inherit working directory for sub processes (MS Windows)
Date: Thu, 07 Apr 2022 19:08:29 +0300	[thread overview]
Message-ID: <83r168c1vm.fsf@gnu.org> (raw)
In-Reply-To: <DBAPR10MB4204B859C1CE03270DDB47C5F5E69@DBAPR10MB4204.EURPRD10.PROD.OUTLOOK.COM> (message from Robin Putters on Thu, 7 Apr 2022 14:35:57 +0000)

> From: Robin Putters <robin.putters@keronic.com>
> Date: Thu, 7 Apr 2022 14:35:57 +0000
> 
> On MS Windows systems, where the Emacs executable is typically not in the PATH, creating the async sub processes for the native compiler will fail because they are started in a random working directory. The included patch will inherit the working directory from the parent emacs process by setting default-directory before creating the sub process.    

Please tell more about the failure and its reasons.  The compilation
command does this:

                   (process (make-process
                             :name (concat "Compiling: " source-file)
                             :buffer (with-current-buffer
                                         (get-buffer-create
                                          comp-async-buffer-name)
                                       (setf buffer-read-only t)
			               (current-buffer))
                             :command (list
                                       (expand-file-name invocation-name
                                                         invocation-directory)
                                       "--batch" "-l" temp-file)

So the program we invoked already has its executable file name
expanded relative to invocation-directory, and we shouldn't need PATH
at all.  What am I missing?





  reply	other threads:[~2022-04-07 16:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 14:35 bug#54766: [PATCH] 28.1.0; Native comp: Inherit working directory for sub processes (MS Windows) Robin Putters
2022-04-07 16:08 ` Eli Zaretskii [this message]
2022-04-23 17:16   ` Lars Ingebrigtsen
2022-05-22 11:27     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r168c1vm.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=54766@debbugs.gnu.org \
    --cc=robin.putters@keronic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).