From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56407: 29.0.50; desktop.el shouldn't be saving/restoring eglot--managed-mode, which is not for interactive use Date: Wed, 06 Jul 2022 14:09:33 +0300 Message-ID: <83r12y7b0y.fsf@gnu.org> References: <87y1x7pd53.fsf@gmail.com> <83v8sb73ga.fsf@gnu.org> <87tu7vpc8y.fsf@gmail.com> <83tu7v6kjv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5315"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56407@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 06 13:10:56 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o92vn-00017d-GY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 13:10:55 +0200 Original-Received: from localhost ([::1]:51240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o92vl-00041I-JK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 07:10:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o92uw-00040p-OP for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 07:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58731) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o92uw-0007Kq-Cp for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 07:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o92uw-0008UQ-1l for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 07:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2022 11:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56407 X-GNU-PR-Package: emacs Original-Received: via spool by 56407-submit@debbugs.gnu.org id=B56407.165710578832606 (code B ref 56407); Wed, 06 Jul 2022 11:10:01 +0000 Original-Received: (at 56407) by debbugs.gnu.org; 6 Jul 2022 11:09:48 +0000 Original-Received: from localhost ([127.0.0.1]:52628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o92ui-0008Tp-7g for submit@debbugs.gnu.org; Wed, 06 Jul 2022 07:09:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o92uf-0008Ta-JS for 56407@debbugs.gnu.org; Wed, 06 Jul 2022 07:09:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o92ua-0007BL-CD; Wed, 06 Jul 2022 07:09:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=vv4mwXut5LqlPDvFkXmzS/Pdn5p1Yh0ei4Z3F6FhQLA=; b=O+XW9Shr5WZCOBNBQxZS s7lgdyRhTpnnLNPMtfwlAHvONv5xi82dEYoKgsMl5vAfG380mAW9d0XXJPu3FN28WiWnKIAbJaDhz 6JGhNe1bYme6TzgW/BZHaap5qxvLM+rS+Kuq/suNW1vNx3BHOzdzo1v+gSn9C5xUm1yEdH3xDIFOX e8ZDiFowUbQyBVDZ/0RXIfACOqVmkq+mdUM9QvCHbbu9lpvR9c5MwR2gpE4JqeaVS8S/j/RkGdNTp RlTK19s2AB3eJAtWpwwBujUU7xcoMNWlh4hfJNKW2T2OtbH3hWoA+Zl6biZvLbjt1BO/tFk0+CsZn Agf89XOX1Xk+8w==; Original-Received: from [87.69.77.57] (port=2917 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o92uZ-0000YB-Sg; Wed, 06 Jul 2022 07:09:40 -0400 In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Wed, 6 Jul 2022 09:12:39 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236213 Archived-At: > From: João Távora > Date: Wed, 6 Jul 2022 09:12:39 +0100 > Cc: 56407@debbugs.gnu.org > > I see no reason to require: you just add a value to the list, that's > all. > > Oh, it's an autoloaded variable. OK then, it'll work. It'll load in desktop.el > though. I feel there's some misunderstanding here. What I meant is simply add eglot--managed-mode to the default value of the variable in desktop.el. Why would that require loading desktop.el? > > I think I like Lars's solution best. > > I don't: it makes the information spread out and harder to find. > > Depends on whether one thinks using the global symbol table in Elisp is > counts as "spread out". I don't. What do you mean by "global symbol table"? What I meant is that having all the modes which desktop.el treats specially in one place in desktop.el makes it easier to find out which modes are those, than if each of the modes had something like "(put foo-mode 'desktop...)" in its own file. Because in the latter case, if I want to know which modes are handled specially by desktop, I'd need to search the entire tree. > There's a nice upside to it, which is it prevents people like me not > interested in desktop.el at all from having it autoloaded just by loading > eglot.el. The things eglot.el is trying to say to desktop.el is "stay out of > my minor mode" so it is strange that it has to pull in desktop.el every time > just to say that. See above: I don't think I understand why would you need to load desktop.el. The variable desktop-minor-mode-table is of interest only when the desktop is saved or restored, and at that time desktop.el is already loaded, of course. No other code anywhere else should need to consult desktop-minor-mode-table. Or what am I missing?