From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59544: [PATCH] Fixed lib-src/etags.c command execute vulnerability Date: Sat, 26 Nov 2022 16:17:55 +0200 Message-ID: <83r0xpssto.fsf@gnu.org> References: <837czkw7sl.fsf@gnu.org> <8335a8w643.fsf@gnu.org> <83fse7ut10.fsf@gnu.org> <83y1rxsvf6.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23707"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59544@debbugs.gnu.org, stefankangas@gmail.com To: lux Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 26 15:18:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyw0Y-0005sZ-61 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Nov 2022 15:18:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyw0J-0000Ol-M1; Sat, 26 Nov 2022 09:18:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyw0I-0000Oc-LN for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 09:18:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyw0I-0000cT-DF for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 09:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyw0I-0004yZ-8c for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 09:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 14:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security patch Original-Received: via spool by 59544-submit@debbugs.gnu.org id=B59544.166947225719075 (code B ref 59544); Sat, 26 Nov 2022 14:18:02 +0000 Original-Received: (at 59544) by debbugs.gnu.org; 26 Nov 2022 14:17:37 +0000 Original-Received: from localhost ([127.0.0.1]:38290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyvzt-0004xb-8M for submit@debbugs.gnu.org; Sat, 26 Nov 2022 09:17:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyvzr-0004xP-Uf for 59544@debbugs.gnu.org; Sat, 26 Nov 2022 09:17:36 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyvzm-0000Xd-OQ; Sat, 26 Nov 2022 09:17:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=icSdDfSWkd3kTkbe4ftZ3SiADfDgn56kprULKFHL2lk=; b=FioaC/lPvmwu /aeJibWrAw4oNtVghb8DNT1Nmuzwejqs8UcIwX0P/75vrafth71yoFd1Um9hOpcjx37PcN2OMWfjg VBYgxSPILVYljetmDAZuYavP3YXA73QsUiM22QRHCwlT/Yba+ovtUhGcs2ztZhotFGknMwytf4vKf f8iIzfzDVxdRfMP0hRlQch/gE9m8Jy24c9FLf7/qFocKQREQ9iI7oXaHPWIgx6ak/xktU7XCYAglG 9RwCy9dbyIjYiG2K7SEotyyILtnI/l3MrD28bRjJQx2YxqTaAIOiJEVWxIYapiy21aGcb2xbzEFxR XhQAoh6Z7cNLAoBaMxwkgQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyvzm-0000Qr-86; Sat, 26 Nov 2022 09:17:30 -0500 In-Reply-To: (message from lux on Sat, 26 Nov 2022 21:42:48 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249092 Archived-At: > Date: Sat, 26 Nov 2022 21:42:48 +0800 > Cc: stefankangas@gmail.com, 59544@debbugs.gnu.org > From: lux > > On 2022/11/26 21:21, Eli Zaretskii wrote: > >> Date: Sat, 26 Nov 2022 11:09:26 +0800 > >> Cc: 59544 <59544@debbugs.gnu.org> > >> From: lux > >> > >> + linebuffer line; > >> + linebuffer_init (&line); > >> + while (readline_internal (&line, tag_f, tagfile) > 0) > > This needs a minor adjustment: readline_internal removes the CR characters > > from CR-LF end-of-lines, so I think using it unaltered will convert files > > with DOS-style EOLs to Unix-style EOLs, because we write them with a single > > newline at the end. I think the best fix is to add one more argument to > > readline_internal, which, if non-zero, will cause it to avoid removing the > > CR characters. > > Hmm.. but doing this doesn't have much to do with fixing the this > vulnerability, since > > the previous hardcoded one doesn't work on Windows, so can it be changed > later? I'd prefer to fix them together. It's very simple, isn't it?