From: Eli Zaretskii <eliz@gnu.org>
To: Nicolas Graner <nicolas@graner.name>
Cc: 59804@debbugs.gnu.org
Subject: bug#59804: shell-resync-dirs hangs in (t)csh
Date: Sun, 04 Dec 2022 10:17:10 +0200 [thread overview]
Message-ID: <83r0xfbn21.fsf@gnu.org> (raw)
In-Reply-To: <87r0xghg60.fsf@graner.name> (message from Nicolas Graner on Sat, 03 Dec 2022 12:37:11 +0100)
> From: Nicolas Graner <nicolas@graner.name>
> Date: Sat, 03 Dec 2022 12:37:11 +0100
>
> In a shell buffer where the running shell is csh or tcsh, the command
> shell-resync-dirs never returns.
>
> You can test this even without changing your normal shell by typing
> `csh' in any shell buffer, then M-<RET>
> Emacs hangs until you quit with C-g.
>
> The reason is that the `dirs' command in (t)csh (unlike its equivalent
> in bash) adds a trailing space to its output. This triggers an infinite
> loop.
>
> As evidence that the trailing space is the culprit, note that this
> kludge, whiche removes it, fixes the problem:
>
> (setq shell-dirstack-query "dirs | sed 's/ $//'")
Thanks for the analysis. Does the patch below fix this problem? If not,
could you point out more precisely where the command infloops and why?
diff --git a/lisp/shell.el b/lisp/shell.el
index b396bc2..dadbdcb 100644
--- a/lisp/shell.el
+++ b/lisp/shell.el
@@ -1162,6 +1162,7 @@ shell-resync-dirs
(dlsl nil)
(pos 0)
(ds nil))
+ (setq dls (string-trim-right dls "[ ]+"))
;; Split the dirlist into whitespace and non-whitespace chunks.
;; dlsl will be a reversed list of tokens.
(while (string-match "\\(\\S-+\\|\\s-+\\)" dls pos)
next prev parent reply other threads:[~2022-12-04 8:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 11:37 bug#59804: shell-resync-dirs hangs in (t)csh Nicolas Graner
2022-12-04 8:17 ` Eli Zaretskii [this message]
2022-12-04 18:41 ` Nicolas Graner
2022-12-04 19:15 ` Eli Zaretskii
2022-12-10 12:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r0xfbn21.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59804@debbugs.gnu.org \
--cc=nicolas@graner.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).