From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced Date: Wed, 04 Jan 2023 20:42:31 +0200 Message-ID: <83r0waxht4.fsf@gnu.org> References: <87o7ri74qv.fsf@localhost> <9bc9c69ac20a37ded741@heytings.org> <9bc9c69ac282c0148962@heytings.org> <87h6x9mgdv.fsf@localhost> <838rij23by.fsf@gnu.org> <83zgazznau.fsf@gnu.org> <83mt6yz7se.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35609"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60467@debbugs.gnu.org, acm@muc.de, yantar92@posteo.net, monnier@iro.umontreal.ca To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 04 19:43:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pD8jJ-00095y-Cg for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Jan 2023 19:43:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pD8jD-0001xM-Fm; Wed, 04 Jan 2023 13:43:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD8jA-0001wl-8y for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 13:43:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pD8j8-0005WW-3D for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 13:43:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pD8j7-0004NZ-RH for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 13:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jan 2023 18:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60467 X-GNU-PR-Package: emacs Original-Received: via spool by 60467-submit@debbugs.gnu.org id=B60467.167285775016792 (code B ref 60467); Wed, 04 Jan 2023 18:43:01 +0000 Original-Received: (at 60467) by debbugs.gnu.org; 4 Jan 2023 18:42:30 +0000 Original-Received: from localhost ([127.0.0.1]:49606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pD8iZ-0004Mj-3w for submit@debbugs.gnu.org; Wed, 04 Jan 2023 13:42:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pD8iX-0004MV-35 for 60467@debbugs.gnu.org; Wed, 04 Jan 2023 13:42:25 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD8iQ-0004kj-T0; Wed, 04 Jan 2023 13:42:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0OejVq2GAO4sdqocOvKZj+2bFRE4W3oKBzyV0V/sDvc=; b=WPRfx4C0sZkf IsvX9nsJmEr/yy7oS2MZ+bH6MovT2B2aitElfYMiBHOP/p8qG6BtZCWeVxC7G05m+hyH2w1IB+my5 aqbpmhuu2eOYQeo35Mw1o6aNuJqxbG5578CNigdk8+wqcIansndSHQnilWe23MER7B89B9IUmDe2M vJwDwE22V6sZxyaS1Cr1lrm/+OwdTab4KJS6Bm1HHORo8/01BYauSCz9RLkPqEjtSB2F8Tdopa1JG hzj7CkPGIpVQYRtEUTIKXYqHIuFCV1mDhhjae2C7sNzCR5j79RA44zW+dQwfjymgDePJxkBjcRbCK 3JDEhmrQNAOtx7whUo94lg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD8iQ-0004Zp-8G; Wed, 04 Jan 2023 13:42:18 -0500 In-Reply-To: (message from Gregory Heytings on Wed, 04 Jan 2023 18:16:07 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252527 Archived-At: > Date: Wed, 04 Jan 2023 18:16:07 +0000 > From: Gregory Heytings > cc: 60467@debbugs.gnu.org, acm@muc.de, Eli Zaretskii , > yantar92@posteo.net > > > My hope is that we can just remove the timestamp special case, in which > > case we can keep the current code mostly unchanged. > > > > Then our hopes are different. What's wrong exactly with replacing a piece > of code that requires a long discussion with question marks everywhere to > be understood by a piece of well-documented code that is much more > readable and "evidently" does what it is supposed to do? The old code was working for quite a few years, so it isn't all wrong. Minimizing changes also minimizes the risk of introducing new exciting bugs. For a release branch, both these aspects are a clear win. Why do you object so much to leaving the timestamps in the undo-list?