From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60795: 28.2; `diary-list-entries' hides the interesting message done in `diary-display-no-entries' Date: Sat, 14 Jan 2023 15:13:04 +0200 Message-ID: <83r0vx6yzj.fsf@gnu.org> References: <7c238403544742ee955184d5d4815943@vodafonemail.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1271"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60795@debbugs.gnu.org To: "Farblos" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 14 14:14:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pGgMY-0000Ag-VJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Jan 2023 14:14:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGgMG-0002E5-Lf; Sat, 14 Jan 2023 08:14:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGgMF-0002Dp-2K for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2023 08:14:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pGgME-0001Rj-Me for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2023 08:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pGgME-0005Tt-9e for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2023 08:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Jan 2023 13:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60795 X-GNU-PR-Package: emacs Original-Received: via spool by 60795-submit@debbugs.gnu.org id=B60795.167370199020997 (code B ref 60795); Sat, 14 Jan 2023 13:14:02 +0000 Original-Received: (at 60795) by debbugs.gnu.org; 14 Jan 2023 13:13:10 +0000 Original-Received: from localhost ([127.0.0.1]:53632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGgLO-0005Sb-Dh for submit@debbugs.gnu.org; Sat, 14 Jan 2023 08:13:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGgLM-0005SP-Sm for 60795@debbugs.gnu.org; Sat, 14 Jan 2023 08:13:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGgLG-0001K7-Dy; Sat, 14 Jan 2023 08:13:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UlgSXIxRlQdzSm01JUaywpp+VYe1Tih5NC0SoOuht54=; b=lQnACR/uMJDh vFR7FwWau4VjX4lquBwA6WCZzIrRMIPXN3E3aZ77GxfF/lNat+TlmbvYeMp8yWO5VP/ezyGO7wRpg JUl0REA4AYMLPxf++M6zMmVuB3prB90OCcQ9rH52gOTN3Fva3EinkwjdYqG8BBohbPBGWpu9je+/1 h7BPSSxDXdRRN8Hjw0hyZUZSHfEq/uQ5gfcoIumBAK/MMO56ARZtOjYcHqDK2R8UUH6UeeV4+1LeT ODbJxDS89at1aA5rKUThQ4tAHwDgbvQ0XLAZKD+ZffYhCGLbghT7XnLXjoXuyFzsP6qTuyxMXCZcl CySEiWDDErLZ05Xh/Z2wwQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGgLF-0002zu-IE; Sat, 14 Jan 2023 08:13:01 -0500 In-Reply-To: <7c238403544742ee955184d5d4815943@vodafonemail.de> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253356 Archived-At: > Date: Fri, 13 Jan 2023 22:54:17 +0100 > From: "Farblos" via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > `diary-list-entries' hides the interesting status message done in > `diary-display-no-entries' ("No diary entries for %s") with a less > important progress message ("Preparing diary...done"). > > To reproduce: > > # ensure you do not clobber anything important ... > $ test -f ~/.emacs/diary && mv ~/.emacs/diary ~/.emacs/diary.bak > $ cp /dev/null ~/.emacs/diary > $ emacs -Q > M-x diary RET > > Observe the minibuffer showing "Preparing diary...done" and check the > message buffer to find the really relevant message "No diary entries for > Friday, January 13, 2023" issued just before that. > > This used to work at least in Emacs, well, 23.4.1. Thank you for your report. Does the patch below give good results? diff --git a/lisp/calendar/diary-lib.el b/lisp/calendar/diary-lib.el index b90ed71..80fc66f 100644 --- a/lisp/calendar/diary-lib.el +++ b/lisp/calendar/diary-lib.el @@ -880,7 +880,10 @@ diary-list-entries (original-date original-date)) (run-hooks 'diary-hook)))))) (and temp-buff (buffer-name temp-buff) (kill-buffer temp-buff))) - (or d-incp (message "Preparing diary...done")) + (or d-incp + ;; Don't clobber messages displayed by preparing the diary. + (not (equal (current-message) "Preparing diary...")) + (message "Preparing diary...done")) diary-entries-list))) (defun diary-unhide-everything ()