From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>, martin rudalics <rudalics@gmx.at>
Cc: 60886@debbugs.gnu.org
Subject: bug#60886: 29.0.60; split-root-window-below broken for split-window-keep-point
Date: Wed, 18 Jan 2023 15:08:11 +0200 [thread overview]
Message-ID: <83r0vs0z44.fsf@gnu.org> (raw)
In-Reply-To: <86k01la7gn.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 17 Jan 2023 19:10:48 +0200)
> From: Juri Linkov <juri@linkov.net>
> Date: Tue, 17 Jan 2023 19:10:48 +0200
>
> etc/NEWS:
>
> *** New commands 'split-root-window-below' and 'split-root-window-right'.
> These commands split the root window in two, and are bound to 'C-x w 2'
> and 'C-x w 3', respectively.
>
> 0. emacs -Q
> 1. (setq split-window-keep-point nil)
> 2. C-x w 2
> 3. C-x w 2
>
> Debugger entered--Lisp error: (wrong-type-argument stringp nil)
> split-window-below(nil #<window 14>)
> split-root-window-below(nil)
> funcall-interactively(split-root-window-below nil)
> command-execute(split-root-window-below)
>
> diff --git a/lisp/window.el b/lisp/window.el
> index 4099b707009..53d34a3bf6e 100644
> --- a/lisp/window.el
> +++ b/lisp/window.el
> @@ -5670,7 +5675,8 @@ split-window-keep-point
>
> (defun split-window-below (&optional size window-to-split)
> "Split WINDOW-TO-SPLIT into two windows, one above the other.
> -WINDOW-TO-SPLIT is above. The newly split-off window is
> +WINDOW-TO-SPLIT defaults to the selected window and after
> +splitting remains above. The newly split-off window is
"Remains" is not a good word here: we are splitting the window in two,
so none of them "remains". I'd say "...and will be above the other
window after splitting".
> (defun split-window-right (&optional size window-to-split)
> "Split WINDOW-TO-SPLIT into two side-by-side windows.
> -WINDOW-TO-SPLIT is on the left. The newly split-off window is on
> +WINDOW-TO-SPLIT defaults to the selected window and after
> +splitting remains on the left. The newly split-off window is on
> the right and displays the same buffer. Return the new window.
Same here.
Martin, any comments?
next prev parent reply other threads:[~2023-01-18 13:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 17:10 bug#60886: 29.0.60; split-root-window-below broken for split-window-keep-point Juri Linkov
2023-01-18 13:08 ` Eli Zaretskii [this message]
2023-01-18 17:13 ` martin rudalics
2023-01-18 17:32 ` martin rudalics
2023-01-18 18:25 ` Juri Linkov
2023-01-18 23:03 ` martin rudalics
2023-01-19 6:34 ` Eli Zaretskii
2023-01-19 8:49 ` martin rudalics
2023-01-19 10:05 ` Eli Zaretskii
2023-01-19 10:43 ` martin rudalics
2023-01-19 11:32 ` Eli Zaretskii
2023-01-20 9:17 ` martin rudalics
2023-01-21 8:16 ` Eli Zaretskii
2023-01-21 10:08 ` martin rudalics
2023-01-21 11:39 ` Eli Zaretskii
2023-01-21 15:30 ` martin rudalics
2023-01-21 15:55 ` Eli Zaretskii
2023-01-22 9:53 ` martin rudalics
2023-01-26 8:01 ` Eli Zaretskii
2023-01-26 15:44 ` martin rudalics
2023-01-26 16:40 ` Eli Zaretskii
2023-01-21 17:57 ` Juri Linkov
2023-01-22 9:53 ` martin rudalics
2023-01-22 17:09 ` Juri Linkov
2023-01-24 17:55 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r0vs0z44.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60886@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).