From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60961: 29.0.60; Compiling emacs-29 without treesitter outputs warnings Date: Fri, 20 Jan 2023 17:17:22 +0200 Message-ID: <83r0vpme0t.fsf@gnu.org> References: <878rhx1os6.fsf@gmail.com> <831qnpnx9g.fsf@gnu.org> <87o7qtuxgh.fsf@thornhill.no> <83tu0lmgv6.fsf@gnu.org> <87h6wll10q.fsf@thornhill.no> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23071"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, casouri@gmail.com, 60961@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 20 16:18:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIt9t-0005pQ-9d for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Jan 2023 16:18:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIt9d-0004vy-HF; Fri, 20 Jan 2023 10:18:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIt9X-0004tY-2l for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 10:18:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pIt9W-0007Y4-KD for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 10:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pIt9W-0005hh-Ef for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 10:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Jan 2023 15:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60961 X-GNU-PR-Package: emacs Original-Received: via spool by 60961-submit@debbugs.gnu.org id=B60961.167422785021876 (code B ref 60961); Fri, 20 Jan 2023 15:18:02 +0000 Original-Received: (at 60961) by debbugs.gnu.org; 20 Jan 2023 15:17:30 +0000 Original-Received: from localhost ([127.0.0.1]:46895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIt90-0005gm-7H for submit@debbugs.gnu.org; Fri, 20 Jan 2023 10:17:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIt8y-0005ga-Uk for 60961@debbugs.gnu.org; Fri, 20 Jan 2023 10:17:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIt8t-0007OC-7M; Fri, 20 Jan 2023 10:17:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=q6c4oned/RPtcEKAS22ItOpSEeJa47fOaro7B5Rk9J8=; b=doMrcqCQCei0 fKo8PnVOVLLD8R08nEZnfIwWvzIALCbnFpJxOG2nUmneglA1hRJDLntnkqFoMwsdNIvi4g5H7+6dO Sj3jVVIWnRhBAQkdCdDC7xA0Q/RhbynZvFCnll6Wc2uT47oTgvX+8ri0HmgTpHr1HLoAMgN2VwfhK +PZ0lGCP387dt7mGDtIyAoy/MMb/AVaSuo+Sq9TpUcNWKaY3q5QB3Fr3+3QNXiOkZtEI1PeERkmUK E9EvRSPmjaACidCdc7fdKVC5Qg976t5Gyw7EqUMh8jqWFY0bHaTIW/t7ZgtF3oK2n7AT93nJZy4YB gAR4Yb3yanD8M0cUU8QUeA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIt8s-0007Tv-N8; Fri, 20 Jan 2023 10:17:23 -0500 In-Reply-To: <87h6wll10q.fsf@thornhill.no> (message from Theodor Thornhill on Fri, 20 Jan 2023 15:43:33 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253783 Archived-At: > From: Theodor Thornhill > Cc: rpluim@gmail.com, casouri@gmail.com, 60961@debbugs.gnu.org > Date: Fri, 20 Jan 2023 15:43:33 +0100 > > Eli Zaretskii writes: > > >> So I can either just make sure that no modes require across modes, or > >> make that "lib" right now. What do you think? > > > > I tend to the "lib" method. Mostly because several modes, including > > some that are unrelated to C, want the code which was written for > > C/C++, and so it is possible that there's some general feature here > > waiting for us to refactor the code -- in which case perhaps the code > > should be in treesit.el? > > > > IOW, how come JS, Rust, and Typescript all want comment-related setup > > that was written for C? If this is just a coincidence, then perhaps > > duplicating the code is a better idea, but if there's some underlying > > commonality, we should have common code in treesit.el, or maybe in > > some c-ts-common.el? > > I can start by moving it into treesit.el, then we can maybe extract > something out later. Sounds good? I can do it tonight, unless any of > you object :) SGTM, but let's hear from Yuan before you start working on this. Thanks.