From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60841: 30.0.50; kill-ring-save pauses despite region being highlighted Date: Tue, 24 Jan 2023 15:23:10 +0200 Message-ID: <83r0vkgj7l.fsf@gnu.org> References: <87h6wrs71h.fsf@gmail.com> <83zgai4peg.fsf@gnu.org> <5583fd58387746ce7ddc@heytings.org> <87cz7dbns0.fsf@gmail.com> <4c2c6cf44ad37e405b06@heytings.org> <878ri0g6ob.fsf@gmail.com> <83pmbc0yxo.fsf@gnu.org> <87y1pzo5dp.fsf@gmail.com> <834jskmhs8.fsf@gnu.org> <87fsc2qjcs.fsf@gmail.com> <833581jtff.fsf@gnu.org> <87lelsga1f.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29421"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gregory@heytings.org, 60841@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 24 14:24:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKJHm-0007Um-2T for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Jan 2023 14:24:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKJHT-0004E7-Ug; Tue, 24 Jan 2023 08:24:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKJHO-0004Dn-CO for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 08:24:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKJHO-0006AY-3W for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 08:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKJHN-0004bU-Ux for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 08:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Jan 2023 13:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60841 X-GNU-PR-Package: emacs Original-Received: via spool by 60841-submit@debbugs.gnu.org id=B60841.167456658917630 (code B ref 60841); Tue, 24 Jan 2023 13:24:01 +0000 Original-Received: (at 60841) by debbugs.gnu.org; 24 Jan 2023 13:23:09 +0000 Original-Received: from localhost ([127.0.0.1]:56139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKJGW-0004aI-GX for submit@debbugs.gnu.org; Tue, 24 Jan 2023 08:23:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKJGU-0004Zm-QD for 60841@debbugs.gnu.org; Tue, 24 Jan 2023 08:23:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKJGP-00061a-2u; Tue, 24 Jan 2023 08:23:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=VSiJTr3KKbiVhXaFLoeHBsrsU40iMUuYILKou3hDqxo=; b=qvuYPDkZWOLxA1ZnClbX HmYyOqisx3SmUovYNZeniGMGreT5T/GVPGrmQrzGP7OB767Itt4BXhnerlA8aJBW9Zq6hBWrHFJ9v de/hp0Y20kHkPTKDtKuaXrIPiibVTE1Mb+q0UQkEE7wzPqbD4DaIMbeQ7QjUWXYZX2JKY5WWKr/EW KevMY3EVTbFYzykTEBwy5nqb/fdjZoo8RpMgj2J5bdZvicbiKO+gMf3yt2H/HZUNj6dVFqDVZKVL9 V+gWuuEDciSLtT03LpUIj3GpRtvcoTPLrTkFA2vbLRsHLdBbldXZ96obZ3dQECq7qjRS1n8O2NDvm mVgGA1QT7ms7iw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKJGO-00026w-Dw; Tue, 24 Jan 2023 08:23:00 -0500 In-Reply-To: <87lelsga1f.fsf@gmail.com> (message from =?UTF-8?Q?K=C3=A9vin?= Le Gouguec on Mon, 23 Jan 2023 23:29:00 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254048 Archived-At: > From: Kévin Le Gouguec > Cc: gregory@heytings.org, 60841@debbugs.gnu.org > Date: Mon, 23 Jan 2023 23:29:00 +0100 > > > seq.el is indeed preloaded, so that ship has sailed. But you still > > need to make sure seq is loaded _before_ any preloaded file which uses > > it, and in this case faces is loaded before seq, so you cannot use > > seq-difference. > > (Thanks for spelling this out. Do we have any documentation that calls > out the precautions one must take when writing Elisp that will be > preloaded, or any tooling that can detect whether some of those > precautions were forgotten? FWIW I saw no compiler warnings nor runtime > errors with that patch) Did you "make bootstrap"? If not, some errors might not happen, because the build will use previously compiled foo.elc files. As for documentation: there's any number of such factoids related to do's and dont's of Emacs development, and we lack a full-time documentation fellow to keep all of them documented and up to date... > >> +(defun region-highlighted-p () > >> + "Say whether the region is visibly highlighted. > > > > Please drop the "Say" part, it's not our style. > > ACK. I see a few matches for "Return whether…" in-tree; would… > > Return whether the region stands out visually. > > … be OK, or should I just go for… It's OK, but IMO the "Return" part is almost redundant here. But I won't object to having it. > "(elisp) Documentation Tips" recommends "Return t if", but merely as a > way to "avoid starting the sentence with “t”", not because we have a > preference for literally starting with "Return t if") The point here is that this is a predicate, so it is known up front that it will "return t" or nil. The only non-trivial part is the condition under which it will return non-nil. Thanks.