From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: 61726@debbugs.gnu.org, arstoffel@gmail.com
Subject: bug#61726: [PATCH] Eglot: Support positionEncoding capability
Date: Sun, 26 Feb 2023 16:50:13 +0200 [thread overview]
Message-ID: <83r0uciiqi.fsf@gnu.org> (raw)
In-Reply-To: <87r0ucpl30.fsf@gmail.com> (message from João Távora on Sun, 26 Feb 2023 14:17:39 +0000)
> From: João Távora <joaotavora@gmail.com>
> Cc: arstoffel@gmail.com, 61726@debbugs.gnu.org
> Date: Sun, 26 Feb 2023 14:17:39 +0000
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > I've corrected a few doc strings to use a more widely-familiar
> > terminology.
>
> Thanks, but at one of the corrections is mistaken, so I've fixed it like
> this.
>
> (defvar eglot-current-linepos-function #'eglot-utf-16-linepos
> - "Function calculating number of UTF-16 code units from line beginning.
> + "Function calculating number of code units from line beginning.
>
> This is the inverse operation of
> `eglot-move-to-linepos-function' (which see). It is a function of
>
> This variable is set by default to a function that indeed does UTF-16
> calculations. But it can and will be set to one that does UTF-32 or
> UTF-8 codepoint calculations, depending on the server.
>
> I also have a few nits. In your patch:
>
> (defun eglot-utf-32-linepos ()
> - "Calculate number of code units to line beginning using UTF-32."
> + "Calculate number of Unicode codepoints from line beginning."
> (- (point) (line-beginning-position)))
>
> This is strictly true, because in UTF-32 it's one code point per code
> unit. But the protocol of the variable
> 'eglot-current-linepos-function', where this function is to be plugged,
> a code-unit counting function is demanded. I would predict that
> encoding-challenged programmers (like this package's maintainer in about
> 2 week's time) might not know about that equivalence and will find it
> slightly confusing to plug this function into that variable.
>
> But as I said this is just a nit.
I made one more fix.
next prev parent reply other threads:[~2023-02-26 14:50 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 8:05 bug#61726: [PATCH] Eglot: Support positionEncoding capability Augusto Stoffel
2023-02-23 10:39 ` Eli Zaretskii
2023-02-23 11:32 ` João Távora
2023-02-23 12:04 ` Augusto Stoffel
2023-02-23 12:24 ` João Távora
2023-02-23 11:46 ` Augusto Stoffel
2023-02-23 12:54 ` Eli Zaretskii
2023-02-23 13:31 ` Augusto Stoffel
2023-02-23 15:04 ` Eli Zaretskii
2023-02-23 18:52 ` Augusto Stoffel
2023-02-23 19:20 ` Eli Zaretskii
2023-02-23 19:28 ` João Távora
2023-02-23 19:52 ` Augusto Stoffel
2023-02-24 6:43 ` Eli Zaretskii
2023-02-24 7:18 ` Augusto Stoffel
2023-02-24 8:38 ` Eli Zaretskii
2023-02-24 9:15 ` Augusto Stoffel
2023-02-24 10:20 ` João Távora
2023-02-24 11:01 ` Augusto Stoffel
2023-02-24 11:18 ` João Távora
2023-02-24 11:47 ` Augusto Stoffel
2023-02-24 12:05 ` João Távora
2023-02-24 12:14 ` Augusto Stoffel
2023-02-24 11:38 ` Eli Zaretskii
2023-02-24 11:55 ` João Távora
2023-02-24 11:27 ` Eli Zaretskii
2023-02-24 11:43 ` João Távora
2023-02-24 11:57 ` Eli Zaretskii
2023-02-24 12:09 ` João Távora
2023-02-24 12:18 ` Eli Zaretskii
2023-02-24 12:31 ` Augusto Stoffel
2023-02-24 12:01 ` Augusto Stoffel
2023-02-24 12:16 ` Eli Zaretskii
2023-02-24 12:35 ` Augusto Stoffel
2023-02-24 12:55 ` João Távora
2023-02-24 13:34 ` Eli Zaretskii
2023-02-24 13:45 ` João Távora
2023-02-24 13:51 ` Eli Zaretskii
2023-02-24 14:45 ` Augusto Stoffel
2023-02-24 15:19 ` Eli Zaretskii
2023-02-24 15:52 ` Augusto Stoffel
2023-02-24 16:01 ` Eli Zaretskii
2023-02-24 16:39 ` Augusto Stoffel
2023-02-24 17:07 ` Eli Zaretskii
2023-02-24 18:08 ` Augusto Stoffel
2023-02-24 18:55 ` João Távora
2023-02-25 10:58 ` Eli Zaretskii
2023-03-05 10:26 ` Augusto Stoffel
2023-02-25 10:57 ` Eli Zaretskii
2023-02-25 11:29 ` Augusto Stoffel
2023-02-25 13:47 ` Eli Zaretskii
2023-02-25 14:14 ` Augusto Stoffel
2023-02-25 16:26 ` Eli Zaretskii
2023-02-25 18:10 ` Augusto Stoffel
2023-02-25 22:15 ` João Távora
2023-02-25 22:13 ` João Távora
2023-02-25 22:34 ` Augusto Stoffel
2023-02-25 23:16 ` João Távora
2023-02-25 23:57 ` Augusto Stoffel
2023-02-26 6:03 ` Eli Zaretskii
2023-02-26 10:33 ` João Távora
2023-02-26 13:13 ` João Távora
2023-02-26 13:16 ` Eli Zaretskii
2023-02-26 13:25 ` Eli Zaretskii
2023-02-26 14:17 ` João Távora
2023-02-26 14:50 ` Eli Zaretskii [this message]
2023-02-26 15:15 ` João Távora
2023-02-26 15:37 ` Eli Zaretskii
2023-02-27 11:15 ` João Távora
2023-02-26 5:31 ` Eli Zaretskii
2023-02-26 10:38 ` João Távora
2023-02-24 14:54 ` Augusto Stoffel
2023-02-24 15:23 ` Eli Zaretskii
2023-02-24 15:56 ` Augusto Stoffel
2023-02-24 17:02 ` Eli Zaretskii
2023-02-24 16:34 ` João Távora
2023-02-24 17:06 ` Eli Zaretskii
2023-02-23 11:37 ` João Távora
2023-02-23 17:01 ` Felician Nemeth
2023-02-23 17:11 ` João Távora
2023-02-23 18:42 ` Augusto Stoffel
2023-02-27 10:11 ` Felician Nemeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r0uciiqi.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61726@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).