From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62578: 30.0.50; [PATCH] Add regression tests for synchronous processes in Eshell Date: Sat, 01 Apr 2023 10:22:22 +0300 Message-ID: <83r0t4yslt.fsf@gnu.org> References: <8eeb9d54-1ac4-485d-f888-0f89217fc0ca@gmail.com> <83355k16gr.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23868"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62578@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 01 09:23:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1piVa4-00060B-H2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Apr 2023 09:23:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1piVZo-0002XF-QO; Sat, 01 Apr 2023 03:23:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piVZm-0002Wo-Kl for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2023 03:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1piVZm-0004EA-9v for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2023 03:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1piVZl-000226-TZ for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2023 03:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Apr 2023 07:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62578 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62578-submit@debbugs.gnu.org id=B62578.16803337347729 (code B ref 62578); Sat, 01 Apr 2023 07:23:01 +0000 Original-Received: (at 62578) by debbugs.gnu.org; 1 Apr 2023 07:22:14 +0000 Original-Received: from localhost ([127.0.0.1]:35323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piVZ0-00020a-3f for submit@debbugs.gnu.org; Sat, 01 Apr 2023 03:22:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piVYy-00020O-Lb for 62578@debbugs.gnu.org; Sat, 01 Apr 2023 03:22:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piVYt-0003xo-1j; Sat, 01 Apr 2023 03:22:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EgezDUkpgWIH3XTpYsYnKRpKXkILc9bIVygEyRDcZcE=; b=sfmBJLRfWidR m4gsZR8GLyt1ygJPzsyUEkSgii4CcJ0B6d0HndC1GPZ8v49hK5rxijeLjv1X4BcO3xl/8EkLu0mUi 7PqhJU1ch5HEYBrbayrARaTKL6NvjCHKzAL1TyqNUHUFSF1uB2O2gPECkG8WUDNwVOxhjPseMbqs+ uMXCd7xWhGuajOFATH7/MrIjA6tjPrgqE+nCewFd1jc0KMUYYvcNEv1/ayDtGd6rEKvldzrHdhU7a OvVFXMyt2dyZOR/krK+8iJ51Qvn0NRFg8iyloT33xZIE48YBXS/RkDkuMqp0AU5SrxtBaANOzF2TL irYC4Ks9dmEBDE8mrANz0w==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piVYs-0005fm-8a; Sat, 01 Apr 2023 03:22:06 -0400 In-Reply-To: (message from Jim Porter on Sat, 1 Apr 2023 00:16:38 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259032 Archived-At: > Date: Sat, 1 Apr 2023 00:16:38 -0700 > Cc: 62578@debbugs.gnu.org > From: Jim Porter > > Since these tests are meant to check the "synchronous subprocess" code > in Eshell on non-MS-DOS platforms, I'd say it's ok. However, I can > change my patch if you prefer. I could either: > > 1) Add a comment to the tests explaining that they're just meant to > simulate some of MS-DOS's limitations on non-MS-DOS systems, or > > 2) Rework these tests so they work the same on both MS-DOS and other > systems. > > Personally, I lean softly towards (1), partly because the Eshell test > suite probably breaks in quite a few other places on MS-DOS anyway. > However, it shouldn't be too hard to do (2) instead. > > What do you think? I don't understand why not use Emacs instead of all those external commands. That solves all the problems nicely and portably, and still allows you to do anything you want. But it's your call, eventually.