From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63253: 29.0.90; with-delayed-message fails in combination with inhibit-message Date: Wed, 10 May 2023 18:50:35 +0300 Message-ID: <83r0ro6v90.fsf@gnu.org> References: <87r0rxdwc8.fsf@daniel-mendler.de> <837ctidgab.fsf@gnu.org> <831qjqdcz9.fsf@gnu.org> <838rdwa12j.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="736"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mail@daniel-mendler.de, larsi@gnus.org, 63253@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 10 17:50:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwm5I-000AV2-AY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 May 2023 17:50:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwm52-0001qI-GV; Wed, 10 May 2023 11:50:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwm4o-0001mh-Te for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 11:50:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwm4o-0003qX-L5 for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 11:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pwm4o-0001uI-GU for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 11:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 May 2023 15:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63253 X-GNU-PR-Package: emacs Original-Received: via spool by 63253-submit@debbugs.gnu.org id=B63253.16837337987310 (code B ref 63253); Wed, 10 May 2023 15:50:02 +0000 Original-Received: (at 63253) by debbugs.gnu.org; 10 May 2023 15:49:58 +0000 Original-Received: from localhost ([127.0.0.1]:48777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwm4j-0001tq-NZ for submit@debbugs.gnu.org; Wed, 10 May 2023 11:49:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwm4h-0001tb-CF for 63253@debbugs.gnu.org; Wed, 10 May 2023 11:49:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwm4a-0003nl-Ck; Wed, 10 May 2023 11:49:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=W6LND5XM8H3l/JwCJFPvlS2XQALlVut//jFqfArKKdU=; b=H5bvE2BO+hpV Hht2ZEegFANcwLIcorKnTEO+eNc4a3C8ii67kV5Jl6vO1tYFtqwoi1zays6xvpAC941OCUNt/90AR lizsiYFqb3vD9ApI740X4e3vu/afb5vH4fBNMN9ANNioHVfPKendZbOZbBgGwR7KKlheXwRifZVRN jKmyuwILDRGdNDmL/Df1jil7Z6QA8FW3InG5eZdnm8t1rhu3s1r1bX7eKMJSTav5nTam2uv6IWcx9 p7BiWnLunBnrxgnlCx0CfGs1FpVPBquWyzAiwXAK/9eIXlBlglfPdd5tdxmj4yWneM8P45L01hPgh JJcLmA6+/LI/SzdWhb2jVg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwm4G-0005O4-Qx; Wed, 10 May 2023 11:49:42 -0400 In-Reply-To: (message from Stefan Monnier on Wed, 10 May 2023 11:15:54 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261512 Archived-At: > From: Stefan Monnier > Cc: larsi@gnus.org, mail@daniel-mendler.de, 63253@debbugs.gnu.org > Date: Wed, 10 May 2023 11:15:54 -0400 > > >> The code already falls back to a default behavior of displaying the > >> message in the echo area when calls to ELisp can't be used. > > > > You mean, the changes that you just installed? If so, that is AFAIU > > conditioned on garbage_collection_inhibited, which doesn't necessarily > > disable Lisp calls from delayed messages in all situations. Plus, we > > might at some point decide that garbage_collection_inhibited is not > > necessary in probably_quit. > > > > What I meant was to completely disable customizing > > set-message-function for delayed messages. We don't have to support > > that, and the fact that we call 'message' is just an implementation > > detail. If nothing else, this will make the effect on delayed > > messages consistent no matter when and how they are actually > > displayed. > > Hmm... I think "customizing `set-message-function` for delayed messages" > is actually desirable Why? we use that for a single facility, which has a well-defined purpose: show an echo-area message if BODY takes longer than some time. Why do we have to allow customization of the message displayed by this facility? > (which is why I left a FIXME in my patch). > So I regard the new behavior as a bug, just one that is hopefully less > severe than the problem it intends to avoid. How you envision that FIXME to be fixed, if atimers cannot safely run any Lisp? What kind of customizations will we be able to offer, and how? maybe_quit can be called from any kind of context, and that is a feature that we cannot give up.