From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced Date: Mon, 26 Jun 2023 18:30:33 +0300 Message-ID: <83r0pyw89y.fsf@gnu.org> References: <87o7ri74qv.fsf@localhost> <7ccb0e8131f84ca2ea0f0c0aed11dc197b578a64.camel@laposte.net> <83o7l61lz6.fsf@gnu.org> <2aa76ba11fd0a77ba107@heytings.org> <30832e86470f7dc33387@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28042"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60467@debbugs.gnu.org, frederic.giquel@laposte.net, yantar92@posteo.net, monnier@iro.umontreal.ca, acm@muc.de To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 26 17:31:41 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qDoBp-00078Y-6B for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Jun 2023 17:31:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDoBV-0004E2-GW; Mon, 26 Jun 2023 11:31:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDoBD-0004Cz-0n for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2023 11:31:15 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDoBC-0001I2-Hf for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2023 11:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qDoBC-0003SI-5K for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2023 11:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Jun 2023 15:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60467 X-GNU-PR-Package: emacs Original-Received: via spool by 60467-submit@debbugs.gnu.org id=B60467.168779342613234 (code B ref 60467); Mon, 26 Jun 2023 15:31:02 +0000 Original-Received: (at 60467) by debbugs.gnu.org; 26 Jun 2023 15:30:26 +0000 Original-Received: from localhost ([127.0.0.1]:46881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDoAc-0003RO-90 for submit@debbugs.gnu.org; Mon, 26 Jun 2023 11:30:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDoAZ-0003R5-TY for 60467@debbugs.gnu.org; Mon, 26 Jun 2023 11:30:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDoAQ-0000pY-M9; Mon, 26 Jun 2023 11:30:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=gLlLrLG4KwwtRU2j5AV4jex9yYL2wzojh4Lztn+LX1Q=; b=p7CecVdmURSB7JZOmHsf xN2DeN5PyNefynPHWpHdPvpssT9zllFkQFp+agBEL//jRCtyeoU1ow/cg+cf3VL4CmfmH7t6hepvc prL/mnFDVZPccBKskH+DPpvEIo1TuivXrbr1F+/KfOGSZtH9G8ghWLCwZXnc0cl92+WFWMWkW1KLd xUPWI876gSE47fPV5ldVjb4ONLKN2xagvYWm032Oo4s+Jb0M8jAcT2rfgt6mb5/JyS/HXFemOJ+2C tBuWh9uBPldKGDpjxslT9M78FXnj/rjidhfAGgVgIXf901dWCjI/dWwkPXSwFBPn0qnU20z7lj6s2 VhDUVTmygHpa+A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDoAP-0005DR-S7; Mon, 26 Jun 2023 11:30:14 -0400 In-Reply-To: <30832e86470f7dc33387@heytings.org> (message from Gregory Heytings on Mon, 26 Jun 2023 15:18:45 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264108 Archived-At: > Date: Mon, 26 Jun 2023 15:18:45 +0000 > From: Gregory Heytings > cc: 60467@debbugs.gnu.org, > Frédéric Giquel , > Eli Zaretskii , Ihor Radchenko , > Alan Mackenzie > > >> FYI, that issue is fixed with the > >> Fix-combine-change-call-with-timestamps patch. > > > > Oh, but I don't think this is OK for the `emacs-29` branch, so we still > > need a more targetted fix for the `emacs-29` branch. > > Well, that bug was already discussed at length six months ago, and the > minimal change that was in the end installed (59c3c53efa) introduced a new > bug. Should we design another minimal change, at the risk of introducing > another bug? ISTM that the safe thing to do is the refactoring that was > suggested. If there's no safer way than the refactoring suggested back then, we will have to stay with this regression in Emacs 29.1 and install a better fix only on master. After all, the fact that buffer-modified-p is not undone is a minor inconvenience at best. I'm sorry, but I cannot wait too much time longer before the release. The Emacs 29.1 release cycle already took significantly longer than I ever imagined. So if someone can think about some clever ideas to fix what we have on the release branch by small and safe changes, please speak up soon.