From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65051: internal_equal manipulates symbols with position without checking symbols-with-pos-enabled. Date: Sat, 05 Aug 2023 13:57:50 +0300 Message-ID: <83r0ohsqmp.fsf@gnu.org> References: <83leeqvpx8.fsf@gnu.org> <83h6pevnd0.fsf@gnu.org> <838raqvg91.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35666"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65051@debbugs.gnu.org, Stefan Monnier To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 05 12:58:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qSEzF-00090S-Dx for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Aug 2023 12:58:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSEyx-00013k-EW; Sat, 05 Aug 2023 06:58:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSEyw-000132-4O for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 06:58:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qSEyv-0004gV-SZ for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 06:58:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qSEyv-0005Fh-OV for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 06:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Aug 2023 10:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65051 X-GNU-PR-Package: emacs Original-Received: via spool by 65051-submit@debbugs.gnu.org id=B65051.169123306420162 (code B ref 65051); Sat, 05 Aug 2023 10:58:01 +0000 Original-Received: (at 65051) by debbugs.gnu.org; 5 Aug 2023 10:57:44 +0000 Original-Received: from localhost ([127.0.0.1]:55795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSEye-0005F7-Fx for submit@debbugs.gnu.org; Sat, 05 Aug 2023 06:57:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSEyd-0005Ev-7e for 65051@debbugs.gnu.org; Sat, 05 Aug 2023 06:57:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSEyW-0004bz-P9; Sat, 05 Aug 2023 06:57:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RHKEV5lclw4ETtKFBN7dMJT/zoGMxSAOPHJKG3TvWD4=; b=pJsUGj6OpHLo Lu7vFmv7hua+OXyercOQ5aEb9JjvbZvbRS30oHoCtzK57QTNuVBsoMvT0WdPGekE/J267vaCmY13R kPf+pJKlzsUhnjTMMlD+jRsehRz8MtdxfheqOo7J/TFJyX7HP5ebh/LGUzQmwpXq84XJociQuUIFz KJg1pmisYMCkeOYc8ctztm33n4k9qKsrlC2VGzLG/o2nPXTyLAlzPAHnLvDRv4ASxJvPHURYGnm5y dbLVxybxw0U6c2FDOHm85wA9WXE0gTIDlgh097l5EjDuLIlHGvrZLifeQEDda0ZbTHLsiCMbKkpvM KpxAdfxelAH0ku8H3vnSIA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSEyW-0004Tc-1e; Sat, 05 Aug 2023 06:57:36 -0400 In-Reply-To: (message from Alan Mackenzie on Sat, 5 Aug 2023 10:45:37 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266767 Archived-At: > Date: Sat, 5 Aug 2023 10:45:37 +0000 > Cc: 65051@debbugs.gnu.org, acm@muc.de > From: Alan Mackenzie > > > > With symbols-with-pos-enabled nil, # is not EQ to > > > #. Neither are these two objects `equal'. This is > > > because the special, time consuming processing which makes them EQ or > > > `equal' is enabled by that variable being bound to non-nil. > > > But I thought that with symbols-with-pos-enabled OFF, we just ignore > > the positions? Truth is, neither the ELisp manual nor the doc string > > tell us what happens when this variable is nil, they only tell what > > happens when it's non-nil. So how about documenting that somewhere? > > OK, please see the patch below. Thanks. > > > By "base symbol" I mean 'foo in #. By "identical" I > > > meant that the two Lisp_Objects would have the same hex value (i.e. be > > > EQ without symbols-with-pos-enabled), as contrasted to two distinct > > > Lisp_Objects with the same base symbol, and the same position, i.e. > > > should be `equal'. > > > So we can have two different copies of #, such that > > their hex values are different? Isn't that a bug? why don't we > > conflate such identical symbols? > > No, it's not a bug, anymore than having two `equal' copies of '(a b c) > would be a bug. But with symbols we store them in obarray, and obarray ought to find the existing slot for # and reuse it, rather than create a new slot? > Anyway, I've added code (in that patch below) to check two SWPs properly > in the event of symbols-with-pos-enabled being nil. > > As already discussed, this is intended for master, not the release > branch. Thanks. I added Stefan to the discussion, since I'd like another pair of eyes (with more knowledge about this than mine) to eyeball the changes before we install them.