From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65380: [PATCH] Add command to copy contents in a diff-mode buffer Date: Sat, 19 Aug 2023 22:09:12 +0300 Message-ID: <83r0nyyhlz.fsf@gnu.org> References: <87wmxrwe6h.fsf@posteo.net> <83o7j3z4wm.fsf@gnu.org> <87pm3jwboc.fsf@posteo.net> <83lee7z3xs.fsf@gnu.org> <87jztrvxx2.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17737"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65380@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 19 21:10:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXRKr-0004Rv-OE for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Aug 2023 21:10:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXRKk-0000yj-0L; Sat, 19 Aug 2023 15:10:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXRKj-0000yR-6M for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 15:10:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXRKi-0008KY-UT for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 15:10:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXRKj-00083S-Rw for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 15:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Aug 2023 19:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65380 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65380-submit@debbugs.gnu.org id=B65380.169247215130841 (code B ref 65380); Sat, 19 Aug 2023 19:10:01 +0000 Original-Received: (at 65380) by debbugs.gnu.org; 19 Aug 2023 19:09:11 +0000 Original-Received: from localhost ([127.0.0.1]:52293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXRJu-00081N-Kh for submit@debbugs.gnu.org; Sat, 19 Aug 2023 15:09:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXRJr-00081A-SI for 65380@debbugs.gnu.org; Sat, 19 Aug 2023 15:09:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXRJj-0008G8-Ii; Sat, 19 Aug 2023 15:08:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=F8ujw6TXl7D2GOlk0UXhwNXBPvn/qPsZMUNQdtzdp/0=; b=relKHu6tIwh9 YlLWfN/VSI/fA09kdV71shBetDaN1D8L/8TnZ+XmPRVeXQ42KDLoQ0L6DMpI6yaCRPoacJ6dW83og 86IZOyHjwBf+M+597cJTdJ0uD2pwiS19PimEkHOiVdvaw87l3pJjUP5RWzndgOmUB5OYfQ3AuH18m urIHyio5S0dKrbFWkkhqCAGRTl++jd/mo0xCTXp1QtTM1xcdnRDzOXwBBWjRWq7leoYn1qUuB5xpA 3xD9EJI4aW/rhmdYxsnLao8VRe4pXWH3z23J78d48Cz0c4qTeJ1Meq/WOvt7VJgXlbEhLoGQIHhEA OT0XQXYmZ+WbXv3S91hEWw==; In-Reply-To: <87jztrvxx2.fsf@posteo.net> (message from Philip Kaludercic on Sat, 19 Aug 2023 15:45:13 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267904 Archived-At: > From: Philip Kaludercic > Cc: 65380@debbugs.gnu.org > Date: Sat, 19 Aug 2023 15:45:13 +0000 > > Eli Zaretskii writes: > > > But diffs don't necessarily show the entire body/ies of function(s), > > they show just part of them. So this seems to be useful only in a > > very small subset of cases? > > In theory yes, but as I mentioned in my first message, it comes up > surprisingly often, at least to the degree that I think it would be > something nice to have in general. If you think the current > implementation is too primitive, one could extend it to check if the > region is a subregion of a hunk, and handle that appropriately. I'd like to hear from more people who will find this useful enough to have in Emacs. My first thought was that this is something you should keep as your local extension, but maybe I'm mistaken.