From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65414: save-some-buffers-functions are unexpectedly called when save-some-buffers pred is non-nil Date: Mon, 04 Sep 2023 13:53:24 +0300 Message-ID: <83r0ne5hwb.fsf@gnu.org> References: <871qfxvvw9.fsf@breatheoutbreathe.in> <83lee4vcac.fsf@gnu.org> <87o7ixe1e2.fsf@breatheoutbreathe.in> <83o7ixqatx.fsf@gnu.org> <87fs46cn6u.fsf@breatheoutbreathe.in> <838r9ymfh5.fsf@gnu.org> <874jkmck9j.fsf@breatheoutbreathe.in> <83v8ct9gmg.fsf@gnu.org> <87bkejnm6i.fsf@breatheoutbreathe.in> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29909"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jonas@bernoul.li, monnier@iro.umontreal.ca, 65414@debbugs.gnu.org To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 04 12:54:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qd7Dy-0007bB-5Y for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Sep 2023 12:54:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qd7DZ-0006XZ-4z; Mon, 04 Sep 2023 06:54:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qd7DW-0006XL-OG for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 06:54:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qd7DW-0002LF-G5 for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 06:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qd7DW-0006Mh-9y for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 06:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 10:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65414 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65414-submit@debbugs.gnu.org id=B65414.169382483524440 (code B ref 65414); Mon, 04 Sep 2023 10:54:02 +0000 Original-Received: (at 65414) by debbugs.gnu.org; 4 Sep 2023 10:53:55 +0000 Original-Received: from localhost ([127.0.0.1]:48883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd7DO-0006M8-Hp for submit@debbugs.gnu.org; Mon, 04 Sep 2023 06:53:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd7DM-0006Lu-3t for 65414@debbugs.gnu.org; Mon, 04 Sep 2023 06:53:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qd7DE-0002Jn-I4; Mon, 04 Sep 2023 06:53:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PW05xe4eUsdizniAZU4Z2EaRH01aADeRglnHGnwR6uI=; b=D9JvOnRludJQ rxxsII+upU7s1F8f1msTng+lqx0l4wsYLR+stHcFiqWyIwtYAfdiCpYEQnA0gcTVUYQ2Yi0L04E44 qVItiPsx3cvkb64q8VjbequCIkpic2vmzVlRkf9j5LvcfkTlZA/XAKFHYtbYolhVCj96yZ1i+sDg3 rEm2TiDIhyzrLlRWkrA6EA1PZUoEJvWeCtKoNBhmqK1OumlVjf3ktntJTBr17sytzsepYxxTdyyfh 6D9Q6j+POpkWRQCsVE8ZURdNz0eOUVg1zMQBZapO1m9gNJoYyfl3PGIEcboCfay0UYp/zVnwA4jAb NJ6/co/tyBc413oInxd4JQ==; In-Reply-To: <87bkejnm6i.fsf@breatheoutbreathe.in> (message from Joseph Turner on Sun, 03 Sep 2023 10:52:39 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269228 Archived-At: > From: Joseph Turner > Cc: Eli Zaretskii , 65414@debbugs.gnu.org, jonas@bernoul.li > Date: Sun, 03 Sep 2023 10:52:39 -0700 > > > Stefan Monnier writes: > > > [ Arguably, it would be even better to arrange for `hyperdrive.el` to > > save its buffers "in the usual way", i.e. relying on > > `buffer-offer-save`, `save-buffer`, `buffer-save-without-query, ... ] > > I was not aware of `buffer-offer-save`. Thank you for the suggestion! > Since we already rely on `save-buffer`, setting `buffer-offer-save` to t > is much simpler than adding to `save-some-buffers-functions`. It also > resolves the interference between Magit and hyperdrive.el. Does this mean we can close this issue without any changes to the save-some-buffers-functions machinery?