From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65491: [PATCH] Improve performance allocating vectors Date: Sat, 16 Sep 2023 20:09:01 +0300 Message-ID: <83r0mygi4y.fsf@gnu.org> References: <6B2EDD07-AAEB-40E8-B369-F634296BD3D9@gmail.com> <83v8cagkqv.fsf@gnu.org> <83ttrugkj2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25917"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65491@debbugs.gnu.org, monnier@iro.umontreal.ca To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 16 19:10:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qhYoB-0006Ub-BC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Sep 2023 19:10:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhYny-0002zU-SM; Sat, 16 Sep 2023 13:10:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhYnr-0002z1-Us for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2023 13:09:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhYnr-0007dP-NS for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2023 13:09:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qhYny-0004Mv-HW for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2023 13:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Sep 2023 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65491 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65491-submit@debbugs.gnu.org id=B65491.169488416416733 (code B ref 65491); Sat, 16 Sep 2023 17:10:02 +0000 Original-Received: (at 65491) by debbugs.gnu.org; 16 Sep 2023 17:09:24 +0000 Original-Received: from localhost ([127.0.0.1]:48479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhYnM-0004Lp-7r for submit@debbugs.gnu.org; Sat, 16 Sep 2023 13:09:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhYnI-0004LW-B5 for 65491@debbugs.gnu.org; Sat, 16 Sep 2023 13:09:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhYn5-0007Ut-6S; Sat, 16 Sep 2023 13:09:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=vgIjwl749QWDJH8iZMAqUsUHbQFzbDFAZ9d1tpMIJd4=; b=K20u8oxyKA+ufXT5oJZl DhLNxb4gEnekp4s7PvmGRWGF1tkWyZwcDhF+iUVCq0Bg5wQAoeWl7DGk168i30KpZNWNsf9ygqGQg j64Cei9kefaARmaKnRJyIy7lwDbFMcDpZ+qI7RTQmIh6qIk1WbVfM00YAngvTb2UQyBOpODotPg4Y pkddvfvgQP3bJW8vWYYHnXtaDG94zd6yHU/XPQE6ujeQjQjI51n8ChovYB0S2/k4rMMPNGppidtgu 5EK624C/CX9qBqNyZZN4euO0lI8P7YDLsZdignuaa53QL0gb6s9yCMxtQ+SE8QYRKvqRCsMbJ58SZ TaaBoA4awSjMfA==; In-Reply-To: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Sat, 16 Sep 2023 18:54:27 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270638 Archived-At: > From: Mattias Engdegård > Date: Sat, 16 Sep 2023 18:54:27 +0200 > Cc: 65491@debbugs.gnu.org, > monnier@iro.umontreal.ca > > 16 sep. 2023 kl. 18.32 skrev Mattias Engdegård : > > > #define XUNTAG(a, type, ctype) \ > > ((ctype *) ((uintptr_t) XLP (a) - (uintptr_t)LISP_WORD_TAG (type))) > > I pushed this to master after some experiments. Sorry, I cannot accept this kind of "discussions" when such tricky issues come up. What's the rush of installing changes when you still didn't answer my questions, and we still are not sure these changes are correct? We are touching the deepest bowels of the implementation, so some caution, even trepidation, is in order. So I've reverted the last two changes. Let's finish discussing the need for this change and why you think the last variant is TRT, and install then whatever we decide is needed. I also added Paul to the discussion, since he wrote most of the involved macros.