unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ulrich Mueller <ulm@gentoo.org>
Cc: 66125-done@debbugs.gnu.org
Subject: bug#66125: 29.1; configure --with-small-ja-dic has no effect
Date: Sun, 24 Sep 2023 15:33:41 +0300	[thread overview]
Message-ID: <83r0mn3g4a.fsf@gnu.org> (raw)
In-Reply-To: <uwmwg60jm@gentoo.org> (message from Ulrich Mueller on Sat, 23 Sep 2023 23:29:33 +0200)

> From: Ulrich Mueller <ulm@gentoo.org>
> Cc: 66125@debbugs.gnu.org
> Date: Sat, 23 Sep 2023 23:29:33 +0200
> 
> >>>>> On Sat, 23 Sep 2023, Eli Zaretskii wrote:
> 
> >> > (The "if test" part of the new target's rules could be updated to
> >> > check that the small-ja-dic-option file exists, and generate a
> >> > non-empty file if not.)
> >> 
> >> IMHO this would be cleaner.
> 
> > Can you try that and see if there are no other issues?
> 
> I did some tests and ended up replacing the small-ja-dic-option recipe
> in leim/Makefile.in with something very simple:
> 
> # This is used to support regeneration of ja-dic when the SMALL_JA_DIC
> # option is flipped by the configure-time option.
> small-ja-dic-option: ../config.status
> 	$(AM_V_GEN)echo "small ja-dic option: $(SMALL_JA_DIC)" > $@.$$$$ && \
> 	${top_srcdir}/build-aux/move-if-change $@.$$$$ $@
> 
> AFAICS this does what is intended, i.e. the detour via recording the
> option in ja-dic.el isn't even needed.

Thanks, I went with your suggestion in leim/Makefile.in.  But I kept
the recording of the value in ja-dic.el, as I think it's a good idea
nonetheless, for future investigations of possible issues.

And with that, I'm closing the bug.





  reply	other threads:[~2023-09-24 12:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20 16:16 bug#66125: 29.1; configure --with-small-ja-dic has no effect Ulrich Mueller
2023-09-20 16:27 ` Eli Zaretskii
2023-09-20 16:58   ` Ulrich Mueller
2023-09-20 17:02     ` Eli Zaretskii
2023-09-20 18:21       ` Ulrich Mueller
2023-09-20 18:54         ` Eli Zaretskii
2023-09-23  7:55       ` Eli Zaretskii
2023-09-23  9:15         ` Ulrich Mueller
2023-09-23  9:35           ` Eli Zaretskii
2023-09-23 11:30             ` Ulrich Mueller
2023-09-23 12:39               ` Eli Zaretskii
2023-09-23 21:29                 ` Ulrich Mueller
2023-09-24 12:33                   ` Eli Zaretskii [this message]
2023-09-24 14:57                     ` Ulrich Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r0mn3g4a.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=66125-done@debbugs.gnu.org \
    --cc=ulm@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).