From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67275: [PATCH] ; Improve and add tests for Completion Preview mode Date: Sat, 25 Nov 2023 12:12:49 +0200 Message-ID: <83r0kecfa6.fsf@gnu.org> References: <8334x2ko1y.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5739"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67275@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 25 11:14:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6pg0-0001Ip-HQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Nov 2023 11:14:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6pfl-0001xL-1R; Sat, 25 Nov 2023 05:14:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6pfi-0001sU-5a for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 05:13:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6pfh-0007Mb-IT for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 05:13:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6pfm-00054i-H5 for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 05:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Nov 2023 10:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67275-submit@debbugs.gnu.org id=B67275.170090718419407 (code B ref 67275); Sat, 25 Nov 2023 10:14:02 +0000 Original-Received: (at 67275) by debbugs.gnu.org; 25 Nov 2023 10:13:04 +0000 Original-Received: from localhost ([127.0.0.1]:37893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6peq-00052w-4z for submit@debbugs.gnu.org; Sat, 25 Nov 2023 05:13:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6peo-00052Q-1S for 67275@debbugs.gnu.org; Sat, 25 Nov 2023 05:13:02 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6ped-0007I4-MA; Sat, 25 Nov 2023 05:12:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1dGM9253CLNjmXy4dVxQCFHo64j7G/aVfJJJJxgWXII=; b=KTdvU99u4Qzo kt6Mfj4ND/zUqnHcVMrjLnVpoTQknP+SMFb/R3PQBPE6eWAvuj47ndfESFzE5MGuBTMQHKuyGmGoX 1aTd1mk+IjWpIocTDwYWWLoCw5tujwxKYFKF0vLyauiGrJ1VeIyMx3FUk9K3mSot75VU4Ji+E2TCw nSEB+0Mc7HdGfxUYPj1J8zoBKLx3lZUMkuYVeUF9k9CwS1qOZeLooe1Ty2m+dhZdn8eKcnC0o8raC 6UYfKPuPZfDXyuYVggAWAZ1xYGIjoFrjZqgg3sW4OdYbDODHLFQw+/Ylq3EzSUaOxBCwWEHjXgpuq xIUYgrUjDoASqFjsOIfFRw==; In-Reply-To: (message from Eshel Yaron on Mon, 20 Nov 2023 13:26:45 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274946 Archived-At: > From: Eshel Yaron > Cc: Eli Zaretskii , 67275@debbugs.gnu.org > Date: Mon, 20 Nov 2023 13:26:45 +0100 > > Eshel Yaron writes: > > > ...Here's the updated patch... > > I'm attaching below another patch, which is meant to be applied on top > of the patch from my previous message. > > This patch simplifies Completion Preview mode a bit and, crucially, > fixes an issue where certain `completion-at-point-functions` > configurations could prevent `completion-preview-insert` from actually > inserting the completion suggestion. > > I could unify this patch with the previous one and submit them as a > single patch if that'd be preferable, although in terms of Git history > it might be nicer to commit them separately IMO. Thanks, installed on master. Should we now close this bug? P.S. Please make a point of mentioning the bug number as part of the commit log messages, whenever you know the number. (The initial patch that creates a bug report usually doesn't know the number, but subsequent submissions do.)