unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Eshel Yaron <me@eshelyaron.com>
Cc: 67275@debbugs.gnu.org
Subject: bug#67275: [PATCH] ; Improve and add tests for Completion Preview mode
Date: Sat, 25 Nov 2023 12:12:49 +0200	[thread overview]
Message-ID: <83r0kecfa6.fsf@gnu.org> (raw)
In-Reply-To: <m1r0kkwqyi.fsf@sp-byods-145-109-20-84.wireless.uva.nl> (message from Eshel Yaron on Mon, 20 Nov 2023 13:26:45 +0100)

> From: Eshel Yaron <me@eshelyaron.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  67275@debbugs.gnu.org
> Date: Mon, 20 Nov 2023 13:26:45 +0100
> 
> Eshel Yaron writes:
> 
> > ...Here's the updated patch...
> 
> I'm attaching below another patch, which is meant to be applied on top
> of the patch from my previous message.
> 
> This patch simplifies Completion Preview mode a bit and, crucially,
> fixes an issue where certain `completion-at-point-functions`
> configurations could prevent `completion-preview-insert` from actually
> inserting the completion suggestion.
> 
> I could unify this patch with the previous one and submit them as a
> single patch if that'd be preferable, although in terms of Git history
> it might be nicer to commit them separately IMO.

Thanks, installed on master.

Should we now close this bug?

P.S. Please make a point of mentioning the bug number as part of the
commit log messages, whenever you know the number.  (The initial patch
that creates a bug report usually doesn't know the number, but
subsequent submissions do.)





  parent reply	other threads:[~2023-11-25 10:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-19 10:25 bug#67275: [PATCH] ; Improve and add tests for Completion Preview mode Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-19 10:58 ` Eli Zaretskii
2023-11-19 11:23   ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-20 12:26     ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-24  7:32       ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-24  7:56         ` Eli Zaretskii
2023-11-25 10:12       ` Eli Zaretskii [this message]
2023-11-25 11:15         ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-25 11:18           ` Eli Zaretskii
2023-11-25 10:11     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r0kecfa6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=67275@debbugs.gnu.org \
    --cc=me@eshelyaron.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).