From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Thu, 14 Dec 2023 20:49:50 +0200 Message-ID: <83r0jopqk1.fsf@gnu.org> References: <878r919qfh.fsf@localhost> <87v8935wik.fsf@localhost> <83msuftr0i.fsf@gnu.org> <87plzbxtxa.fsf@localhost> <87y1dzvvf0.fsf@localhost> <83plzas3pg.fsf@gnu.org> <87r0jqw8u9.fsf@localhost> <83jzpis08a.fsf@gnu.org> <87il52w744.fsf@localhost> <83fs06rz10.fsf@gnu.org> <87fs06w4ui.fsf@localhost> <83bkaurut9.fsf@gnu.org> <87o7esq319.fsf@localhost> <83bkasrb3f.fsf@gnu.org> <83wmtgpuyf.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18909"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, yantar92@posteo.net, mattias.engdegard@gmail.com, 66117@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 14 19:50:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rDqmq-0004dK-Ol for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Dec 2023 19:50:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rDqmc-0001HC-2H; Thu, 14 Dec 2023 13:50:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDqmZ-0001Gb-LU for bug-gnu-emacs@gnu.org; Thu, 14 Dec 2023 13:50:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rDqmZ-0006Gi-1W for bug-gnu-emacs@gnu.org; Thu, 14 Dec 2023 13:50:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rDqmY-00038o-DN for bug-gnu-emacs@gnu.org; Thu, 14 Dec 2023 13:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Dec 2023 18:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.170257979912061 (code B ref 66117); Thu, 14 Dec 2023 18:50:02 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 14 Dec 2023 18:49:59 +0000 Original-Received: from localhost ([127.0.0.1]:50928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDqmV-00038S-0O for submit@debbugs.gnu.org; Thu, 14 Dec 2023 13:49:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDqmT-00038C-My for 66117@debbugs.gnu.org; Thu, 14 Dec 2023 13:49:58 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDqmN-00067s-Ey; Thu, 14 Dec 2023 13:49:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=diE2bqzyZ0vtCgQjaCjUMa8c4yIlFCBAVoVaqjcWLkg=; b=UwhNAZ7qyQCu s6kTEdCyrdTMQVsxOHRunh5tbrG+vJjQOwGCBye5FdtiWKmBOvoxuLIGwXaiIhfX3jPm4LSoygR9c sYKr+Z02bmLI07/IA+jaCkDecs9BSKPi+tQ+2ObhBd0gce8zNhf4+1mzdurJ6Oor0n1iuetv3Bzr7 3M/C+S+NBSNdx04KAclSEH3Ktn+FWnFm8H8aQCWzrOQIYl85fatEp6NTtM+z63wMH4vxW4yd8rjIf LXzGeqHnuw5t44ktMblW8naSy/S2o2UbRQYx1zDrio4V8uRv6TVV2VoZkpMNPaPX8nTUu5tBIYCCY CJVfNbdXV5BUCKZoLhPhYA==; In-Reply-To: (message from Stefan Monnier on Thu, 14 Dec 2023 13:11:58 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276208 Archived-At: > From: Stefan Monnier > Cc: yantar92@posteo.net, dmitry@gutov.dev, 66117@debbugs.gnu.org, > mattias.engdegard@gmail.com > Date: Thu, 14 Dec 2023 13:11:58 -0500 > > >> > But for starters, a new Lisp-only global variable should be good, I > >> > think. Stefan, any comments? > >> > >> I must say I don't understand the reasoning behind this. > >> What would it do different from `case-fold-search`? > > > > It won't be buffer-local-if-changed, so binding it will not be costly. > > As mentioned elsewhere in this bug-report we can make `case-fold-search` > into a `DEFVAR_LISP`: it would have no visible impact to ELisp and would > avoid the costly let-bindings. Didn't we just agree that would be a breaking change? > > It also won't be a defcustom, so let-binding it will not step on the > > user's preferences. > > Hmm... when/where do existing let-bindings of `case-fold-search` step on > user settings of that var? Each time we let-bind it in code used in searching and/or matching commands. > IME the problem is rather the opposite: most calls to search functions > don't explicitly let-bind `case-fold-search` and instead rely naively on > the default value and are thus susceptible to bugs if/when someone sets > the custom var (globally or buffer-locally). I don't see that as a bug: the user said he/she wants the search to be case-insensitive, so they should get what they asked for.