unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Theodor Thornhill <theo@thornhill.no>
Cc: jacobtophatleeming@gmail.com, 67709@debbugs.gnu.org
Subject: bug#67709: 29.1.50; [patch] missing indent rule for parameter list in csharp-ts-mode
Date: Tue, 09 Jan 2024 21:59:41 +0200	[thread overview]
Message-ID: <83r0iqnuqa.fsf@gnu.org> (raw)
In-Reply-To: <87mstuvjlu.fsf@thornhill.no> (message from Theodor Thornhill on Thu, 28 Dec 2023 09:04:13 +0100)

> From: Theodor Thornhill <theo@thornhill.no>
> Cc: jacobtophatleeming@gmail.com, 67709@debbugs.gnu.org
> Date: Thu, 28 Dec 2023 09:04:13 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Ping!  Theo, could you please look into this?
> >
> 
> Absolutely, thanks!

Any progress?

> >> Cc: 67709@debbugs.gnu.org
> >> Date: Sat, 16 Dec 2023 13:39:58 +0200
> >> From: Eli Zaretskii <eliz@gnu.org>
> >> 
> >> > From: Jacob Leeming <jacobtophatleeming@gmail.com>
> >> > Date: Fri, 8 Dec 2023 13:44:14 +0000
> >> > 
> >> > >From emacs -Q:
> >> > 
> >> > Evaluate this elisp to set up treesitter for csharp:
> >> > 
> >> > (setq treesit-language-source-alist '((c-sharp
> >> > "https://github.com/tree-sitter/tree-sitter-c-sharp" "master" "src"))
> >> >       treesit-load-name-override-list '((c-sharp
> >> > "libtree-sitter-csharp" "tree_sitter_c_sharp"))
> >> >       major-mode-remap-alist '((csharp-mode . csharp-ts-mode)))
> >> > 
> >> > Insert the following text into a csharp-ts-mode buffer:
> >> > 
> >> > void ExampleFunction(
> >> >     int arg1,
> >> >   int arg2,
> >> >  int arg3,
> >> > int arg4,
> >> >     int arg5
> >> > )
> >> > {
> >> >     Console.WriteLine(arg1);
> >> > }
> >> > 
> >> > Try to indent the parameters of the function with
> >> > indent-for-tab-command. Nothing will happen.
> >> > 
> >> > This issue can be fixed with the following patch:
> >> > 
> >> > 
> >> > 
> >> > diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el
> >> > index 53c52e6..8cc4e95 100644
> >> > --- a/lisp/progmodes/csharp-mode.el
> >> > +++ b/lisp/progmodes/csharp-mode.el
> >> > @@ -704,7 +704,8 @@ csharp-ts-mode--indent-rules
> >> >       ((parent-is "object_type") parent-bol csharp-ts-mode-indent-offset)
> >> >       ((parent-is "enum_body") parent-bol csharp-ts-mode-indent-offset)
> >> >       ((parent-is "arrow_function") parent-bol csharp-ts-mode-indent-offset)
> >> > -     ((parent-is "parenthesized_expression") parent-bol
> >> > csharp-ts-mode-indent-offset))))
> >> > +     ((parent-is "parenthesized_expression") parent-bol
> >> > csharp-ts-mode-indent-offset)
> >> > +     ((parent-is "parameter_list") parent-bol csharp-ts-mode-indent-offset))))
> >> > 
> >> >  (defvar csharp-ts-mode--keywords
> >> >    '("using" "namespace" "class" "if" "else" "throw" "new" "for"
> >> 
> >> Theo, any comments?  Should I install this?
> >> 
> >> Thanks.
> >> 
> >> 
> >> 
> >> 
> 





  reply	other threads:[~2024-01-09 19:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-08 13:44 bug#67709: 29.1.50; [patch] missing indent rule for parameter list in csharp-ts-mode Jacob Leeming
2023-12-08 14:30 ` bug#67709: Jacob Leeming
2023-12-08 14:39   ` bug#67709: Eli Zaretskii
2023-12-16 11:39 ` bug#67709: 29.1.50; [patch] missing indent rule for parameter list in csharp-ts-mode Eli Zaretskii
2023-12-23  9:02   ` Eli Zaretskii
2023-12-28  8:04     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-09 19:59       ` Eli Zaretskii [this message]
2024-01-20  9:05         ` Eli Zaretskii
2024-01-20  9:10           ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r0iqnuqa.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=67709@debbugs.gnu.org \
    --cc=jacobtophatleeming@gmail.com \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).