From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18405: 24.3.93; bat-mode.el Date: Tue, 09 Sep 2014 16:05:02 +0300 Message-ID: <83ppf5aqrl.fsf@gnu.org> References: <87mwaf2pjx.fsf@Rainer.invalid> <87r3zplxmz.fsf@Rainer.invalid> <540BCFFE.2090404@dancol.org> <83iokzcvdk.fsf@gnu.org> <540D008F.1080607@dancol.org> <83tx4ibzot.fsf@gnu.org> <540D18D8.8070901@dancol.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1410267991 14817 80.91.229.3 (9 Sep 2014 13:06:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Sep 2014 13:06:31 +0000 (UTC) Cc: Stromeko@nexgo.de, 18405@debbugs.gnu.org To: Daniel Colascione Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 09 15:06:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XRL7i-0003t5-Iv for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Sep 2014 15:06:18 +0200 Original-Received: from localhost ([::1]:49597 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRL7i-00077Z-2k for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Sep 2014 09:06:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRL7Z-000757-77 for bug-gnu-emacs@gnu.org; Tue, 09 Sep 2014 09:06:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRL7T-0000gA-1D for bug-gnu-emacs@gnu.org; Tue, 09 Sep 2014 09:06:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42985) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRL7S-0000g2-U1 for bug-gnu-emacs@gnu.org; Tue, 09 Sep 2014 09:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XRL7S-0001RI-Ew for bug-gnu-emacs@gnu.org; Tue, 09 Sep 2014 09:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Sep 2014 13:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18405 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18405-submit@debbugs.gnu.org id=B18405.14102679055447 (code B ref 18405); Tue, 09 Sep 2014 13:06:02 +0000 Original-Received: (at 18405) by debbugs.gnu.org; 9 Sep 2014 13:05:05 +0000 Original-Received: from localhost ([127.0.0.1]:34549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XRL6W-0001Pm-C3 for submit@debbugs.gnu.org; Tue, 09 Sep 2014 09:05:05 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:39421) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XRL6R-0001PD-UP for 18405@debbugs.gnu.org; Tue, 09 Sep 2014 09:05:01 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NBM00900X3GL600@a-mtaout22.012.net.il> for 18405@debbugs.gnu.org; Tue, 09 Sep 2014 16:04:53 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NBM009ALXO4HV40@a-mtaout22.012.net.il>; Tue, 09 Sep 2014 16:04:52 +0300 (IDT) In-reply-to: <540D18D8.8070901@dancol.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93179 Archived-At: > Date: Sun, 07 Sep 2014 19:47:52 -0700 > From: Daniel Colascione > CC: Stromeko@nexgo.de, 18405@debbugs.gnu.org > > > My point was that I saw a few of its aspects that might benefit from > > improvements, and if we are going to add that package to Emacs, I'd > > like to see those happen. > > Like what? See below. > In 2011, you just mentioned that we should be using or enhancing > bat-generic-mode My goodness, I hope you don't expect me to forever hold my peace about this just because I happened to write something 3 years ago. Here are my comments: . There are some strange decisions about faces, for example: . the switch letters in Unix-style -x switches are highlighted in font-lock-type-face . redirection characters are highlighted in font-lock-constant-face . opening parenthesis in "echo" commands are given font-lock-warning-face . variable definitions in for loops (the 'x' part in "for %%x") are highlighted with different face from their references in the "do" part of the loop . Text after "echo" (up to redirection character, if any) is always a simple string, except if it's "on" or "off", but is not highlighted as a string, which then causes some random highlighting of the parts of the string that just happen to match other possible syntaxes . Something like this confuses fontification of the redirection character, probably because of the parentheses (the opening paren is given the font-lock-warning-face): echo int main() >junk.c . In general, I don't understand what was intended to be the handling of parentheses, they seem to be either not highlighted at all or given the warning face. . A command of this form: if exist somefile dosomethingwith somefile has "dosomethingwith" sometimes in the font-lock-builtin-face and sometimes with no face at all, not sure why. Looks like when 'somefile' includes slashes, the command is not fontified. . The value to which a variable is set in "set foo-bar" doesn't have any face, which causes some funny fontifications if that value happens to match unrelated syntaxes, as in "set foo=-bar=baz" . The equals sign in "if foo == bar" is sometimes given the font-lock-keyword-face and sometimes no face at all. Here's one example of the latter: if not (%svgsupport%) == (Y) goto :svgDone . This line has its fontifications after "(%distfiles%)" screwed: for %%d in (%distfiles%) do if not exist %%d set fileNotFound=%%d In particular, built-in commands are not fontified as such. . Some built-in commands are missing from ntcmd-shell-builtins: assoc, call, mklink . "dir" and "rem" appear twice in the list in ntcmd-shell-builtins . The support of "set /a" command is incomplete, e.g. try set /a y+=140 Thanks.