From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 18528@debbugs.gnu.org
Subject: bug#18528: 24.3.93; Crash during restoration of frameset from desktop
Date: Wed, 24 Sep 2014 10:15:48 +0300 [thread overview]
Message-ID: <83ppelwkt7.fsf@gnu.org> (raw)
In-Reply-To: <542261CF.2080709@gmx.at>
> Date: Wed, 24 Sep 2014 08:16:47 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: 18528@debbugs.gnu.org
>
> > So now I don't understand why you asked about rounding up, since we
> > evidently already do.
>
> Not everywhere. For example, we don't in FRAME_MESSAGE_BUF_SIZE and
> FRAME_CURSOR_X_LIMIT. And the following check in compute_motion of
> indent.c seems dubious as well.
>
> if (!NILP (Vtruncate_partial_width_windows)
> && (total_width < FRAME_COLS (XFRAME (WINDOW_FRAME (win)))))
That has nothing to do with rounding, does it?
Anyway, FRAME_MESSAGE_BUF_SIZE has nothing to do with frame/window
width, AFAIR, it is just computed based on the width.
FRAME_CURSOR_X_LIMIT is used only for the echo area, so the
probability of having a non-default font there is very low. We should
probably do that calculation in pixels, though.
As for the second example, I have a difficulty concocting a use case
when it should matter, due to a combination of conditions that enter
that block. But feel free to fix that if it sometimes gives bad
results.
next prev parent reply other threads:[~2014-09-24 7:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 15:23 bug#18528: 24.3.93; Crash during restoration of frameset from desktop Eli Zaretskii
2014-09-22 17:43 ` martin rudalics
2014-09-22 18:13 ` Eli Zaretskii
2014-09-23 5:48 ` martin rudalics
2014-09-23 15:26 ` Eli Zaretskii
2014-09-23 16:15 ` martin rudalics
2014-09-23 18:46 ` Eli Zaretskii
2014-09-23 19:17 ` martin rudalics
2014-09-23 19:30 ` Eli Zaretskii
2014-09-23 19:42 ` Eli Zaretskii
2014-09-24 6:16 ` martin rudalics
2014-09-24 7:15 ` Eli Zaretskii [this message]
2014-09-24 7:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ppelwkt7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=18528@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).