From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20734: 25.0.50; "Args out of range" with help-window-select t Date: Fri, 05 Jun 2015 22:56:16 +0300 Message-ID: <83pp5and3z.fsf@gnu.org> References: <86vbf3tfwj.fsf@members.fsf.org> <83r3pqpsh0.fsf@gnu.org> <867fritskw.fsf@members.fsf.org> <83bngup8ub.fsf@gnu.org> <866172rl5z.fsf@members.fsf.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1433534260 22960 80.91.229.3 (5 Jun 2015 19:57:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Jun 2015 19:57:40 +0000 (UTC) Cc: 20734@debbugs.gnu.org To: Nicolas Richard Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 05 21:57:29 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z0xjt-00083R-Fr for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jun 2015 21:57:13 +0200 Original-Received: from localhost ([::1]:49342 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0xjs-0002cY-NG for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jun 2015 15:57:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0xjo-0002cM-HO for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 15:57:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0xjk-0007Bu-8E for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 15:57:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60424) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0xjk-0007Bo-5F for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 15:57:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z0xjj-0005df-SN for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 15:57:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2015 19:57:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20734-submit@debbugs.gnu.org id=B20734.143353419121608 (code B ref 20734); Fri, 05 Jun 2015 19:57:03 +0000 Original-Received: (at 20734) by debbugs.gnu.org; 5 Jun 2015 19:56:31 +0000 Original-Received: from localhost ([127.0.0.1]:42156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0xjD-0005cO-3H for submit@debbugs.gnu.org; Fri, 05 Jun 2015 15:56:31 -0400 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:43990) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0xj7-0005bq-16 for 20734@debbugs.gnu.org; Fri, 05 Jun 2015 15:56:25 -0400 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NPH00G00L8JGQ00@mtaout24.012.net.il> for 20734@debbugs.gnu.org; Fri, 05 Jun 2015 22:48:00 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NPH00FFELO0GZ30@mtaout24.012.net.il>; Fri, 05 Jun 2015 22:48:00 +0300 (IDT) In-reply-to: <866172rl5z.fsf@members.fsf.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103627 Archived-At: > From: Nicolas Richard > Cc: 20734@debbugs.gnu.org > Date: Fri, 05 Jun 2015 21:48:40 +0200 > > Eli Zaretskii writes: > > Yes, that's the bug. But the real problem is that we've switched > > windows temporarily, and we shouldn't move point in the current buffer > > at all when we do that. > > Ok. I think I understand now. What about adding an assertion to make > sure current_buffer is shown in selected_window at that point? That'd be fine with me. > > I think we shouldn't call adjust_point_for_property in this case > > at all. Can you see if adding > > > > && EQ (XWINDOW (selected_window)->contents, current_buffer) > > > > to the condition that guards the call to adjust_point_for_property > > fixes the problem? > > Yes it does, but I wrapped the lhs into XBUFFER : > > && EQ (XBUFFER (XWINDOW (selected_window)->contents), current_buffer) Sorry, my bad. But in that case, you don't need EQ, just use == to compare 2 C pointers.