From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21092: 25.0.50; Option `lazy-highlight-max-at-a-time' does not work Date: Sat, 29 Aug 2015 10:07:44 +0300 Message-ID: <83pp26373z.fsf@gnu.org> References: <9e1b9e19-6a1e-4241-a3e6-2876509e1423@default> <7245a30d-355a-425e-b19b-1c9ecc5e94e3@default> <83lhcv4wp4.fsf@gnu.org> <56e13714-27a7-47f9-93df-299b4a25457d@default> <87si73dsjt.fsf@mail.linkov.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1440832145 32651 80.91.229.3 (29 Aug 2015 07:09:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 29 Aug 2015 07:09:05 +0000 (UTC) Cc: juri@linkov.net, 21092@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 29 09:08:49 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZVaFs-0003a9-F4 for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Aug 2015 09:08:48 +0200 Original-Received: from localhost ([::1]:51307 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVaFr-0007vH-TW for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Aug 2015 03:08:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVaFC-00071w-8S for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2015 03:08:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZVaF8-0008DF-QU for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2015 03:08:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVaF8-0008Cv-NI for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2015 03:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZVaF8-0005aU-3K for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2015 03:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Aug 2015 07:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21092-submit@debbugs.gnu.org id=B21092.144083206421456 (code B ref 21092); Sat, 29 Aug 2015 07:08:02 +0000 Original-Received: (at 21092) by debbugs.gnu.org; 29 Aug 2015 07:07:44 +0000 Original-Received: from localhost ([127.0.0.1]:41959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVaEq-0005Zz-4t for submit@debbugs.gnu.org; Sat, 29 Aug 2015 03:07:44 -0400 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:49343) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVaEn-0005Zq-4N for 21092@debbugs.gnu.org; Sat, 29 Aug 2015 03:07:42 -0400 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NTU00G000MOCH00@mtaout28.012.net.il> for 21092@debbugs.gnu.org; Sat, 29 Aug 2015 10:07:31 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NTU00HTC14JDU00@mtaout28.012.net.il>; Sat, 29 Aug 2015 10:07:31 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105939 Archived-At: > Date: Fri, 28 Aug 2015 14:43:11 -0700 (PDT) > From: Drew Adams > Cc: Eli Zaretskii , 21092@debbugs.gnu.org > > Please see the simple patch I sent, which I think takes care of this. If we are going to extend highlighting beyond the displayed portion of the buffer, then your proposed patch needs more work, IMO. AFAIU, with your patch, setting lazy-highlight-max-at-a-time to, say, 2000, will still limit the highlighting to the displayed portion, which makes little sense to me, as the probability of finding more than 2000 matches in a single window-full is practically zero, and so the user's intent will not be honored (and the doc string will still be misleading). Instead, I suggest to use a special non-nil value, e.g. zero or -1, to indicate a limit to the current window's end, and treat any other value literally, disregarding the window limits. (This will need to be reflected in the documentation, of course.) That special value should IMO be the default. Or maybe introduce a separate predicate option for whether to limit to window start and end. Yes, this would be a backward-incompatible change, but I don't think the difference will matter too much in most use cases, especially with the default value of lazy-highlight-cleanup. Btw, another issue that arises in this regard is whether to highlight beyond the screen only in the direction of the search (which AFAICS is what your proposed patch does) or in both directions, especially when the value of lazy-highlight-max-at-a-time is nil.