bug#1092: compilation-goto-error goes to wrong location when buffer has hidden regions

[Eli Zaretskii <eliz@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]

> From: Glenn Morris <rgm@gnu.org>
> Cc: Andrew Hyatt <ahyatt@gmail.com>,  1092@debbugs.gnu.org,  monnier@iro.umontreal.ca
> Date: Sat, 02 Jan 2016 23:06:15 -0500
> 
> I'm not going to give a recipe for a bug that I marked wontfix 7 years
> ago, and which has recently been closed. If no-one cares enough to
> follow the original example, no one is going to fix it.

(There was no example in the original report, not AFAICT.)

I think Andrew just wanted to DTRT with this bug, which is
commendable, IMO.

I came up with a simple example, see below.

> Selective display is 7 years more obsolete than it was then. Let's
> move on.

I see no reason not to fix this simple bug, so I just did it.

Here's a reproducible recipe, for the record:

 . Visit the attached file
 . Replace every C-j in the commentary block with a C-m
 . M-: (setq selective-display t) RET
 . Save the buffer (note that the file on disk has its newlines
   restored by write-region -- I wonder how many people knew we had
   this feature in write-region)
 . M-x compile RET gcc -Wall -o hello hello.c RET
 . Type "C-x `" and observe the incorrect behavior: point in the
   hello.c buffer goes to the end of the buffer, and the error
   locus is not highlighted

With the current emacs-25 branch, this example works correctly.

I'm marking this bug as done (after reopening it).


[-- Attachment #2: hello.c --]
[-- Type: application/octet-stream, Size: 970 bytes --]

/* Display generation from window structure and buffer text.

	 Copyright (C) 1985-1988, 1993-1995, 1997-2015 Free Software Foundation,
	 Inc.

	 This file is part of GNU Emacs.

	 GNU Emacs is free software: you can redistribute it and/or modify
	 it under the terms of the GNU General Public License as published by
	 the Free Software Foundation, either version 3 of the License, or
	 (at your option) any later version.

	 GNU Emacs is distributed in the hope that it will be useful,
	 but WITHOUT ANY WARRANTY; without even the implied warranty of
	 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
	 GNU General Public License for more details.

	 You should have received a copy of the GNU General Public License
	 along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.  */

#include <stdio.h>

int
main (int argc, char *argv[])
{
  iprintfi ("Hello, world of %d %s\n", argc, argv[0]);

  return argcf + 5;
}