unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Glenn Morris <rgm@gnu.org>
Cc: ahyatt@gmail.com, 1092-done@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#1092: compilation-goto-error goes to wrong location when buffer has hidden regions
Date: Sun, 03 Jan 2016 17:25:53 +0200	[thread overview]
Message-ID: <83poxiadmm.fsf@gnu.org> (raw)
In-Reply-To: <mp37ufwbm0.fsf@fencepost.gnu.org> (message from Glenn Morris on Sat, 02 Jan 2016 23:06:15 -0500)

[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]

> From: Glenn Morris <rgm@gnu.org>
> Cc: Andrew Hyatt <ahyatt@gmail.com>,  1092@debbugs.gnu.org,  monnier@iro.umontreal.ca
> Date: Sat, 02 Jan 2016 23:06:15 -0500
> 
> I'm not going to give a recipe for a bug that I marked wontfix 7 years
> ago, and which has recently been closed. If no-one cares enough to
> follow the original example, no one is going to fix it.

(There was no example in the original report, not AFAICT.)

I think Andrew just wanted to DTRT with this bug, which is
commendable, IMO.

I came up with a simple example, see below.

> Selective display is 7 years more obsolete than it was then. Let's
> move on.

I see no reason not to fix this simple bug, so I just did it.

Here's a reproducible recipe, for the record:

 . Visit the attached file
 . Replace every C-j in the commentary block with a C-m
 . M-: (setq selective-display t) RET
 . Save the buffer (note that the file on disk has its newlines
   restored by write-region -- I wonder how many people knew we had
   this feature in write-region)
 . M-x compile RET gcc -Wall -o hello hello.c RET
 . Type "C-x `" and observe the incorrect behavior: point in the
   hello.c buffer goes to the end of the buffer, and the error
   locus is not highlighted

With the current emacs-25 branch, this example works correctly.

I'm marking this bug as done (after reopening it).


[-- Attachment #2: hello.c --]
[-- Type: application/octet-stream, Size: 970 bytes --]

/* Display generation from window structure and buffer text.

	 Copyright (C) 1985-1988, 1993-1995, 1997-2015 Free Software Foundation,
	 Inc.

	 This file is part of GNU Emacs.

	 GNU Emacs is free software: you can redistribute it and/or modify
	 it under the terms of the GNU General Public License as published by
	 the Free Software Foundation, either version 3 of the License, or
	 (at your option) any later version.

	 GNU Emacs is distributed in the hope that it will be useful,
	 but WITHOUT ANY WARRANTY; without even the implied warranty of
	 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
	 GNU General Public License for more details.

	 You should have received a copy of the GNU General Public License
	 along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.  */

#include <stdio.h>

int
main (int argc, char *argv[])
{
  iprintfi ("Hello, world of %d %s\n", argc, argv[0]);

  return argcf + 5;
}

  reply	other threads:[~2016-01-03 15:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-05 18:38 bug#1092: compilation-goto-error goes to wrong location when buffer has hidden regions Peter Sanford
2008-10-07  1:50 ` Stefan Monnier
2011-07-09 18:00   ` Glenn Morris
2016-01-02 21:43     ` Andrew Hyatt
2016-01-03  3:35       ` Eli Zaretskii
2016-01-03  4:06         ` Glenn Morris
2016-01-03 15:25           ` Eli Zaretskii [this message]
2016-01-03 21:13             ` John Wiegley
2016-01-03  6:22       ` Stefan Monnier
2016-01-03 15:31         ` Eli Zaretskii
2016-01-03 16:06           ` Stefan Monnier
2016-01-03 16:53             ` Eli Zaretskii
2016-01-03 19:39               ` Stefan Monnier
2016-01-03 19:49                 ` Eli Zaretskii
2016-01-04  0:42                   ` Stefan Monnier
2016-01-04 15:41                     ` Eli Zaretskii
2016-01-05  4:12                       ` Stefan Monnier
2016-01-05  4:28                         ` Andrew Hyatt
2016-01-05 16:54                           ` Eli Zaretskii
2016-01-05 16:52                         ` Eli Zaretskii
2016-01-05 17:12                           ` Stefan Monnier
2016-01-05 17:27                             ` Eli Zaretskii
2016-01-05 20:00                           ` John Wiegley
2016-01-07  4:17                             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83poxiadmm.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=1092-done@debbugs.gnu.org \
    --cc=ahyatt@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).