From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25088: 25.1; feature-unload and reload of cl-defstruct fails Date: Sun, 04 Dec 2016 05:35:32 +0200 Message-ID: <83pol8l62j.fsf@gnu.org> References: <87eg1qhpjf.fsf@users.sourceforge.net> <83eg1qoiiv.fsf@gnu.org> <87y3zwfxjn.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1480822574 3074 195.159.176.226 (4 Dec 2016 03:36:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Dec 2016 03:36:14 +0000 (UTC) Cc: 25088@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 04 04:36:09 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDNaz-00006x-F9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Dec 2016 04:36:09 +0100 Original-Received: from localhost ([::1]:34060 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDNb3-0003Ar-6T for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Dec 2016 22:36:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDNaw-0003AL-Uz for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2016 22:36:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDNas-0006ZW-3v for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2016 22:36:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36368) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cDNas-0006ZS-0l for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2016 22:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cDNar-00077m-Q4 for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2016 22:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Dec 2016 03:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25088 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25088-submit@debbugs.gnu.org id=B25088.148082253027348 (code B ref 25088); Sun, 04 Dec 2016 03:36:01 +0000 Original-Received: (at 25088) by debbugs.gnu.org; 4 Dec 2016 03:35:30 +0000 Original-Received: from localhost ([127.0.0.1]:51767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDNaM-000771-A9 for submit@debbugs.gnu.org; Sat, 03 Dec 2016 22:35:30 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:60455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDNaK-00076p-PW for 25088@debbugs.gnu.org; Sat, 03 Dec 2016 22:35:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDNaA-0006FF-JD for 25088@debbugs.gnu.org; Sat, 03 Dec 2016 22:35:23 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDNaA-0006F9-Fn; Sat, 03 Dec 2016 22:35:18 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4832 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cDNa9-0002xQ-N2; Sat, 03 Dec 2016 22:35:18 -0500 In-reply-to: <87y3zwfxjn.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126465 Archived-At: > From: npostavs@users.sourceforge.net > Cc: 25088@debbugs.gnu.org > Date: Sat, 03 Dec 2016 17:38:36 -0500 > > Eli Zaretskii writes: > > > > How risky is this change? cl-defstruct is a very widely used macro, > > whereas unload-feature is a relatively obscure feature. Is it really > > worth fixing the (IMO minor) error and risking to break Emacs 25.2? > > > > I don't have an intuition I can trust in these matters, so I need you > > and others who do to offer their opinions, after carefully considering > > the pros and cons. > > I think it's safe, but I've been wrong before. I agree that > unload-feature is sufficiently obscure that this can go to master > instead of emacs-25. Thanks. Any other opinions? I will leave it for a few days for others to chime in. > Perhaps the real bug is that unload-feature doesn't undo `put', thus the > compiler-macro still hangs around. If this means there could be another, safer way of fixing this, please show the details.